ltsp-client-vendor-functions is a broken symlink

Looks like the problem is actually upstream or at least is related to the way we do stuff upstream.

lrwxrwxrwx 1 stgraber stgraber 61 Apr 1 22:39 ./client/functions/Debian/ltsp-client-vendor-functions -> ../../../server/functions/Debian/ltsp-server-vendor-functions

That relative link is fine in the bzr branch but dh_install won't magically figure out the right target when building the package, so that same symlink points to /server on the resulting .deb

We can certainly override this one in the packaging, but we probably should discuss a way to mark these upstream or change the way we deal with the symlinks so that it won't happen with some other link.

We could extract the common code in an ltsp-common package,
or have all the "common" symlinks point to ltsp-trunk/common/*, and insert some code in the packaging to search for symlinks to common and copy those files over the symlinks before dh_install,
or use hardlinks, if those work as expected with bazaar and dh_install.

Here's some code for the second idea - run it from ltsp-trunk.
And of course the "echo" needs to be removed if it goes in the packaging:

find . -type l -printf '%p,%l\n' |
    while { IFS=, read symlink target; }; do
        if [ $(stat -c %i "${symlink%/*}/${target%/*}") -eq $(stat -c %i common) ]; then
            echo cp "common/${target##*/}" "$symlink"
        fi
    done

This bug was fixed in the package ltsp - 5.3.7-0ubuntu2

---------------
ltsp (5.3.7-0ubuntu2) precise; urgency=low

  * Fix ltsp-client-vendor-functions symlink by replacing it by the actual
    target file. (LP: #975769)
 -- Stephane Graber <email address hidden> Tue, 10 Apr 2012 10:04:52 +0200