Duplication between container_format and disk_format

Bug #972014 reported by Shevek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Eoghan Glynn

Bug Description

glance add -H $GLANCE_HOST -A $GLANCE_TOKEN name=oneiric-server-cloudimg-amd64-rootfs is_public=true container_format=aki disk_format=ami kernel_id=$GLANCE_KERNEL < oneiric-server-cloudimg-amd64.img

 Failed to reserve image. Got error: Data supplied was not valid. Details: 400 Bad Request The server could not comply with the request since it is either malformed or otherwise incorrect. Failed to add image metadata. Got error: Data supplied was not valid. Details: Invalid mix of disk and container formats. When setting a disk or container format to one of 'ami', 'ari', or 'ami', the container and disk formats must match.

... Better, if the container_format is ami, the disk_format should be non-required.

Glance as of git head 2012-03.

Revision history for this message
Eoghan Glynn (eglynn) wrote :

Seems the defaulting should be symmetric, i.e. either disk_format follows container_format or vice versa, if one is unset and the other is aki, ari or ami.

Changed in glance:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Eoghan Glynn (eglynn)
milestone: none → folsom-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/6146

Changed in glance:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/6146
Committed: http://github.com/openstack/glance/commit/8e9e0cadaf8ce246861cf661cd4927ba7480484a
Submitter: Jenkins
Branch: master

commit 8e9e0cadaf8ce246861cf661cd4927ba7480484a
Author: Eoghan Glynn <email address hidden>
Date: Tue Apr 3 11:22:07 2012 +0100

    Defaulted amazon disk & container formats

    Fixes bug 972014

    Default unset disk/container format to the corresponding container/disk
    format, where the latter is an amazon format requiring a strict match.

    Change-Id: I147df146940a21c368e95901343f36e1e3b7495b

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: folsom-1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.