Delete button on sharing details page does nothing
Bug #966641 reported by
j.c.sackett
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Ian Booth | ||
Bug Description
The delete button on the rows sharing details page doesn't do anything. It should revoke access to the artifact and remove it from the display.
Related branches
lp:~wallyworld/launchpad/sharing-details-delete-966641
- Curtis Hovey (community): Approve (code)
-
Diff: 1612 lines (+949/-138)32 files modifiedlib/lp/app/javascript/activator/tests/test_activator.js (+1/-1)
lib/lp/app/javascript/autocomplete/tests/test_autocomplete.js (+1/-1)
lib/lp/app/javascript/choiceedit/tests/test_choiceedit.js (+1/-1)
lib/lp/app/javascript/confirmationoverlay/tests/test_confirmationoverlay.js (+1/-1)
lib/lp/app/javascript/formoverlay/tests/test_formoverlay.js (+1/-1)
lib/lp/app/javascript/formwidgets/tests/test_resizing_textarea.js (+1/-1)
lib/lp/app/javascript/inlineedit/tests/test_inline_edit.js (+1/-1)
lib/lp/app/javascript/overlay/tests/test_overlay.js (+1/-1)
lib/lp/app/javascript/picker/tests/test_picker.js (+1/-1)
lib/lp/app/javascript/picker/tests/test_picker_patcher.js (+1/-1)
lib/lp/app/javascript/subscribers/tests/test_subscribers_list.js (+1/-1)
lib/lp/app/javascript/testing/tests/test_mockio.js (+1/-1)
lib/lp/app/javascript/tests/test_ajax_batch_navigator.js (+1/-1)
lib/lp/app/javascript/tests/test_ajax_log.js (+1/-1)
lib/lp/app/javascript/tests/test_beta_notification.js (+1/-1)
lib/lp/bugs/javascript/bugtask_index.js (+2/-1)
lib/lp/registry/browser/pillar.py (+29/-8)
lib/lp/registry/browser/tests/test_pillar_sharing.py (+69/-3)
lib/lp/registry/javascript/sharing/pillarsharingview.js (+2/-2)
lib/lp/registry/javascript/sharing/sharingdetails.js (+90/-36)
lib/lp/registry/javascript/sharing/sharingdetailsview.js (+202/-0)
lib/lp/registry/javascript/sharing/tests/test_pillarsharingview.js (+1/-1)
lib/lp/registry/javascript/sharing/tests/test_shareelisting_navigator.js (+1/-1)
lib/lp/registry/javascript/sharing/tests/test_shareepicker.js (+1/-1)
lib/lp/registry/javascript/sharing/tests/test_shareetable.js (+1/-1)
lib/lp/registry/javascript/sharing/tests/test_sharingdetails.html (+9/-7)
lib/lp/registry/javascript/sharing/tests/test_sharingdetails.js (+149/-46)
lib/lp/registry/javascript/sharing/tests/test_sharingdetailsview.html (+66/-0)
lib/lp/registry/javascript/sharing/tests/test_sharingdetailsview.js (+305/-0)
lib/lp/registry/javascript/tests/test_team.js (+1/-1)
lib/lp/registry/templates/pillar-sharing-details.pt (+5/-14)
standard_test_template.js (+1/-1)
lp:~wallyworld/launchpad/sharing-details-delete2-966641
- Curtis Hovey (community): Approve (code)
-
Diff: 323 lines (+198/-12)8 files modifiedlib/lp/registry/browser/pillar.py (+1/-1)
lib/lp/registry/browser/tests/test_pillar_sharing.py (+1/-1)
lib/lp/registry/interfaces/accesspolicy.py (+15/-5)
lib/lp/registry/interfaces/sharingservice.py (+20/-0)
lib/lp/registry/model/accesspolicy.py (+9/-5)
lib/lp/registry/services/sharingservice.py (+21/-0)
lib/lp/registry/services/tests/test_sharingservice.py (+97/-0)
lib/lp/registry/tests/test_accesspolicy.py (+34/-0)
lp:~wallyworld/launchpad/sharing-details-delete3-966641
- Richard Harding (community): Abstain
- Curtis Hovey (community): Approve (code)
-
Diff: 342 lines (+194/-19)6 files modifiedlib/lp/registry/browser/pillar.py (+0/-9)
lib/lp/registry/browser/tests/test_pillar_sharing.py (+7/-6)
lib/lp/registry/javascript/sharing/sharingdetails.js (+123/-3)
lib/lp/registry/javascript/sharing/tests/test_sharingdetails.html (+4/-0)
lib/lp/registry/javascript/sharing/tests/test_sharingdetails.js (+53/-0)
lib/lp/registry/templates/pillar-sharing-details.pt (+7/-1)
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Ian Booth (wallyworld) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| tags: | added: sharing |
To post a comment you must log in.
Fixed in stable r15067 <http://