Merge lp:~wallyworld/launchpad/sharing-details-delete3-966641 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Curtis Hovey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15067 |
Proposed branch: | lp:~wallyworld/launchpad/sharing-details-delete3-966641 |
Merge into: | lp:launchpad |
Prerequisite: | lp:~wallyworld/launchpad/sharing-details-delete2-966641 |
Diff against target: |
342 lines (+194/-19) 6 files modified
lib/lp/registry/browser/pillar.py (+0/-9) lib/lp/registry/browser/tests/test_pillar_sharing.py (+7/-6) lib/lp/registry/javascript/sharing/sharingdetails.js (+123/-3) lib/lp/registry/javascript/sharing/tests/test_sharingdetails.html (+4/-0) lib/lp/registry/javascript/sharing/tests/test_sharingdetails.js (+53/-0) lib/lp/registry/templates/pillar-sharing-details.pt (+7/-1) |
To merge this branch: | bzr merge lp:~wallyworld/launchpad/sharing-details-delete3-966641 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Richard Harding (community) | Abstain | ||
Curtis Hovey (community) | code | Approve | |
Review via email:
|
Commit message
Wire up the sharing details ui so that when a pillar artifact is deleted, the ui is updated.
Description of the change
== Implementation ==
Complete the work to allow grants on bugs/branches to be revoked for a user. This branch wires up the ui so that when a successful XHR call is made to revoke access, the sharing details table is updated.
A change was made to the original sharing detail implementation. A NotFound error was raised if the Sharing Details page was requested but there were no shared artifacts. This would only have been applicable if the user url hacked since the link to the details page is not rendered on the Sharing Information page if there are no shared items. However, consider the case where a user goes to the Sharing Details page and there are shared artifacts. They delete all of them. This branch includes javascript code to display a suitable message if the XHR call to revoke removes the last shared artifact - "There are no shared bugs or branches.". If the user hits refresh, they would now get an error and this doesn't seem the best thing to do. Instead now, this branch ensures that they simply see the Sharing Details page with the above message.
== Tests ==
Add yui tests for the new sharingdetails widget functionality.
Modify the PillarSharingDe
== Lint ==
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
Thank you.