OpenStack Identity (keystone)

User can be created with name more than 64 characters in length

Bug #966251 reported by Unmesh Gurjar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Unmesh Gurjar
OpenStack Identity (keystone) 2012.2 "folsom"

Bug Description

Scenario: Using the Keystone Admin API, create a user with name more than 64 characters long.

Expected Result: API must return a 400 BadRequest error specifying the user name length should not exceed 64 characters.

Actual Result: User gets registered, but the name is truncated to 64 characters.

Branch: master

Tags: ntt
Unmesh Gurjar (unmesh-gurjar)
Changed in keystone:
assignee: nobody → Unmesh Gurjar (unmesh-gurjar)
Revision history for this message
Joseph Heck (heckj) wrote :

Unmesh - why is the lack of a 64 character limit an issue?

Changed in keystone:
status: New → Opinion
Revision history for this message
Unmesh Gurjar (unmesh-gurjar) wrote :

The 64 character limit (on using SQL backend) is an issue because without that, it will raise a Conflict on registering an user whose first 64 characters match to an existing user. Which could have been avoided in the first case while registering the first user with long name.
Also, another issue is user is not aware/notified about the name being truncated, so he has no idea of how the name conflicts with the existing user (since new user's name differs say after the 64th character).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/6140

Changed in keystone:
status: Opinion → In Progress
Joseph Heck (heckj)
Changed in keystone:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/10006

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/10006
Committed: http://github.com/openstack/keystone/commit/28061817edc1950bfc1ad61f69baaacaa7a89468
Submitter: Jenkins
Branch: master

commit 28061817edc1950bfc1ad61f69baaacaa7a89468
Author: Unmesh Gurjar <email address hidden>
Date: Thu Jul 19 13:16:12 2012 +0530

    Added user name validation. Fixes bug 966251.

    1. Verified name length while creating/updating user.
    2. Disallowed blank user name in create/update.
    3. Added unit test coverage.

    Change-Id: I55cd5daf34f4f57d4163be403a7a75c5d22baa62

Changed in keystone:
status: In Progress → Fix Committed
yasunori jitsukawa (y-jitsukawa)
Changed in keystone:
status: Fix Committed → In Progress
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → folsom-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.