Ubuntu
gnomeradio package

Uses deprecated GTK3 API

Bug #954993 reported by Pojar Geo on 2012-03-14

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	gnomeradio (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

Building gnomeradio-1.8-2 source in current precise with GTK3 give warnings:

Extract from build log:
-------------------------------------------------------------------------------------
gui.c: In function 'gnome_radio_gui':
gui.c:922:2: warning: 'gtk_vbox_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new' instead [-Wdeprecated-declarations]
gui.c:923:2: warning: 'gtk_hbox_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new' instead [-Wdeprecated-declarations]
gui.c:924:2: warning: 'gtk_hbox_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new' instead [-Wdeprecated-declarations]
gui.c:925:2: warning: 'gtk_vbox_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new' instead [-Wdeprecated-declarations]
gui.c:926:2: warning: 'gtk_hbox_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new' instead [-Wdeprecated-declarations]
gui.c:937:2: warning: 'gtk_hscale_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkhscale.h:60): Use 'gtk_scale_new' instead [-Wdeprecated-declarations]
gui.c:962:2: warning: 'gtk_vseparator_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkvseparator.h:66): Use 'gtk_separator_new' instead [-Wdeprecated-declarations]
gui.c:965:2: warning: 'gtk_vseparator_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkvseparator.h:66): Use 'gtk_separator_new' instead [-Wdeprecated-declarations]
-------------------------------------------------------------------------------------

and more (see full build log attached)

I will make a patch (soon).

See original description

Tags:

Related branches

lp:ubuntu/precise/gnomeradio

Revision history for this message

Pojar Geo (geoubuntu) wrote on 2012-03-14:

complete build log Edit (308.9 KiB, text/plain)

Revision history for this message

Pojar Geo (geoubuntu) wrote on 2012-03-14:

I post here this patch because bug report for precise isn't open yet.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-03-14:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnomeradio (Ubuntu):
status:	New → Confirmed

Pojar Geo (geoubuntu) on 2012-03-14

description:

updated

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2012-03-14:

The attachment "patch (gnomeradio_1.8-2ubuntu1)" of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags:

added: patch

Revision history for this message

Pojar Geo (geoubuntu) wrote on 2012-03-15:

gnomeradio_1.8-2.1 Edit (46.1 KiB, text/plain)

1. Patch to resolve build warnings about is used deprecated GTK3 API:
build log: https://launchpadlibrarian.net/96639389/buildlog_ubuntu-precise-i386.gnomeradio_1.8-2_BUILDING.txt.gz

2. GTK+ contains a GtkVolumeButton (Gnomeradio is write on GTK+).
I guess it would be better to use this standard widget, instead of the custom BaconVolumeButton which is used now.
Patch to replace BaconVolumeButton with GtkVolumeButton

3. Fixed problems with Gtk3 events and signal:
GLib-GObject-WARNING **: gsignal.c:2295: signal `expose-event' is invalid for instance `0x23b6030'

4. Use standard gstreamer functions to parse a description
   GStreamer contains several functions to parse a description to a bin (gst_parse_bin_from_description[*]).
   Gnomeradio contains two custom functions to do this, but i don't see anything special about those implementations.
   They can, imho, be exchanged for their standard counterpart.

[*]http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/gstreamer-GstParse.html#gst-parse-bin-from-description

5. Update debian/control:
+ moved project homepage field from description to the correct location.
+ add suggests field: lirc-x

Revision history for this message

James Page (james-page) wrote on 2012-03-16:

Un-subscribing ubuntu-sponsors as the linked merge proposal covers this bug.

Revision history for this message

Pojar Geo (geoubuntu) wrote on 2012-03-16:

#10

gnomeradio-gtk3.patch Edit (7.3 KiB, text/plain)

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-03-19:

#11

This bug was fixed in the package gnomeradio - 1.8-2ubuntu1

---------------
gnomeradio (1.8-2ubuntu1) precise; urgency=low

  * debian/patches/gnomeradio-volume_button.patch: replace BaconVolumeButton
    with GtkVolumeButton (LP: #957867)
  * debian/patches/gnomeradio-gtk3.patch: resolve build warnings about is used
    deprecated GTK 3 API (LP: #954993)
  * debian/patches/gnomeradio-draw_signal.patch: fixed problems with GTK 3
    events and signals (LP: #955462)
  * debian/patches/gnomeradio-gstreamer.patch: use standard gstreamer functions
    to parse a description
  * debian/patches/gnomeradio-v4l2.patch: changed defaults autodetection driver
    for using v4l2 (LP: #958030)
  * debian/patches/gnomeradio-lirc.patch: add a lirc command "toggle visible"
  * debian/control: update to starndards-version 3.9.3, changes needed
    + modify Maintainer value to match the Debian Maintainer Field specification
    + moved project homepage field from description to new location.
    + add suggests field: lirc-x
-- POJAR GEORGE <email address hidden> Mon, 19 Mar 2012 08:17:36 +0100