ir-keytable fails to load keymap if second line is a comment

Hello,

the commit message in http://git.linuxtv.org/v4l-utils.git/commitdiff/a3b4e693fe28b3ac6aa1ec892661a61779a76ffe seems to describe your problems.

Please try the latest version (0.8.6) of ir-keytable from the libv4l PPA:

https://code.launchpad.net/~libv4l/+recipe/v4l-utils-stable-0.8

apt-add-repository ppa:libv4l/stable
apt-get update
apt-get upgrade

Does this fix your problems?

Thanks,
Gregor

Hello frankster, or anyone else affected,

Accepted v4l-utils into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Could you test the update so it can move out of staging?

Works fine here.

BEFORE:

gjasny@ubuntu:~$ dpkg -l ir-keytable
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Description
+++-==============-==============-============================================
ii ir-keytable 0.8.6-1ubuntu1 Alter keymaps of Remote Controller devices

gjasny@ubuntu:~$ sudo ir-keytable -c -p NEC -w kworld_pc160-2t
Invalid parameter on line 1 of kworld_pc160-2t
Invalid parameter(s)
ir-keytable: -w: (PROGRAM ERROR) Option should have been recognized!?
Try `ir-keytable --help' or `ir-keytable --usage' for more information.

NOW:

gjasny@ubuntu:~$ dpkg -l ir-keytable
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Description
+++-==============-==============-============================================
ii ir-keytable 0.8.6-1ubuntu2 Alter keymaps of Remote Controller devices

gjasny@ubuntu:~$ sudo ir-keytable -c -p NEC -w kworld_pc160-2t
Read kworld_pc160-2t table
Old keytable cleared
Wrote 1 keycode(s) to driver
Protocols changed to NEC

So from my POV the package should migrate from proposed to updates.

Quantal needs 0.8.8-1ubuntu1 to resolve this bug. I asked Martin to import http://alioth.debian.org/~gjasny-guest/ubuntu/v4l-utils_0.8.8-1ubuntu1.dsc to resolve the bug for Quantal.

Gregor, the source package you've pointed to has this changelog entry:

v4l-utils (0.8.8-1ubuntu1) quantal; urgency=low

  * Merge with Debian unstable. Remaining Ubuntu changes:
    - Stop building the lib32* packages on amd64. (LP #808064)

However, this is inaccurate. Reviewing the delta against Debian shows an additional patch, debian/patches/gcc-4.7.diff. Please document this added patch in the changelog.

BTW, gcc-4.7 is now the default in Debian unstable as well. I don't know why you would have seen a build failure in Launchpad while there's no bug report in Debian, given that there has been a mass bug filing for gcc-4.7 issues, but you may want to double-check that the package is buildable there.

Hello,

I just did a 0.8.8-2 Debian upload containing the aforementioned GCC-4.7
patch and some others. I re-generated the Ubuntu package against the
Debian one. It can be found here:

http://alioth.debian.org/~gjasny-guest/ubuntu/v4l-utils_0.8.8-2ubuntu1.dsc

Thanks,
Gregor

This bug was fixed in the package v4l-utils - 0.8.6-1ubuntu2

---------------
v4l-utils (0.8.6-1ubuntu2) precise-proposed; urgency=low

  * Update upside down table to latest version
  * Fix ir-keytable keymap parsing (LP: #936581)
  * Fix tinyjpeg array out of bounds access
 -- Gregor Jasny <email address hidden> Thu, 10 May 2012 21:02:18 +0200

upload sponsored to quantal - thanks!

This bug was fixed in the package v4l-utils - 0.8.8-2ubuntu1

---------------
v4l-utils (0.8.8-2ubuntu1) quantal; urgency=low

  * Merge with Debian unstable. Remaining Ubuntu changes:
    - Stop building the lib32* packages on amd64. (LP: #808064)
  * Fix ir-keytable keymap parsing (patch in upstream 0.8.7) (LP: #936581)
 -- Gregor Jasny <email address hidden> Wed, 06 Jun 2012 08:54:25 +0200