use dh_installdeb maintscript support

Bug #932209 reported by Colin Watson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
lubuntu-default-settings (Ubuntu)
Fix Released
Undecided
Julien Lavergne

Bug Description

Using 'dpkg-maintscript-helper supports mv_conffile' guards introduces unreliability into upgrades; it means that the conffile is removed or not depending on whether dpkg happens to be unpacked before lubuntu-default-settings. This seems generally undesirable; it would be better to enforce a single code path. This matters because Ubuntu's last LTS release didn't have a sufficient version of dpkg for that; I know Lubuntu wasn't in the last LTS, but this is the last package on my list and it would be good to get the list down to zero!

It would be nice to just use dh_installdeb's support for generating dpkg-maintscript-helper commands, which was introduced in debhelper 8.1.0. This would remove duplicate code from your maintainer scripts - in fact, you could remove your handwritten preinst entirely. Here's a patch. (I'd have submitted this as a merge proposal, but as I understand it it isn't currently possible to file merge proposals against branches in the +junk namespace; maybe lubuntu-default-settings should become a proper project and have the packaging branch moved there?)

Tags: patch
Revision history for this message
Colin Watson (cjwatson) wrote :
tags: added: patch
Revision history for this message
Julien Lavergne (gilir) wrote :

Thanks for the patch, I committed it to the branch

Changed in lubuntu-default-settings (Ubuntu):
assignee: nobody → Julien Lavergne (gilir)
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lubuntu-default-settings - 0.24

---------------
lubuntu-default-settings (0.24) precise; urgency=low

  [ Julien Lavergne ]
  * usr/share/lubuntu/openbox/rc.xml
   - Remove workaround for lxpanel run dialog, now it's fixed in lxpanel.
   - Revert maximised windows by default, need more integration (LP: #926788)
  * debian/control:
   - Add a recommend for xscreensaver, for the locking shortcut (LP: #923001)
  * usr/share/lxpanel/profile/Lubuntu/panels/panel:
   - Set the color font of the panel to white to match the new theme.

  [ Colin Watson ]
  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand. We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.
    (LP: #932209)

  [ Alexander Andjelkovic ]
  * Fixed super-keys were conflicting with other keybinds making them useless.
    (LP: #890394)
 -- Julien Lavergne <email address hidden> Sun, 19 Feb 2012 14:49:00 +0100

Changed in lubuntu-default-settings (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.