OpenStack Compute (nova)

fix quantum manager get_port_by_attachment

Bug #927507 reported by dan wendlandt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
dan wendlandt
OpenStack Compute (nova) 2012.1 "essex"
neutron
Fix Released
High
dan wendlandt
neutron 2012.1 "essex"

Bug Description

there are two things wrong with this call:

1) quantum manager iterates through all ports on a quantum network when dellocating an instance in order to find out what port a particular vif is attached to. This should be updated to use the filtering capabilities of quantum, in which case only a single port will be returned.

2) this call need to be updated to handle the case where the network does not exist, since at the type of running the query, we do not know if the network in question belongs to the VM-owning tenant or the default tenant.

dan wendlandt (danwent)
Changed in nova:
status: New → In Progress
assignee: nobody → dan wendlandt (danwent)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/3796

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/3796
Committed: http://github.com/openstack/nova/commit/38682667c53199e5860c35101ad33c0cdc21e692
Submitter: Jenkins
Branch: master

commit 38682667c53199e5860c35101ad33c0cdc21e692
Author: Dan Wendlandt <email address hidden>
Date: Mon Feb 6 01:32:12 2012 -0800

    bug 927507: fix quantum manager get_port_by_attachment

    - makes query efficient by using Quantum API filters (new in API v1.1)
    - fixes correctness issue where we did not handle case where network
    did not exist in quantum (note: this was masked by a quantum bug that
    will be fixed once this change is into nova).

    Also included a few other minor things in this patchset:
    1) make get_instance_nw_info use network label from DB, which is already
    available, rather than calling out to quantum just to get the name.
    2) quantum manager was not properly cleaning up VIFs in the nova db. This fixes that.
    3) set 'bridge' in nw_info dictionary to the empty string, to clearly indicate that this value is ignored by Quantum Manager.

    Change-Id: Ia1cbb5232f8ce373b605979902f88d7528d3e456

Changed in nova:
status: In Progress → Fix Committed
dan wendlandt (danwent)
Changed in quantum:
status: New → Fix Committed
assignee: nobody → dan wendlandt (danwent)
milestone: none → essex-4
importance: Undecided → High
Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-4
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-4 → 2012.1
Thierry Carrez (ttx)
Changed in quantum:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.