Odoo Addons (MOVED TO GITHUB)

Base_contact: Missing Fields in new design [6.1]

Bug #923440 reported by Etienne Hirt
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Invalid
Wishlist
OpenERP R&D Addons Team 1

Bug Description

Thanks for the new design of base_contact. It fits well into the other
modules.

I appreciate the approach that the data from "location" and contact is
copied and stored thus accessible in the address itself efficiently.

I wonder however, that there are no triggers to update the location items or the contact items in case one of them changes (not the assigment!). Does 6.1 require no trigger for update as in 6.0:
(store={'model': (function, [Params],..)} ?

I'm missing the status fields of an adress as was available in the old design (up to 6.0):

'date_start': fields.date('Date Start',help="Start date of job(Joining Date)"),
'date_stop': fields.date('Date Stop', help="Last date of job"),
'state': fields.selection([('past', 'Past'),('current', 'Current')], \
                                'State', required=True, help="Status of Address"),

Further in order to select the main employer/function the following field was used:
 'sequence_partner': fields.integer('Partner Seq.',help='Order of importance\
                 of this job title in the list of job title of the linked partner'),

and for the order in contacts the following field was used:
'sequence_contact': fields.integer('Contact Seq.',help='Order of\
                     importance of this address in the list of addresses of the linked contact'),

In addition to the direct phone and fax number the 'other' phone number would be appreciated

Thanks

Etienne

P.S. As soon as we have a test installation on 6.1 running I can prepare patches

Related branches

lp:~openerp-community/openobject-addons/trunk-bug-923440-base_contact_finalise6.1
Amit Parik (community): Disapprove
OpenERP Core Team: Pending requested
Diff: 24003 lines (+23690/-0) (has conflicts)
60 files modified
__init__.py (+23/-0)
__openerp__.py (+65/-0)
base_contact.py (+461/-0)
base_contact_demo.xml (+279/-0)
base_contact_view.xml (+321/-0)
i18n/ar.po (+492/-0)
i18n/base_contact.pot (+261/-0)
i18n/bg.po (+504/-0)
i18n/bs.po (+266/-0)
i18n/ca.po (+528/-0)
i18n/cs.po (+501/-0)
i18n/da.po (+318/-0)
i18n/de.po (+527/-0)
i18n/el.po (+486/-0)
i18n/es.po (+541/-0)
i18n/es_AR.po (+384/-0)
i18n/es_CR.po (+530/-0)
i18n/es_EC.po (+529/-0)
i18n/es_MX.po (+582/-0)
i18n/es_PY.po (+492/-0)
i18n/es_VE.po (+582/-0)
i18n/et.po (+377/-0)
i18n/fa.po (+264/-0)
i18n/fi.po (+461/-0)
i18n/fr.po (+530/-0)
i18n/gl.po (+483/-0)
i18n/hr.po (+480/-0)
i18n/hu.po (+439/-0)
i18n/id.po (+263/-0)
i18n/it.po (+530/-0)
i18n/ko.po (+374/-0)
i18n/lo.po (+315/-0)
i18n/lt.po (+364/-0)
i18n/lv.po (+442/-0)
i18n/mn.po (+368/-0)
i18n/nb.po (+388/-0)
i18n/nl.po (+528/-0)
i18n/nl_BE.po (+268/-0)
i18n/oc.po (+354/-0)
i18n/pl.po (+508/-0)
i18n/pt.po (+406/-0)
i18n/pt_BR.po (+527/-0)
i18n/ro.po (+430/-0)
i18n/ru.po (+519/-0)
i18n/sk.po (+425/-0)
i18n/sl.po (+522/-0)
i18n/sq.po (+264/-0)
i18n/sr.po (+467/-0)
i18n/sr@latin.po (+469/-0)
i18n/sv.po (+438/-0)
i18n/th.po (+318/-0)
i18n/tlh.po (+263/-0)
i18n/tr.po (+490/-0)
i18n/uk.po (+274/-0)
i18n/vi.po (+392/-0)
i18n/zh_CN.po (+509/-0)
i18n/zh_TW.po (+461/-0)
process/base_contact_process.xml (+62/-0)
security/ir.model.access.csv (+8/-0)
test/base_contact00.yml (+38/-0)
lp:~vrt-openerp/openobject-addons/6.1-trunk-bug-923440
Amit Parik (community): Disapprove
OpenERP Core Team: Pending requested
Diff: 548 lines (+284/-56)
3 files modified
base_contact/base_contact.py (+161/-25)
base_contact/base_contact_view.xml (+121/-30)
base_contact/security/ir.model.access.csv (+2/-1)
Superseded for merging into lp:openobject-addons
OpenERP Core Team: Pending requested
Diff: 23054 lines (+11150/-1264) (has conflicts)
109 files modified
account/i18n/el.po (+14/-2)
account/i18n/fr.po (+19/-10)
account/i18n/id.po (+48/-22)
account/i18n/mk.po (+25/-15)
account/i18n/nl.po (+259/-70)
account/i18n/pl.po (+12/-3)
account/i18n/ta.po (+12/-2)
account_analytic_analysis/i18n/nl.po (+9/-0)
account_anglo_saxon/i18n/fr.po (+14/-4)
account_anglo_saxon/i18n/nl_BE.po (+100/-0)
account_asset/i18n/fr.po (+48/-27)
account_asset/i18n/nl.po (+72/-54)
account_asset/i18n/pt_BR.po (+49/-38)
account_budget/i18n/nl.po (+11/-2)
account_budget/i18n/pt_BR.po (+11/-1)
account_cancel/i18n/fa.po (+11/-1)
account_cancel/i18n/gu.po (+23/-0)
account_cancel/i18n/id.po (+14/-0)
account_check_writing/i18n/nl.po (+203/-0)
account_followup/i18n/fr.po (+21/-3)
account_followup/i18n/nl.po (+10/-1)
account_invoice_layout/i18n/nl.po (+10/-0)
account_payment/i18n/lv.po (+726/-0)
account_payment/i18n/nl.po (+15/-2)
account_voucher/i18n/fr.po (+70/-39)
account_voucher/i18n/gu.po (+1114/-0)
account_voucher/i18n/nl.po (+13/-4)
account_voucher/i18n/pl.po (+78/-38)
analytic/i18n/fr.po (+19/-6)
analytic_journal_billing_rate/i18n/fr.po (+14/-2)
analytic_journal_billing_rate/i18n/gu.po (+79/-0)
audittrail/i18n/fr.po (+15/-2)
audittrail/i18n/gu.po (+369/-0)
auth_openid/i18n/fr.po.OTHER (+112/-0)
base_action_rule/i18n/gu.po (+496/-0)
base_calendar/base_calendar.py (+13/-29)
base_calendar/i18n/fr.po (+23/-12)
base_contact/base_contact.py (+153/-25)
base_contact/base_contact_view.xml (+115/-29)
base_contact/i18n/fr.po (+24/-14)
base_contact/i18n/gu.po (+264/-0)
base_contact/security/ir.model.access.csv (+2/-1)
base_iban/i18n/es.po (+15/-3)
base_iban/i18n/fr.po (+19/-5)
base_module_doc_rst/i18n/fr.po (+17/-1)
base_module_quality/i18n/fr.po (+17/-7)
base_module_record/i18n/fr.po (+15/-0)
base_setup/i18n/fr.po (+34/-16)
base_synchro/i18n/fr.po (+11/-1)
base_tools/i18n/nl_BE.po (+32/-0)
base_vat/i18n/es.po (+15/-5)
base_vat/i18n/fr.po (+14/-3)
base_vat/i18n/gu.po (+75/-0)
board/i18n/fr.po (+12/-2)
caldav/i18n/fr.po (+15/-5)
caldav/i18n/nl.po (+10/-0)
crm/i18n/fr.po (+74/-51)
crm/i18n/it.po (+12/-1)
crm_caldav/i18n/nl_BE.po (+33/-0)
crm_helpdesk/i18n/fr.po (+18/-8)
decimal_precision/i18n/nl_BE.po (+49/-0)
document/i18n/fr.po (+23/-7)
document/i18n/gu.po (+1003/-0)
document_webdav/i18n/fr.po (+15/-5)
email_template/i18n/nl.po (+9/-0)
fetchmail_hr_recruitment/i18n/fr.po (+32/-0)
fetchmail_hr_recruitment/i18n/pt.po (+32/-0)
google_map/i18n/gu.po (+35/-0)
hr/i18n/en_AU.po (+688/-0)
hr/i18n/id.po (+56/-35)
hr_payroll/i18n/gu.po (+1119/-0)
hr_payroll/i18n/nl.po (+10/-1)
hr_payroll_account/i18n/gu.po (+140/-0)
hr_timesheet/i18n/fr.po (+18/-7)
hr_timesheet_invoice/i18n/fr.po (+51/-26)
hr_timesheet_sheet/i18n/fr.po (+54/-20)
import_base/i18n/fr.po (+100/-0)
import_sugarcrm/i18n/ar.po (+404/-0)
mrp/i18n/fr.po (+12/-0)
mrp_subproduct/i18n/nl.po (+15/-1)
point_of_sale/i18n/bg.po (+209/-189)
point_of_sale/i18n/nl.po (+105/-87)
portal/i18n/nl.po (+9/-0)
product/i18n/es.po (+12/-2)
product/i18n/fr.po (+76/-23)
product/i18n/nl.po (+10/-1)
project/i18n/fr.po (+101/-68)
project/i18n/nl.po (+100/-69)
project_gtd/i18n/fr.po (+39/-28)
project_issue/i18n/fr.po (+35/-25)
project_issue/i18n/nl_BE.po (+981/-0)
project_issue_sheet/i18n/fr.po (+18/-1)
project_issue_sheet/i18n/nl.po (+15/-0)
project_issue_sheet/project_issue_sheet_view.xml (+1/-1)
project_long_term/i18n/fr.po (+41/-18)
project_mailgate/i18n/nl_BE.po (+79/-0)
project_mrp/i18n/nl.po (+14/-0)
project_timesheet/i18n/fr.po (+31/-9)
project_timesheet/i18n/nl.po (+13/-0)
purchase/i18n/fr.po (+13/-3)
purchase/i18n/nl.po (+24/-15)
sale/i18n/fr.po (+58/-32)
sale/i18n/lt.po (+41/-15)
sale_mrp/i18n/nl_BE.po (+53/-0)
share/i18n/nl.po (+9/-0)
stock/i18n/nl.po (+19/-8)
stock_location/i18n/nl.po (+10/-0)
warning/i18n/fr.po (+11/-1)
wiki/i18n/fr.po (+11/-1)
lp:~hirt/ocb-addons/6.1_base_contact_finalize
Omar (Pexego): Needs Fixing (code review, no test)
Diff: 973 lines (+559/-100)
4 files modified
base_contact/__openerp__.py (+11/-6)
base_contact/base_contact.py (+294/-53)
base_contact/base_contact_view.xml (+252/-40)
base_contact/security/ir.model.access.csv (+2/-1)
Superseded for merging into lp:ocb-addons
OpenERP Community Backports: Pending requested
Revision history for this message
Etienne Hirt (hirt) wrote :

Before adding fields the view has too be cleaned.
The location menu in the attached patch might be removed at the end but currently required for checking and corrections

Is there a branch to commit this work?

Revision history for this message
Etienne Hirt (hirt) wrote :
Revision history for this message
Etienne Hirt (hirt) wrote :

Patch adds new fields and ensures sorting for Partner view. Missing is the main function of a contact that has to be added by means of an lookup function getting the job with the lowest sequence number or is there a possibility to define order per parent object?

Revision history for this message
Etienne Hirt (hirt) wrote :

Patch adds new fields and ensures sorting for Partner view. Missing is the main function of a contact that has to be added by means of an lookup function getting the job with the lowest sequence number or is there a possibility to define order per parent object?

Amit Bhavsar (Open ERP) (amb-openerp)
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 1 (openerp-dev-addons1)
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
Etienne Hirt (hirt) wrote :

Can we change the title or move the topic to a specific branch because if more an more covers finalising and correcting the new approach?

Revision history for this message
Etienne Hirt (hirt) wrote :

* The patch removes last_name and uses name instead in order to allow create of contacts
* The patch adds trigger for storage but for 'mobile' and 'title' as they lead to not understood errors
* All fields are now added and the views corrected

Todo:
* fix the main-job for contacts and the main-address for partners
* check the search function
* How to sort on a view basis the address trees for contacts and for partners?

Revision history for this message
Etienne Hirt (hirt) wrote :

* initial correction of search
* selection of main_job of contact based on 'sequence_contact'
* more triggers but even more required and strange bug (see @bug)

Revision history for this message
Etienne Hirt (hirt) wrote :

Now adding the on update contact_id but storage of name in address might be removed also and then this function is not required

More or less finished and ready for review

Missing is the correct sorting for the list of functions within contacts

Revision history for this message
Etienne Hirt (hirt) wrote :

The latest diff result that includes update to trunk version revision 6599 is available in the branch:
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bug-923440-base_contact_finalise6.1 that is linked but I can not see it in this bug form.

Work will be continued in the branch. Input including branch setup correction welcome

Revision history for this message
Etienne Hirt (hirt) wrote :

This is the diff for review that should fix all the mentioned bugs and more

Revision history for this message
Etienne Hirt (hirt) wrote :

Finalized usability in branch https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bug-923440-base_contact_finalise6.1

Still waiting for any review

What shall be done with the base_contact module as it emptied in the current (6.2) trunk?

Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Etienne and Stuart,

As Etienne said, base_contact module is empty for trunk because we have removed this functionality (res.partner.contact object).

That's why we have removed this module from trunk. So this feature can not be consider anymore for trunk.

For 6.1 it's big improvement. 6.1 is stable version, We have consider only blocking point and small change for stable version (because partner are used their production database on stable version, If we done a big commit as a improvement then many problem will occurs on their production database).

So we can not consider this improvement for stable 6.1.

Anyways thanks for contributions.

Hope you will understand this procedure.

Thanks again!

Changed in openobject-addons:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.