[launcher] Tile Progress bar starting from left of launcher, not container

Bug #912777 reported by Gerry Boland
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-2d
Fix Released
Low
Paweł Stołowski
unity-2d (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Best to check out the screenshot to see what I mean.

I started to burn a CR with Brasero, and I noted that the progress bar begins at the left of the launcher, not within the tile itself.

Related branches

Revision history for this message
Gerry Boland (gerboland) wrote :
Changed in unity-2d:
status: New → Confirmed
Gerry Boland (gerboland)
Changed in unity-2d:
milestone: none → 5.6
Changed in unity-2d:
assignee: nobody → Pawel Stolowski (stolowski)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Problem caused by Brasero sending progress value = -1 in the initial stage of burning. The value of -1 is used internally by Brasero to indicate preparation stage or failure when burning; it's just passed "as is" to unity_launcher_entry_set_progress function.

We can fix the call to unity_launcher_entry_set_progress in Brasero to never pass -1. We could also add bounds check in unity2d - libunity-2d-private Application::updateOverlaysState method. But I think it's best to add bounds check (0.0 ... 1.0) in progress setter in libunity.

Changed in unity-2d:
milestone: 5.6 → 5.8
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Just to clarify: this problem affects only unity-2d. Unity is not affected as it seems it enforces received progress values to be within correct range.

Gerry Boland (gerboland)
Changed in unity-2d:
status: Confirmed → Fix Committed
Changed in unity-2d:
milestone: 5.8 → 5.7
Changed in unity-2d:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-2d - 5.7.0-0ubuntu1

---------------
unity-2d (5.7.0-0ubuntu1) precise; urgency=low

  * New upstream release:
    - unity-2d-panel crashed with SIGABRT in Unity2dDebug::unity2dQtHandler()
      (LP: #925457)
    - unity-2d-shell crashed with SIGSEGV in ref() (LP: #947278)
    - Launcher - Make Launcher left of screen reveal more responsive and less
      prone to false positives (LP: #765819)
    - [dash] [launcher] [panel] Tinting based on wallpaper missing
      (LP: #882101)
    - [launcher] In multimonitor setup Unity-2D only shows launcher on one
      monitor (fails MM UX spec #2.8) (LP: #780204)
    - [unity-2d] FF exception to add PointerBarrier to Unity2d (LP: #947976)
    - multimonitor, launcher: Provide an option to display either a single
      launcher or a launcher on each display in a multi-monitor environment
      (LP: #950136)
    - lens switching is not keyboard navigable (LP: #945220)
    - [panel] [multi-monitor] On secondary screen, unable to scrub from
      indicator menu to app menu (LP: #844809)
    - "Workspaces" button displays previous wallpaper (LP: #900019)
    - Dash - cursor should change when pointer is over the search field
      (LP: #849175)
    - Filter checkboxes are without margins in right to left locales
      (LP: #949319)
    - [panel] [multi-monitor] Open indicator menu on one screen causes other
      indicator to look open too (LP: #844798)
    - Dash - horizental divider line in between categories incorrectly drawn
      (LP: #841750)
    - [launcher] Tile Progress bar starting from left of launcher, not
      container (LP: #912777)
    - Dash - dash is not closed with alt+f4 (LP: #891818)
    - [dash] Rating stars in right-to-left locales behave inconsistently.
      (LP: #945719)
    - LensButton.qml:72 warning when running unity-2d (LP: #947276)
    - [dash] Multi-range filters are rendered incorrectly in right-to-left
      locales (LP: #950649)
  * debian/unity-2d.gconf-defaults:
    - removed: not used anymore and causing regression with hide-mode=2
      by default, converted to the gsettings key (LP: #942772)
  * debian/unity-2d.preinst:
    - removed, was a natty -> oneiric transition
  * debian/control, debian/unity-2d-common.install:
    - create unity-2d-common and make some packages depending on it
    - move some files from unity-2d package to unity-2d-common
      (gsettings and apport hook) to have packaging shipping their schema
      (LP: #925457)
  * debian/unity-2d-common.install.in:
    - no more gconf -> gsettings migration shipped
  * debian/unity-2d.postinst, prerm, trigger:
    - moved to unity-2d-common new package, to ensure even people uninstalling
      unity-2d got the right metacity configuration in the session
    - update the trigger to the correct directory
  * debian/control:
    - bump to latest Standards-Version
    - fix some too long description
    - put the transitional packages in the oldlibs/extra section
    - build-dep on libxtst-dev, libxfixes-dev for barrier change
    - need latest metacity for barriers to work
 -- Didier Roche <email address hidden> Mon, 19 Mar 2012 14:07:10 +0100

Changed in unity-2d (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.