Launchpad itself

merge proposal is broken with consistent timeouts

Bug #911090 reported by Lucio Torre
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Aaron Bentley
Tarmac
Invalid
Undecided
Unassigned

Bug Description

merge proposal is broken with consistent timeouts:
OOPS-1d94a4858bdc89ce60555859148a229
OOPS-e7a477631159e6498ee9048998f2747f
etc

while trying to open: https://code.launchpad.net/~lucio.torre/txstatsd/add-redis-to-distinct-plugin/+merge/86438

Related branches

lp:~abentley/launchpad/attachment-timeout
Brad Crittenden (community): Approve (code)
Diff: 1927 lines (+1549/-77)
20 files modified
lib/lp/app/browser/tales.py (+12/-5)
lib/lp/bugs/browser/bugcomment.py (+14/-0)
lib/lp/bugs/browser/configure.zcml (+7/-0)
lib/lp/bugs/browser/tests/test_bugcomment.py (+28/-0)
lib/lp/bugs/interfaces/bugmessage.py (+0/-1)
lib/lp/bugs/stories/bugs/xx-bug-comments-truncated.txt (+4/-0)
lib/lp/code/browser/branchmergeproposal.py (+6/-0)
lib/lp/code/browser/codereviewcomment.py (+19/-0)
lib/lp/code/browser/configure.zcml (+4/-0)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+20/-0)
lib/lp/code/browser/tests/test_codereviewcomment.py (+35/-0)
lib/lp/registry/browser/distroseriesdifference.py (+4/-0)
lib/lp/registry/browser/tests/test_person.py (+1281/-0)
lib/lp/registry/browser/tests/test_person.py.OTHER (+0/-69)
lib/lp/services/comments/browser/comment.py (+53/-0)
lib/lp/services/comments/browser/configure.zcml (+1/-0)
lib/lp/services/comments/browser/messagecomment.py (+5/-0)
lib/lp/services/comments/browser/tests/test_comment.py (+40/-0)
lib/lp/services/comments/interfaces/conversation.py (+11/-0)
lib/lp/services/comments/templates/comment-body.pt (+5/-2)
lp:~abentley/launchpad/fix-index-download
Deryck Hodge (community): Approve
Diff: 103 lines (+35/-15)
3 files modified
lib/lp/code/browser/codereviewcomment.py (+9/-6)
lib/lp/code/browser/configure.zcml (+7/-3)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+19/-6)
Deryck Hodge (deryck)
Changed in launchpad:
status: New → Triaged
importance: Undecided → Critical
tags: added: timeout
Changed in launchpad:
assignee: nobody → Launchpad Orange Squad (launchpad-orange-squad)
Aaron Bentley (abentley)
Changed in launchpad:
assignee: Launchpad Orange Squad (launchpad-orange-squad) → Aaron Bentley (abentley)
Revision history for this message
Aaron Bentley (abentley) wrote :

The problem appears to be this comment: https://code.launchpad.net/~lucio.torre/txstatsd/add-redis-to-distinct-plugin/+merge/86438/comments/186681

It is 16MB, so it cannot be displayed without exceeding our timeout. It contains a list of test failures, some or all of them due to "redis.exceptions.ConnectionError: Error 111 connecting localhost:16379. Connection refused"

Revision history for this message
Aaron Bentley (abentley) wrote :

Per Lucio's request, I have marked this proposal rejected to remove it from the lists. (Actually removing the comment would be considerably more difficult as it would be destructive SQL run against production.)

Revision history for this message
Aaron Bentley (abentley) wrote :

As Lucio surmised, the comment's author is ~ubuntuone-server-tarmac

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r14739 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14739>.

tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
Aaron Bentley (abentley)
tags: added: qa-bad
removed: qa-needstesting
Steve Kowalik (stevenk)
tags: added: bad-commit-14739
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
status: Fix Released → Fix Committed
Aaron Bentley (abentley)
tags: added: qa-ok
removed: qa-bad
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
Revision history for this message
dobey (dobey) wrote :

I'm not sure what is expected for tarmac to do here to consider this a bug in tarmac, or how it would be fixed. Launchpad doesn't support attachments on merge proposal comments, so I don't think there is much we can do to help with this sort of problem, until it does. The full stdout/stderr logs need to be accessible in some way, so that the problem can be debugged when a branch fails to land in tarmac.

For projects where this is consistently a problem, one option is to run tests in CI outside of tarmac, and only have tarmac do the actual merge/commit, without running tests itself.

Changed in tarmac:
status: New → Incomplete
Revision history for this message
Aaron Bentley (abentley) wrote :

Launchpad does support attachments to merge proposal comments. If you look at https://code.launchpad.net/~abentley/bzrtools/testattach/+merge/193415/comments/445522 "diff.diff" is an attachment.

Currently, that support is limited to comments that are sent by mail, not the API or UI, but it wouldn't be hard to expose. Until then, Tarmac could just send mail.

Revision history for this message
dobey (dobey) wrote :

The UI and API do not expose them as attachments, so even if Tarmac could send mail instead (which is not really an option), I don't think it would solve the timeout issue as the content would still be displayed directly in the comments, rather than as links that point to attached files.

dobey (dobey)
Changed in tarmac:
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.