byobu should background some data collections (ec2 metadata)

Bug #894038 reported by Scott Moser
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu (Ubuntu)
Fix Released
High
Dustin Kirkland 

Bug Description

'byobu true' on openstack instance takes 7 seconds or more.
This is really because of bug 851159.

However, anything that byobu does that is blocking start up time (as opposed to status-refresh/update time) that could potentially take a long time should really be backgrounded.

$ grep -r 169.254.169.254 /usr/lib/byobu/ -l
/usr/lib/byobu/hostname
/usr/lib/byobu/include/shutil
/usr/lib/byobu/ip_address
/usr/lib/byobu/ec2_cost

$ time wget -q -O - http://169.254.169.254/latest/meta-data/public-hostname
server-3002.novalocal
real 0m1.422s
user 0m0.000s
sys 0m0.000s

Note, that it is not at all far-fetched that 169.254.169.254 could be firewalled off completely in a security consious environment. That would result in an indefinite hang on byobu startup.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: byobu 4.49-0ubuntu1
ProcVersionSignature: User Name 3.1.0-2.3-virtual 3.1.0
Uname: Linux 3.1.0-2-virtual i686
ApportVersion: 1.26-0ubuntu1
Architecture: i386
Date: Wed Nov 23 15:44:31 2011
Ec2AMI: ami-000000e2
Ec2AMIManifest: FIXME
Ec2AvailabilityZone: nova
Ec2InstanceType: m1.small
Ec2Kernel: unavailable
Ec2Ramdisk: unavailable
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ScreenRC:

SourcePackage: byobu
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Scott Moser (smoser) wrote :
Revision history for this message
Scott Moser (smoser) wrote :

I'm not just making the firewall comment up, one vm system I have access to has such firewalls in place.

Changed in byobu (Ubuntu):
importance: Undecided → High
status: New → In Progress
assignee: nobody → Dustin Kirkland (kirkland)
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

* usr/lib/byobu/ec2_cost, usr/lib/byobu/hostname,
  usr/lib/byobu/include/shutil, usr/lib/byobu/ip_address: LP: #894038
  - background all wgets, as these can be expensive (cough OpenStack cough)
  - sleep for 0.02 seconds after each wget, as most EC2 wgets take less
    than 0.01 seconds, but some might take longer
  - after backgrounded wget and sleep, attempt to read the results of the
    wget from a cache file; if this succeeds, proceed and use it
  - if not, fail through gracefully, and pick up the results from the
    cach file on the next run

Committed revision 1787.

Changed in byobu (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package byobu - 4.50-0ubuntu1

---------------
byobu (4.50-0ubuntu1) precise; urgency=low

  * usr/bin/byobu-mondrian:
    - clean up code, fix idempotence
  * usr/bin/byobu-mondrian => usr/lib/byobu/include/modrian,
    usr/lib/byobu/include/Makefile.am, usr/share/byobu/keybindings/f-
    keys.tmux, usr/share/byobu/keybindings/f-keys.tmux.disable,
    usr/share/doc/byobu/help.tmux.txt:
    - install modrian
  * usr/share/byobu/profiles/tmux:
    - fix action bar color
  * usr/lib/byobu/include/mondrian:
  * usr/lib/byobu/ec2_cost, usr/lib/byobu/hostname,
    usr/lib/byobu/include/shutil, usr/lib/byobu/ip_address: LP: #894038
    - background all wgets, as these can be expensive (cough OpenStack cough)
    - sleep for 0.02 seconds after each wget, as most EC2 wgets take less
      than 0.01 seconds, but some might take longer
    - after backgrounded wget and sleep, attempt to read the results of the
      wget from a cache file; if this succeeds, proceed and use it
    - if not, fail through gracefully, and pick up the results from the
      cach file on the next run
  * usr/share/byobu/keybindings/f-keys.tmux,
    usr/share/byobu/keybindings/f-keys.tmux.disable,
    usr/share/man/man1/byobu.1: LP: #888248
    - add Alt-Insert in tmux for "paste"
    - document scrollback/copy/paste procedures
  * usr/bin/byobu-janitor: LP: #867746
    - create a whitelist of distros carrying the LP: #315871 fix
    - default to monochrome for other distros on initial profile creation
 -- Dustin Kirkland <email address hidden> Fri, 18 Nov 2011 15:41:36 -0600

Changed in byobu (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.