pkgstriptranslations loops over all binary packages instead of just the current one

Bug #890595 reported by Martin Pitt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pkgbinarymangler (Ubuntu)
Fix Released
Low
Martin Pitt

Bug Description

For packages with a lot of binaries, such as haskell-dummy, pkgstriptranslations takes a very long time as it iterates over all binary packages with each call. pkgstripfiles, pkgmaintainermangler, etc. do not do this.

Instead, it should only work on the current binary and update the tarball if it exists.

Martin Pitt (pitti)
Changed in pkgbinarymangler (Ubuntu):
status: New → Triaged
importance: Undecided → Low
Martin Pitt (pitti)
Changed in pkgbinarymangler (Ubuntu):
status: Triaged → Fix Committed
assignee: nobody → Martin Pitt (pitti)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pkgbinarymangler - 106

---------------
pkgbinarymangler (106) precise; urgency=low

  * Move code for determining the location of the binary package control file,
    and its existence check into common, and simplify pkgmaintainermangler,
    pkgsanitychecks, and pkgstripfiles.
  * pkgstriptranslations: Stop iterating over all binary packages, just
    process the current one. Update an existing translation tarball if it
    already exists from a previous run. This greatly speeds up package builds
    with lots of binary packages. (LP: #890595) Also reorganize the code to
    put the different tasks into separate functions, so that it becomes
    easier to read. Drop the now obsolete stripping of XPI files.
  * With this version, haskell-dummy builds in finite time and succeeds.
    (LP: #890596)
 -- Martin Pitt <email address hidden> Tue, 15 Nov 2011 16:00:12 +0100

Changed in pkgbinarymangler (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.