Slingshot

remove padding from left side of category sidebar

Bug #873587 reported by Danielle Foré on 2011-10-13

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Slingshot	Fix Released	Medium	elementary Drive-by Contributors	Slingshot 0.7 "Donatello"

Bug Description

Currently the sidebar is spaced quite some distance from the side of slingshot. It should be right up against the edge such that the category text lines up with the edge of the modebutton and the selected row runs flush against the side of the popover as pictured in the mockup http://fc03.deviantart.net/fs71/f/2011/258/8/d/slingshot_column_view_by_danrabbit-d49xavd.png

See original description

Related branches

lp:~eyelash/slingshot/fix-873587

Merged into lp:~elementary-pantheon/slingshot/trunk at revision 170

Cody Garver (community): Approve on 2012-04-25

Revision history for this message

Danielle Foré (danrabbit) wrote on 2011-10-13:

Picture of the Problem Edit (534.9 KiB, image/png)

description:

updated

Giulio Collura (gcollura) on 2011-10-13

Changed in slingshot:
status:	New → Confirmed
importance:	Undecided → Wishlist

Revision history for this message

Victor Martinez (victored) wrote on 2012-02-26:

We also need to add more padding at the right of the sidebar and render the separator line. Certainly, these kind of visual aspects are relevant, since users will use Slingshot everyday. And no matter how good the backend code is, people will always judge the frontend.

Changed in slingshot:
assignee:	nobody → elementary Drive-by Contributors (elementary-driveby)
importance:	Wishlist → Medium
milestone:	none → 0.8

Revision history for this message

Sergey "Shnatsel" Davidoff (shnatsel) wrote on 2012-02-26:

"Certainly, these kind of visual aspects are relevant, since users will use Slingshot everyday. And no matter how good the backend code is, people will always judge the frontend."
+1

Paulo Galardi (alekasethm-deactivatedaccount) on 2012-02-26

Changed in slingshot:
status:	Confirmed → In Progress
assignee:	elementary Drive-by Contributors (elementary-driveby) → Paulo Galardi (alekasethm)

Revision history for this message

Paulo Galardi (alekasethm-deactivatedaccount) wrote on 2012-02-26:

It has been fixed in the padding problem. Can someone else do the separator rendering, please?

Changed in slingshot:
assignee:	Paulo Galardi (alekasethm) → elementary Drive-by Contributors (elementary-driveby)

Revision history for this message

eyelash (eyelash) wrote on 2012-04-22:

separator.patch Edit (2.8 KiB, text/plain)

Here is a patch to add a separator (this is my first patch so I hope I did it right).

Revision history for this message

Eduard Gotwig (gotwig) wrote on 2012-04-23:

User142: Do you got a screenshot, how it looks after your patch?

Revision history for this message

Danielle Foré (danrabbit) wrote on 2012-04-23:

User 142, I've merged your patch into trunk. Thanks :)

Unfortunately the main bug is still not solved however

Revision history for this message

eyelash (eyelash) wrote on 2012-04-24:

paddings.patch Edit (8.1 KiB, text/plain)

Here's a patch to fix the bug. I had to completely change (and simplify) Utils.set_padding() so that I could change the padding not only on initialization but also afterwards.

Revision history for this message

Danielle Foré (danrabbit) wrote on 2012-04-25:

Elias, that seems to work here. The only thing left to do is re-indent the headings/categories.

Also, could you make a branch merge request instead of attaching a patch? It makes it easier to review/track/merge these kinds of changes.

Cody Garver (codygarver) on 2012-04-25