Merge lp:~eyelash/slingshot/fix-873587 into lp:~elementary-pantheon/slingshot/trunk

Proposed by eyelash
Status: Merged
Merged at revision: 170
Proposed branch: lp:~eyelash/slingshot/fix-873587
Merge into: lp:~elementary-pantheon/slingshot/trunk
Diff against target: 101 lines (+27/-11)
4 files modified
src/SlingshotView.vala (+18/-0)
src/Utils.vala (+6/-9)
src/Widgets/CategoryView.vala (+1/-1)
src/Widgets/Sidebar.vala (+2/-1)
To merge this branch: bzr merge lp:~eyelash/slingshot/fix-873587
Reviewer Review Type Date Requested Status
Cody Garver (community) Approve
Review via email: mp+103429@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/SlingshotView.vala'
2--- src/SlingshotView.vala 2012-04-23 17:41:00 +0000
3+++ src/SlingshotView.vala 2012-04-25 09:10:29 +0000
4@@ -591,6 +591,12 @@
5 view_manager.move (search_view, -130*columns, 0);
6 view_manager.move (category_view, 130*columns, 0);
7 view_manager.move (grid_view, current_position, 0);
8+
9+ // change the paddings/margins back to normal
10+ get_content_area ().set_margin_left (PADDINGS.left + SHADOW_SIZE + 5);
11+ center.set_margin_left (12);
12+ top.set_margin_left (12);
13+ view_manager.set_size_request (default_columns*130, default_rows*145);
14 return;
15
16 case Modality.CATEGORY_VIEW:
17@@ -603,6 +609,12 @@
18 view_manager.move (grid_view, columns*130, 0);
19 view_manager.move (search_view, -columns*130, 0);
20 view_manager.move (category_view, 0, 0);
21+
22+ // remove the padding/margin on the left
23+ get_content_area ().set_margin_left (PADDINGS.left + SHADOW_SIZE);
24+ center.set_margin_left (0);
25+ top.set_margin_left (17);
26+ view_manager.set_size_request (default_columns*130 + 17, default_rows*145);
27 return;
28
29 case Modality.SEARCH_VIEW:
30@@ -611,6 +623,12 @@
31 view_manager.move (grid_view, columns*130, 0); // Move the grid_view away
32 view_manager.move (category_view, columns*130, 0);
33 view_manager.move (search_view, 0, 0); // Show the searchview
34+
35+ // change the paddings/margins back to normal
36+ get_content_area ().set_margin_left (PADDINGS.left + SHADOW_SIZE + 5);
37+ center.set_margin_left (12);
38+ top.set_margin_left (12);
39+ view_manager.set_size_request (default_columns*130, default_rows*145);
40 return;
41
42 }
43
44=== modified file 'src/Utils.vala'
45--- src/Utils.vala 2011-11-11 15:20:28 +0000
46+++ src/Utils.vala 2012-04-25 09:10:29 +0000
47@@ -24,17 +24,14 @@
48
49 class Utils : GLib.Object {
50
51- public static Alignment set_padding (Gtk.Widget widget, int top,
52+ public static Widget set_padding (Gtk.Widget widget, int top,
53 int right, int bottom, int left) {
54
55- var alignment = new Alignment (0.0f, 0.0f, 1.0f, 1.0f);
56- alignment.top_padding = top;
57- alignment.right_padding = right;
58- alignment.bottom_padding = bottom;
59- alignment.left_padding = left;
60-
61- alignment.add (widget);
62- return alignment;
63+ widget.set_margin_top (top);
64+ widget.set_margin_right (right);
65+ widget.set_margin_bottom (bottom);
66+ widget.set_margin_left (left);
67+ return widget;
68
69 }
70
71
72=== modified file 'src/Widgets/CategoryView.vala'
73--- src/Widgets/CategoryView.vala 2012-04-23 17:41:00 +0000
74+++ src/Widgets/CategoryView.vala 2012-04-25 09:10:29 +0000
75@@ -54,7 +54,7 @@
76
77 category_switcher.selected = 0;
78
79- set_size_request (view.columns*130, view.view_height);
80+ set_size_request (view.columns*130 + 17, view.view_height);
81
82 }
83
84
85=== modified file 'src/Widgets/Sidebar.vala'
86--- src/Widgets/Sidebar.vala 2012-04-23 14:41:40 +0000
87+++ src/Widgets/Sidebar.vala 2012-04-25 09:10:29 +0000
88@@ -69,12 +69,13 @@
89 set_show_expanders (false);
90 set_level_indentation (8);
91
92- set_size_request (130, -1);
93+ set_size_request (145, -1);
94 get_style_context ().add_class ("sidebar");
95
96 var cell = new CellRendererText ();
97 cell.wrap_mode = Pango.WrapMode.WORD;
98 cell.wrap_width = 110;
99+ cell.xpad = 17;
100
101 insert_column_with_attributes (-1, "Filters", cell, "markup", Columns.TEXT);
102

Subscribers

People subscribed via source and target branches