Launchpad itself

Build farm and build machines have their own unusable tabs

Bug #84839 reported by Matthew Paul Thomas
6
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
William Grant

Bug Description

The location bar on <https://launchpad.net/+builds> is misleading, because the "Build Farm" hierarchy element suggests that the build farm itself could sometimes have its own Code, Bugs, Blueprints, Translations, or Answers, when it can't have any of those things.

The same problem occurs on the page for an individual build machine, e.g. <https://launchpad.net/+builds/osmium>, with an extra hierarchy element for the machine.

This can be fixed by removing the "Build Farm" and builder breadcrumbs so that they no longer appear in the location bar hierarchy. Instead, the location bar should look and work exactly the way it does on <https://launchpad.net/+announcements> or <https://launchpad.net/+mailinglists> for example, with LaunchpadRoot as its context.

It should still be obvious on a build machine page that you are in the build farm area, but the location bar should not be used to do this. A simple alternative would be to use a link, above the main heading on the build machine page, back to the build farm page. This is the same method used on secondary pages for a bug report (e.g. <https://bugs.launchpad.net/soyuz/+bug/84839/+edit>) to link back to the bug report, and on secondary pages for a blueprint (e.g. <https://blueprints.launchpad.net/soyuz/+spec/soyuz-multiple-ppas/+milestone>) to link back to the blueprint.

See original description

Related branches

lp:~wgrant/launchpad/kill-excessive-facets
Celso Providelo (community): Approve
Diff: 499 lines (+10/-180)
16 files modified
lib/lp/blueprints/browser/configure.zcml (+0/-1)
lib/lp/blueprints/browser/sprint.py (+0/-8)
lib/lp/bugs/browser/bug.py (+4/-2)
lib/lp/buildmaster/browser/builder.py (+0/-17)
lib/lp/buildmaster/browser/configure.zcml (+2/-6)
lib/lp/registry/browser/configure.zcml (+0/-2)
lib/lp/registry/browser/distribution.py (+0/-8)
lib/lp/registry/browser/product.py (+0/-9)
lib/lp/services/statistics/browser/launchpadstatistic.py (+1/-16)
lib/lp/soyuz/browser/build.py (+0/-9)
lib/lp/soyuz/browser/configure.zcml (+0/-4)
lib/lp/soyuz/browser/distroseriesbinarypackage.py (+0/-10)
lib/lp/translations/browser/configure.zcml (+3/-9)
lib/lp/translations/browser/pofile.py (+0/-9)
lib/lp/translations/browser/potemplate.py (+0/-61)
lib/lp/translations/browser/translationmessage.py (+0/-9)
Guilherme Salgado (salgado)
Changed in soyuz:
status: Unconfirmed → Confirmed
Matthew Paul Thomas (mpt)
description: updated
Matthew Paul Thomas (mpt)
Changed in soyuz:
assignee: nobody → mpt
milestone: none → 1.2.4
Julian Edwards (julian-edwards)
Changed in soyuz:
milestone: 1.2.4 → none
Matthew Paul Thomas (mpt)
Changed in soyuz:
milestone: none → 1.2.4
Matthew Paul Thomas (mpt)
Changed in soyuz:
milestone: 1.2.4 → 1.2.5
Matthew Paul Thomas (mpt)
Changed in soyuz:
importance: Undecided → Low
milestone: 1.2.5 → 1.2.6
Matthew Paul Thomas (mpt)
Changed in soyuz:
milestone: 1.2.6 → 1.99
Celso Providelo (cprov)
Changed in soyuz:
milestone: 1.99 → none
Matthew Paul Thomas (mpt)
description: updated
summary: - Build farm should not be a context (should not have tabs)
+ Build farm and build machines have their own unusable tabs
Changed in soyuz:
assignee: mpt → cprov
Celso Providelo (cprov)
Changed in soyuz:
milestone: none → pending
Revision history for this message
Guilherme Salgado (salgado) wrote :

The 3.0 version of the page in question here (https://edge.launchpad.net/builders) doesn't suggest any relationship between the application tabs and the build farm, but it still doesn't behave like /+announcements, as in the latter the links on the application tabs are enabled. Which of them is the correct behavior?

Revision history for this message
Julian Edwards (julian-edwards) wrote :

I think +announcements is wrong. Clicking on an application tab takes you to a completely different context - the root site on that facet.

However, it does make it obvious on /builders that there's no navigation to get away from that page. I sort of expected to be able to click on the LP logo to go back to the front page, but I'm not sure if we could do something better.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Curtis, what are your thoughts?

Revision history for this message
Curtis Hovey (sinzui) wrote :

/builders is a top-level collection and should look and behave like /people (with tabs). See however that mpt report both this bug and the bug that says that /people should have tabs. hmm. Well we have a small problem here. We have the locationless page layout that will remove the tabs, but search is also missing. Maybe we want to change this rule. With search in the footer, I do not think it needs to hide the search. This macro is used by global search and the error pages.

Curtis Hovey (sinzui)
Changed in soyuz:
assignee: Celso Providelo (cprov) → nobody
William Grant (wgrant)
Changed in launchpad:
assignee: nobody → William Grant (wgrant)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r16942 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/16942>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.