Merge lp:~wgrant/launchpad/kill-excessive-facets into lp:launchpad
Status: | Merged |
---|---|
Approved by: | William Grant |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16942 |
Proposed branch: | lp:~wgrant/launchpad/kill-excessive-facets |
Merge into: | lp:launchpad |
Diff against target: |
499 lines (+10/-180) 16 files modified
lib/lp/blueprints/browser/configure.zcml (+0/-1) lib/lp/blueprints/browser/sprint.py (+0/-8) lib/lp/bugs/browser/bug.py (+4/-2) lib/lp/buildmaster/browser/builder.py (+0/-17) lib/lp/buildmaster/browser/configure.zcml (+2/-6) lib/lp/registry/browser/configure.zcml (+0/-2) lib/lp/registry/browser/distribution.py (+0/-8) lib/lp/registry/browser/product.py (+0/-9) lib/lp/services/statistics/browser/launchpadstatistic.py (+1/-16) lib/lp/soyuz/browser/build.py (+0/-9) lib/lp/soyuz/browser/configure.zcml (+0/-4) lib/lp/soyuz/browser/distroseriesbinarypackage.py (+0/-10) lib/lp/translations/browser/configure.zcml (+3/-9) lib/lp/translations/browser/pofile.py (+0/-9) lib/lp/translations/browser/potemplate.py (+0/-61) lib/lp/translations/browser/translationmessage.py (+0/-9) |
To merge this branch: | bzr merge lp:~wgrant/launchpad/kill-excessive-facets |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Celso Providelo (community) | Approve | ||
Review via email: mp+208265@code.launchpad.net |
Commit message
Drop pointless facet menu overrides -- they should mostly only exist on structural objects nowadays, so subordinate objects fall back to the object named in the watermark title.
Description of the change
Drop pointless facet menu overrides -- they should mostly only exist on structural objects nowadays, so subordinate objects fall back to the object named in the watermark title. This fixes various bugs about erroneously disabled tabs (eg. for Builder, BuilderSet, ProductSet), and removes a lot of useless code (eg. POTemplateFacets and the other translations bits were deleted with no functional change whatsoever).
The only modification to existing working functionality is that ProductSet's Code facet link no longer links to the project cloud, but rather to the global Code homepage. There was a bug filed about that inconsistency, so this seems like a net improvement.
The remaining IFacetMenus after this branch are StandardLaunchp