"Battery" appears untranslated in indicator-power
Bug #846895 reported by
Gabor Kelemen
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Translations |
Fix Released
|
Medium
|
Unassigned | ||
| indicator-power |
Fix Released
|
Undecided
|
Unassigned | ||
| indicator-power (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
The string "Battery" appears untranslated in indicator-power, despite being translated in the .mo file.
This is because this string directly uses the gettext() call, while the indicator-power.c file includes gi18n-lib.h. The latter means that the _() macro uses dgettext(). Strings which use the _() macro (like Show Time in Menu Bar) appear translated, so the gettext() calls need to be replaced by these.
There are also a few ngettext calls in the same file, these need to be converted to g_dngettext() if we want those translations to work.
Related branches
lp:~kelemeng/indicator-power/bug846895
- Javier Jardón: Approve
-
Diff: 91 lines (+15/-15)1 file modifiedsrc/indicator-power.c (+15/-15)
Revision history for this message
| Gabor Kelemen (kelemeng) wrote | #1 |
| Changed in indicator-power (Ubuntu): | |
| status: | New → Confirmed |
Revision history for this message
| Javier Jardón (jjardon) wrote | #2 |
| Changed in indicator-power: | |
| status: | New → Fix Committed |
| Changed in indicator-power: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in indicator-power (Ubuntu): | |
| status: | Confirmed → Fix Released |
| Changed in ubuntu-translations: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
Thanks a lot for the patch, aproved and merged.