Launcher - dragging a item on top of a launcher tile that is a valid drop receptacle in the Launcher should cause that launcher tile to glow
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ayatana Design |
Fix Committed
|
Medium
|
John Lea | ||
| Unity |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
| 7.2 |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
| unity (Ubuntu) |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
Bug Description
[Impact]
The drag and drop launcher icons are not correctly marked as targets
[Test case]
1) Drag a file a launcher icon
2) The launcher icon under the mouse pointer should have a glowing tile
3) When the mouse pointer leaves the launcher icon area or the mouse is released
the icon should not glow anymore (unless is not an urgent icon).
[Regression Potential]
An icon that is not urgent might be left with a glowing tile when leaving the DnD or an urgent icon might not being glowing anymore after leaving the Dnd.
-----
Launcher - dragging a item on top of a launcher tile that is a valid drop receptacle in the Launcher should cause that launcher tile to glow. This glow only persists as long as the dragged item is directly over the launcher tile, as soon as the dragged item is moved off the launcher tile, the glow should stop.
Use cases:
- User drags a .png file over the Firefox icon in the Launcher. As soon as the .png file is over the Firefox icon, the firefox icon starts to glow. The user then moves the .png file off the Firefox launcher icon, and the Firefox launcher immediately stops glowing.
- User drags a launcher tile from it's position in the launcher to the trash can. As soon as the Launcher tile is above the trash can, the trash can starts to glow. The user then moves the launcher tile off the trash can and the trash can stops glowing.
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Christopher Townsend: Approve
- Brandon Schaefer (community): Approve
-
Diff: 313 lines (+76/-43)10 files modifieddash/DashController.cpp (+3/-1)
hud/HudController.cpp (+1/-0)
launcher/AbstractLauncherIcon.h (+3/-2)
launcher/ApplicationLauncherIcon.cpp (+15/-14)
launcher/ApplicationLauncherIcon.h (+0/-1)
launcher/Launcher.cpp (+19/-2)
launcher/TrashLauncherIcon.cpp (+1/-0)
launcher/VolumeLauncherIcon.cpp (+1/-0)
plugins/unityshell/src/unityshell.cpp (+6/-15)
unity-shared/PluginAdapter.cpp (+27/-8)
- Marco Trevisan (Treviño): Approve
-
Diff: 3472 lines (+1152/-478)54 files modifiedUnityCore/GnomeSessionManager.cpp (+32/-0)
UnityCore/GnomeSessionManagerImpl.h (+4/-0)
UnityCore/SessionManager.h (+4/-0)
dash/DashController.cpp (+3/-1)
debian/changelog (+59/-0)
hud/HudController.cpp (+1/-0)
launcher/AbstractLauncherIcon.h (+3/-2)
launcher/ApplicationLauncherIcon.cpp (+20/-19)
launcher/ApplicationLauncherIcon.h (+0/-1)
launcher/Launcher.cpp (+26/-10)
launcher/LauncherIcon.cpp (+7/-3)
launcher/LauncherIcon.h (+2/-1)
launcher/SwitcherView.cpp (+54/-31)
launcher/SwitcherView.h (+3/-4)
launcher/TrashLauncherIcon.cpp (+1/-0)
launcher/VolumeLauncherIcon.cpp (+1/-0)
lockscreen/LockScreenAbstractShield.h (+0/-1)
lockscreen/LockScreenController.cpp (+2/-3)
lockscreen/LockScreenShield.cpp (+0/-6)
lockscreen/LockScreenShield.h (+0/-1)
lockscreen/UserPromptView.cpp (+8/-99)
lockscreen/UserPromptView.h (+1/-13)
panel/PanelIndicatorEntryView.cpp (+7/-0)
plugins/unityshell/src/GesturalWindowSwitcher.cpp (+3/-0)
plugins/unityshell/src/GesturalWindowSwitcher.h (+1/-0)
plugins/unityshell/src/unityshell.cpp (+57/-50)
plugins/unityshell/src/unityshell.h (+2/-0)
po/POTFILES.in (+1/-0)
po/unity.pot (+70/-3)
shortcuts/ShortcutController.cpp (+4/-6)
shortcuts/ShortcutView.cpp (+113/-48)
shortcuts/ShortcutView.h (+9/-3)
shutdown/SessionButton.cpp (+30/-5)
shutdown/SessionButton.h (+5/-0)
shutdown/SessionController.cpp (+2/-0)
shutdown/SessionView.cpp (+68/-27)
shutdown/SessionView.h (+5/-0)
tests/test-gestures/LockScreenControllerMock.h (+43/-0)
tests/test-gestures/sed_script_switcher (+2/-0)
tests/test-gestures/unityshell_mock.h (+8/-1)
tests/test_lockscreen_controller.cpp (+0/-1)
tests/test_switcher_view.cpp (+1/-2)
tests/test_unity_window_view.cpp (+9/-9)
unity-shared/EMConverter.cpp (+2/-2)
unity-shared/IMTextEntry.cpp (+7/-0)
unity-shared/IMTextEntry.h (+2/-0)
unity-shared/PluginAdapter.cpp (+43/-10)
unity-shared/RawPixel.cpp (+1/-1)
unity-shared/TextInput.cpp (+178/-4)
unity-shared/TextInput.h (+19/-4)
unity-shared/UnityWindowStyle.cpp (+135/-62)
unity-shared/UnityWindowStyle.h (+35/-20)
unity-shared/UnityWindowView.cpp (+53/-25)
unity-shared/UnityWindowView.h (+6/-0)
- Unity Team: Pending requested
-
Diff: 1674 lines (+1380/-30) (has conflicts)7 files modifiedCMakeLists.txt (+5/-0)
ChangeLog (+1162/-0)
debian/changelog (+77/-26)
debian/control (+1/-1)
po/unity.pot (+70/-3)
shutdown/SessionView.cpp (+55/-0)
shutdown/SessionView.h (+10/-0)
| tags: | added: onew udo |
| Changed in ayatana-design: | |
| assignee: | nobody → John Lea (johnlea) |
| importance: | Undecided → Medium |
| status: | New → Fix Committed |
| Changed in unity: | |
| assignee: | nobody → Jason Smith (jassmith) |
| importance: | Undecided → Medium |
| Changed in unity (Ubuntu): | |
| assignee: | nobody → Jason Smith (jassmith) |
| Changed in unity: | |
| status: | New → Triaged |
| Changed in unity (Ubuntu): | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| Changed in ayatana-design: | |
| status: | Fix Committed → Fix Released |
| tags: | added: udp |
| Changed in unity: | |
| milestone: | none → backlog |
| Changed in ayatana-design: | |
| status: | Fix Released → Fix Committed |
| Changed in unity: | |
| assignee: | Jason Smith (jassmith) → nobody |
| Changed in unity (Ubuntu): | |
| assignee: | Jason Smith (jassmith) → nobody |
| Changed in unity: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
| Changed in unity (Ubuntu): | |
| assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
| Changed in unity: | |
| milestone: | backlog → 7.2.0 |
| Changed in unity (Ubuntu): | |
| status: | Triaged → In Progress |
| Changed in unity: | |
| milestone: | 7.2.0 → 7.2.1 |
| tags: | added: dnd |
| Changed in unity: | |
| milestone: | 7.2.1 → 7.2.2 |
| Changed in unity: | |
| milestone: | 7.2.2 → 7.3.0 |
| status: | In Progress → Fix Committed |
| Changed in unity (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in unity: | |
| status: | Fix Committed → Fix Released |
| description: | updated |
| tags: | added: rls-w-incoming |
