Current timezone duplicates with saved locations

Screenshot of my saved locations.

I think this is not completely fixed, see my comments in https://code.launchpad.net/~jjardon/indicator-datetime/fix-833337/+merge/79332

Hello James, or anyone else affected,

Accepted indicator-datetime into oneiric-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

SRU verification for Oneiric:
I have reproduced the problem with indicator-datetime 0.3.0-0ubuntu3 in oneiric and have verified that the version of indicator-datetime 0.3.1-0ubuntu1 in -proposed fixes the issue.

Marking as verification-done

This bug was fixed in the package indicator-datetime - 0.3.1-0ubuntu1

---------------
indicator-datetime (0.3.1-0ubuntu1) oneiric-proposed; urgency=low

  * New upstream release.
    * Drop an unused icon (LP: #746176)
    * Fix showing a timezone that we're currently set to (LP: #833337)
    * Remove check for libunique as it's unused
  * debian/control: Drop libunique requirements, it was unused
 -- Ted Gould <email address hidden> Thu, 13 Oct 2011 13:40:21 -0500

I'm experiencing this with indicator-datetime-0.3.1-0ubuntu1, from oneric-proposed with the following specifics:
My current location is listed twice consecutively in the indicator menu;
My current location is not defined in the locations dialog;
Defining my current location in the locations dialog has no effect;
When setting another location as "home" in the indicator menu, the extraneous home-location disappears;
When selecting the original home location in the indicator menu, the extraneous home-location reappears;
Defining additional locations with the same timezone as my home location and switching to and from them produces inconsistent, confusing results;

Reinstalling indicator-datetime and restarting is has no effect;
Installing all pending upgrades and rebooting did not help;
Running dpkg-reconfigure on tzdata does not help;

I was unable to find neither the settings file for the indicator my home directory nor any related entries in gconf.

What steps should i take to help resolve this issue?

Simon -
at least here, yes, the upgrade created a duplicate of my "home" location when I had it set to display time in other locations.
Though at least here switching the "home" location to another , then switching back to my orig "home" location did remove the dupe which didn't back

However - the upgrade to indicator-datetime 0.3.1-0ubuntu1.1 (oneiric-proposed) has again created a dupe of the "home" & can't be gotten rid of when showing add. locations, at least ant way I've found
look here
bug 802384

I am still experiencing this issue with up-to-date Precise. Switching the location back and forth does not solve it: When switching back to my home location, the duplicate entry appears again.

Frederik, could you please trigger the behavior again s.t. the duplicate entry appears again, and while it's still showing, run this command from a terminal and paste its values into this ticket:

    gsettings list-recursively com.canonical.indicator.datetime

Thanks!

Sure, here is the output:

com.canonical.indicator.datetime custom-time-format '%l:%M %p'
com.canonical.indicator.datetime locations ['UTC']
com.canonical.indicator.datetime show-calendar true
com.canonical.indicator.datetime show-clock true
com.canonical.indicator.datetime show-date true
com.canonical.indicator.datetime show-day true
com.canonical.indicator.datetime show-events true
com.canonical.indicator.datetime show-locations true
com.canonical.indicator.datetime show-seconds false
com.canonical.indicator.datetime show-week-numbers false
com.canonical.indicator.datetime time-format 'locale-default'
com.canonical.indicator.datetime timezone-name 'Europe/Berlin Berlin'

Indicator currently shows:

  Berlin
• Berlin
  UTC

Javier's second branch makes a lot of sense to me -- showing /exactly/ what's in the "Time in Other Locations" list, nothing more, nothing less. Easy for programmers to write, and (one hopes) easy for everyone to understand.

IMO the first step for this ticket is to get Design to revise the spec <https://wiki.ubuntu.com/TimeAndDate#Time_in_other_locations> to talk about what items should go in Other Locations (the geo_location and current_location entries that we use now aren't in the spec) and how to sort them (should they follow the ordering specified by the user in Time & Date Settings? or sorted by timezone as per bug #833325)?

I agree with Charles that the simplest fix is not to include geo_location and current_location in the menu at all.

Later we could add an option for whether you want to include a geo-detected location, but that probably should be its own settings checkbox with its own string.

On an up to date precise install.

I'm not sure that my earlier "simplest fix" position will work: if someone is physically located outside of their custom timezone list, there's no longer an easy way to click-to-set the current timezone from the geo timezone. This regression would certainly be reported & force us to revisit this issue anyway.

After hacking & rehacking this code for the last day, I think I've found a code approach that follows some of the ideas in Javier's second patch wrt removing the special case code, but preserves the older beahvior wrt geo/current location. It improves detection & removal of duplicate entries, and also picks up a fix for Bug #833325 :)

This bug was fixed in the package indicator-datetime - 0.3.91-0ubuntu1

---------------
indicator-datetime (0.3.91-0ubuntu1) precise; urgency=low

  * New upstream release.
    * Make GSettings readonly to fix DConf service starting on boot
    * Explicitly give types to GVariant Builder
    * Confirm scanf usage for Coverity (LP: #943747)
    * Remove unused code (LP: #943746)
    * Fix timezone ordering in the menu (LP: #833325, LP: #833337)
 -- Ted Gould <email address hidden> Thu, 08 Mar 2012 16:58:28 -0600

This is not fixed for me: Choose a non major city. E.g. "Bamberg, Germany. It will show both Berlin and Bamberg in the indicator for some reason.