FFe: dh_python2 migration for awn, awn-extras and lda

Bug #830220 reported by siucdude
196
This bug affects 13 people
Affects Status Importance Assigned to Milestone
avant-window-navigator (Ubuntu)
Fix Released
Medium
Julien Lavergne
awn-extras (Ubuntu)
Fix Released
Medium
Julien Lavergne
libdesktop-agnostic (Ubuntu)
Fix Released
Medium
Julien Lavergne

Bug Description

FFe explanation :
Currently, python in awn-extras is broken. The best solution to solve it properly is to migrate awn-extras to dh_python2. To be safe, and coherent, the python bindings of the 2 main depends (lda and awn) should be also migrate to dh_python2.

The diff of the 3 packages are attached to the bug report.

Build logs :
avant-window-navigator : https://launchpadlibrarian.net/77933261/buildlog_ubuntu-oneiric-i386.avant-window-navigator_0.4.1~bzr822-0ubuntu4~ppa1_BUILDING.txt.gz
libdesktop-agnostic: https://launchpadlibrarian.net/77933420/buildlog_ubuntu-oneiric-i386.libdesktop-agnostic_0.3.92-0ubuntu3~ppa1_BUILDING.txt.gz
awn-extras: https://launchpadlibrarian.net/78018679/buildlog_ubuntu-oneiric-i386.awn-extras_0.4.1~bzr1507-0ubuntu3~ppa2_BUILDING.txt.gz

Initial report :

just got this after updates

ProblemType: Crash
DistroRelease: Ubuntu 11.10
Package: awn-applet-slickswitcher 0.4.1~bzr1507-0ubuntu2
ProcVersionSignature: Ubuntu 3.0.0-8.11-generic 3.0.1
Uname: Linux 3.0.0-8-generic x86_64
Architecture: amd64
Date: Sat Aug 20 15:25:59 2011
ExecutablePath: /usr/share/avant-window-navigator/applets/slickswitcher/slickswitcher.py
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Beta amd64 (20110330)
InterpreterPath: /usr/bin/python2.7
PackageArchitecture: all
ProcCmdline: python /usr/share/avant-window-navigator/applets/slickswitcher/slickswitcher.py --uid=1302185006 --window=29360187 --panel-id=1
ProcCwd: /home/tomasz
ProcEnviron:
 PATH=(custom, no user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
PythonArgs: ['/usr/share/avant-window-navigator/applets/slickswitcher/slickswitcher.py', '--uid=1302185006', '--window=29360187', '--panel-id=1']
SourcePackage: awn-extras
Title: slickswitcher.py crashed with ImportError in __main__: No module named extras
Traceback:
 Traceback (most recent call last):
   File "/usr/share/avant-window-navigator/applets/slickswitcher/slickswitcher.py", line 34, in <module>
     from awn.extras import _
 ImportError: No module named extras
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare

Revision history for this message
siucdude (siucdude) wrote :
siucdude (siucdude)
visibility: private → public
Revision history for this message
Julian Taylor (jtaylor) wrote :

this is caused by python-awn installing into /usr/share/pyshared and python-awn-extras installing into /usr/lib/python2.7/dist-packages

both packages should be change do to use dh_python2

Julian Taylor (jtaylor)
Changed in awn-extras (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Julien Lavergne (gilir) wrote :

I already done it in Debian, I'll backport the changes to Ubuntu.

Changed in awn-extras (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Julien Lavergne (gilir)
Revision history for this message
Julien Lavergne (gilir) wrote :

To be safe, the 3 packages (awn, awn-extras and lda) should be migrated together

Changed in libdesktop-agnostic (Ubuntu):
status: New → In Progress
Changed in avant-window-navigator (Ubuntu):
status: New → In Progress
importance: Undecided → Medium
Changed in libdesktop-agnostic (Ubuntu):
importance: Undecided → Medium
Changed in avant-window-navigator (Ubuntu):
assignee: nobody → Julien Lavergne (gilir)
Changed in libdesktop-agnostic (Ubuntu):
assignee: nobody → Julien Lavergne (gilir)
summary: - slickswitcher.py crashed with ImportError in __main__: No module named
- extras
+ FFe: dh_python2 migration for awn, awn-extras and lda
tags: removed: need-duplicate-check
Revision history for this message
Julien Lavergne (gilir) wrote :
description: updated
Revision history for this message
Julien Lavergne (gilir) wrote :
Revision history for this message
Julien Lavergne (gilir) wrote :
Julien Lavergne (gilir)
description: updated
Changed in libdesktop-agnostic (Ubuntu):
status: In Progress → Confirmed
Changed in awn-extras (Ubuntu):
status: In Progress → Confirmed
Changed in avant-window-navigator (Ubuntu):
status: In Progress → Confirmed
assignee: Julien Lavergne (gilir) → nobody
Changed in awn-extras (Ubuntu):
assignee: Julien Lavergne (gilir) → nobody
Changed in libdesktop-agnostic (Ubuntu):
assignee: Julien Lavergne (gilir) → nobody
Revision history for this message
Stefano Rivera (stefanor) wrote :

Julien: I assume your marked these confirmed accidentally (FFes use confirmed for FFe Granted).

Reviewing it now.

Revision history for this message
Stefano Rivera (stefanor) wrote :

All look fine, FFe granted.

While I'm here reviewing them:
avant-window-navigator:
* You probably only need python-dev rather than -all-dev if you are only building for one version
* dh_python2 had a point: public extension linked with libpython2.7: awn.so
* I'd drop the Provides: ${python:Provides}. Not needed here.

awn-extras:
* Again, I'd drop the python:Provides

libdesktop-agnostic:
* You probably only need python-dev rather than -all-dev if you are only building for one version
* Drop XB-Python-Version
* drop python:Provides
* The new dh_sphinxdoc makes handling the JS for sphinx documentation easier

Revision history for this message
Julien Lavergne (gilir) wrote :

Thank Stefano for the review, I'll add your suggestions and upload them after beta freeze

Changed in libdesktop-agnostic (Ubuntu):
status: Confirmed → In Progress
Changed in awn-extras (Ubuntu):
status: Confirmed → In Progress
Changed in avant-window-navigator (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Julien Lavergne (gilir)
Changed in awn-extras (Ubuntu):
assignee: nobody → Julien Lavergne (gilir)
Changed in libdesktop-agnostic (Ubuntu):
assignee: nobody → Julien Lavergne (gilir)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libdesktop-agnostic - 0.3.92-0ubuntu3

---------------
libdesktop-agnostic (0.3.92-0ubuntu3) oneiric; urgency=low

  * debian/control:
   - Drop build-depends on python-support.
   - Bump build-depends on python and python-dev to >= 2.6.6-3~ for dh_python2
     support.
   - Drop build-depends on python-all-dev.
   - Drop XB-Python-Version.
   - Drop Provides: ${python:Provides}.
   - Update build-depends on python-sphinx for dh_sphinxdoc support.
   - Use ${sphinxdoc:Depends}.
  * debian/libdesktop-agnostic-doc.links:
   - Remove workaround for jquery, handle by python-sphinx.
  * debian/rules:
   - Use --with python2 (LP: #830220).
   - Use --with sphinxdoc.
   - Passing --no-guessing-versions to dh_python2
  * debian/pycompat:
   - Remove.
 -- Julien Lavergne <email address hidden> Thu, 01 Sep 2011 23:21:44 +0200

Changed in libdesktop-agnostic (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package avant-window-navigator - 0.4.1~bzr822-0ubuntu4

---------------
avant-window-navigator (0.4.1~bzr822-0ubuntu4) oneiric; urgency=low

  * debian/control:
   - Bump build-depends on python-dev to >= 2.6.6-3~ for dh_python2 support
   - Remove python-support build-depends.
   - Use X-Python-Version instead of debian/pyversions.
   - Drop Provides: ${python:Provides}.
  * debian/rules:
   - Use --with python2 (LP: #830220).
   - Passing --no-guessing-versions to dh_python2
 -- Julien Lavergne <email address hidden> Thu, 01 Sep 2011 23:25:12 +0200

Changed in avant-window-navigator (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package awn-extras - 0.4.1~bzr1507-0ubuntu3

---------------
awn-extras (0.4.1~bzr1507-0ubuntu3) oneiric; urgency=low

  * debian/control:
   - Remove python-central build-depends.
   - Add build-depends on python (>= 2.6.6-3~) for dh_python2 support.
   - Drop Provides: ${python:Provides}.
  * debian/rules:
   - Use --with python2 (LP: #830220).
 -- Julien Lavergne <email address hidden> Thu, 01 Sep 2011 23:27:05 +0200

Changed in awn-extras (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.