glance/tests/functional/test_api.py tests expected values against expected values

Take a close look around line 197:

        image = json.loads(content)

        for expected_key, expected_value in expected_image.items():
            self.assertEqual(expected_value, expected_image[expected_key],
                            "For key '%s' expected header value '%s'. Got '%s'"
                            % (expected_key,
                               expected_value,
                               image['images'][0][expected_key]))

The assertion is verifying that expected_value == expected_value, which will of course always be true. The second argument to assertEqual() should probably be "image['images'][0][expected_key]" instead. This same error occurs in identical code around line 238. The logic of all the tests in the functional suite should probably be carefully scrutinized to ensure that it does not occur elsewhere...