Ubuntu
xchat package

Missing ... for Preferences menu item

Bug #816506 reported by Fred on 2011-07-26

12

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	xchat	Unknown	Unknown	sf #3436036
	xchat (Ubuntu)	Invalid	Wishlist	Chad Dunlap

Bug Description

Menu has Settings -> Preferences
But since it opens a dialog, it should be suffixed with three dots
Should be Settings -> Preferences...

Tags:

Related branches

lp:~cldunlap1/ubuntu/oneiric/xchat/fix-for-816506

Rejected for merging into lp:ubuntu/oneiric/xchat

Barry Warsaw (community): Disapprove on 2011-10-27

Ubuntu branches: Pending requested 2011-10-22

Fred (eldmannen+launchpad) on 2011-07-26

tags:

added: hig usability

Bryce Harrington (bryce) on 2011-09-13

tags:	added: bitesize
Changed in xchat (Ubuntu):
status:	New → Confirmed
importance:	Undecided → Wishlist

Revision history for this message

Chad Dunlap (cldunlap1) wrote on 2011-10-22:

#1

I have committed this fix and proposed the merge.

If you need anything else for this, please don't hesitate to let me know.

Changed in xchat (Ubuntu):
assignee:	nobody → Chad Dunlap (cldunlap1)
status:	Confirmed → Fix Committed

Revision history for this message

Fred (eldmannen+launchpad) wrote on 2011-10-24:

#2

in XChat -> New -> Server Tab...
it has the ellipsis suffix but the action requires no user action or confirmation, so maybe it shouldn't have the ellipsis?
Same for Channel Tab...
Or what do you think?

Ctrl+J would be a great shortcut for Server -> Join a Channel...

Revision history for this message

Fred (eldmannen+launchpad) wrote on 2011-10-24:

#3

Help -> About; the text in the dialog should have some margin on the left and right sides so the text doesn't touch the borders.
Should be like 8px, I think.

Revision history for this message

Fred (eldmannen+launchpad) wrote on 2011-10-24:

#4

Help -> About should have a License button.

Revision history for this message

Chad Dunlap (cldunlap1) wrote on 2011-10-25:

#5

Fred,

Revision history for this message

Chad Dunlap (cldunlap1) wrote on 2011-10-25:

#6

Fred,

I don't disagree with any of your comments. I think the changes to the '...' for 'Server Tab' and 'Channel Tab' should probably be their own bug, outside of this one. I can fix those easy enough.

The 'Help -> About' is a bit above my meager programming skills but I believe this is probably another bitesize bug, outside of this report.

Thoughts?

Revision history for this message

Chad Dunlap (cldunlap1) wrote on 2011-10-25:

#7

I have opened a bug (LP: #881232) on the two ellipsis that need to be removed from Server Tab and Channel Tab. I have assigned this to myself and I will get it fixed and propose the merge.

Fred - If you think the other issues you mentioned need their own bugs, can you open the bug reports?

Thank You.

Revision history for this message

Fred (eldmannen+launchpad) wrote on 2011-10-25:

#8

Thanks Chad! :)

I filed a bug #881623 for the License button.
And #881625 for the shortcut for joining a channel.

Revision history for this message

Barry Warsaw (barry) wrote on 2011-10-27:

#9

Please see my merge proposal comment for why I think this bug should not be fixed, or at least not fixed only in Ubuntu.

https://code.launchpad.net/~cldunlap1/ubuntu/oneiric/xchat/fix-for-816506/+merge/80118

Changed in xchat (Ubuntu):
status:	Fix Committed → Invalid

Revision history for this message

Fred (eldmannen+launchpad) wrote on 2011-10-28:

#10

Sorry, Barry is more intimately familiar with the HIG than I am.

Revision history for this message

Daniel Holbach (dholbach) wrote on 2011-11-10:

#11

Patch forwarded upstream.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

sf #3436036 Edit

Bug watches keep track of this bug in other bug trackers.