OpenLP

Theme wizard does not show correct line count (max lines/slide)

Bug #788231 reported by Andreas Preikschat
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Released
Low
Tim Bentley
OpenLP 1.9.6 "Enflaming Elijah"

Bug Description

Hello,

Running trunk r1570.

1) Create a new plain theme with a main font size of 30px.
2) Create a custom with a number on each line (so you don't have to count lines yourself)
3) Make the theme you just created the default theme for this custom.
4) Preview the custom.

Now compare the lines which fit on one slide with the line count the wizard told you. You probably will notice that they are not equal, thus the line count the wizard shows you is wrong.

However, the outcome depends on your screen resolution so you might have to try a few different font sizes (I use 1024x768)- I guess the {su} and {sb} tags are confusing the renderer (but maybe there are other reasons too).

Cheers

Related branches

lp:~trb143/openlp/bug_788231
Andreas Preikschat (community): Approve
Raoul Snyman: Approve
Diff: 43 lines (+4/-4)
2 files modified
openlp/core/lib/renderer.py (+3/-3)
openlp/core/ui/themeform.py (+1/-1)
Revision history for this message
Jonathan Corwin (j-corwin) wrote :

{su} and {sb} may well affect line height.
Whatever text is being used to calculate the number of rows should be just plain text, if it isn't currently.

Line count is just a guideline however, and any Song/Custom/Bible which has subscripts/superscripts will cause a different result.

Tim Bentley (trb143)
Changed in openlp:
status: New → Confirmed
Revision history for this message
Tim Bentley (trb143) wrote :

Interesting
The line starting with 12 is from a song with each number at the start of a line.
12 = lines 686 = page size 724=real size.

12 686 724 <html><head><style>*{margin: 0; padding: 0; border: 0;} #main {position:absolute; top:0px; white-space:pre-wrap; word-wrap: break-word; text-align: left; vertical-align: top; font-family: Liberation Sans; font-size: 45pt; color: #FFFFFF; line-height: 100%; margin:0;padding:0; padding-left:0px; width: 999px; height: 686px; }</style></head><body><div id="main">1<br>2<br>3<br>4<br>5<br>6<br>7<br>8<br>9<br>10<br>11<br>12<br></div></body></html>

The line starting with 8 is from the theme editing.
8 = lines 686 = page size 750=real size.

8 686 750 <html><head><style>*{margin: 0; padding: 0; border: 0;} #main {position:absolute; top:0px; white-space:pre-wrap; word-wrap: break-word; text-align: left; vertical-align: top; font-family: Liberation Sans; font-size: 45pt; color: #FFFFFF; line-height: 100%; margin:0;padding:0; padding-left:0px; width: 999px; height: 686px; }</style></head><body><div id="main"><sup>floody</sup>,<sub>floody</sub><br><sup>floody</sup>, <sub>floody</sub><br><sup>floody</sup>, <sub>floody</sub><br><sup>floody</sup>, <sub>floody</sub><br><sup>floody</sup>, <sub>floody</sub><br><sup>floody</sup>, <sub>floody</sub><br><sup>floody</sup>, <sub>floody</sub><br><sup>floody</sup>, <sub>floody</sub><br></div></body></html>

If you compare the HTML then they are the same except for the text!

Jonathan Corwin (j-corwin)
Changed in openlp:
importance: Undecided → Low
Tim Bentley (trb143)
Changed in openlp:
status: Confirmed → Fix Committed
Tim Bentley (trb143)
Changed in openlp:
status: Fix Committed → Fix Released
milestone: none → 1.9.6
assignee: nobody → Tim Bentley (trb143)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.