Update natty to 0.9.3

Michael.. the patch to add Gnome 3 support seems a lot more like a feature than a bug fix. It seems to interfere directly with the code that also sets the background on Gnome 2, which is still the "classic" ubuntu desktop. This much change for gnome 3, which we don't really officially support in Natty, worries me for an SRU.

The other patches are a lot simpler and seem totally acceptable.

Seems like it would be possible to cherry pick just those two fixes into 0.9.2. Do they have Launchpad bug numbers?

if we do cherry pick we should get the updated translation template as well to fix the non translatable string issues which has been fixed, it would maybe be easier to just revert the GNOME3 patch there?

We at Yorba have tested the GNOME 3 background fix to make sure that works on Natty as well as on GNOME 3 systems such as Fedora 15. But, still, it's up to you whether to take Shotwell 0.9.3 in its entirety.

By the way, we are considering another bug fix release (0.9.4) in the next week or two, so if you want to take 0.9.4 but exclude the GNOME 3 background fix you'll also need to cherry pick there as well.

Since it sounds like there's been a lot of testing done thus far, including with Gnome 2.32 on Natty, I think this should be safe, and I'll accept it. This needs to get very detailed testing in -proposed, especially with setting the background in both Unity and classic desktop.

Thanks Adam, by reading http://git.yorba.org/cgit.cgi/shotwell/commit/?h=shotwell-0.9&id=043616d8a5e7e5be47651ddad0e4479353a63aef it seems you do a "gsettings or gconf" though based on the fact that the gsettings key has a value but some users install gsettings-desktop-schemas on natty with GNOME 2.32 and will have the gsettings value set but the change still not to go in gconf as well which it seems the code doesn't do?

to be clear the safe way would be to write in both gsettings and gconf in any case since some applications might be ported to gsettings and other still using gconf during the transition

In light of Sebastian's comments, I'm once again holding off on accepting this package pending further discussion.

Hi Sebastien & Clint,

In a later commit (http://git.yorba.org/cgit.cgi/shotwell/commit/?h=shotwell-0.9&id=ff847b76cea89c769a144bb7116ac41b336a7974), we implemented exactly what Sebastien had suggested, which is to say we now write to both GConf and GSettings. Note that this latter change is present in Shotwell 0.9.3 as shipped and "Set as Desktop Background" has been tested and verified to work correctly on Maverick, Natty, and Fedora Core 15 (GNOME 3) systems. I think you guys were just looking at an earlier commit. ;-)

Lucas

Accepted shotwell into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Agreed Lucas, in reviewing the patch again w/ Seb's comments in mind, its taken care of. :) Accepted into natty-proposed.

Hello,
Since this is a multi-fix patch we would please ask to update this ticket and provide steps to properly reproduce and verify the four bulleted bugs. We are most interested in what the is current actual behavior in detail before we validate what is expected.

* Resolves issue where setting the desktop background didn't work in Gnome3 - Errors, log messages?

* Mimics are now deleted when a RAW photo is removed - What is the location to verify all mimics are deleted?

* Event dates are now only shown once in the Event view - Where else are event dates displayed?

* Fixes a number of translation issues - Examples?

Thank you!

Hi Patrick,

I'm not intimately familiar with any of the 0.9.3 bug fixes, but I can give
you a link to the bugs fixed in 0.9.3 in our Trac:
http://trac.yorba.org/query?component=shotwell&component=gexiv2&milestone=0.9.3

Perhaps someone else on the Shotwell team could assist?

  - Eric

On Thu, May 5, 2011 at 2:28 PM, Patrick Wright <email address hidden>wrote:

> Hello,
> Since this is a multi-fix patch we would please ask to update this ticket
> and provide steps to properly reproduce and verify the four bulleted bugs

Eric,
Thank you very much. After reviewing the related bugs I am able to figure out what needs to be verified. Setting back to v-needed.

Been testing and using shotwell from proposed for a while and didn't noticed any regressions with it, marking this as verification-done , thanks all.

This bug was fixed in the package shotwell - 0.9.3-0ubuntu0.1

---------------
shotwell (0.9.3-0ubuntu0.1) natty-proposed; urgency=low

  * New upstream bugfix release (LP: #771841)
    - Resolves issue where setting the desktop background didn't work in
      GNOME 3
    - Mimics are now deleted when a RAW photo is removed
    - Event dates are now only shown once in the Event view
    - Fixes a number of translation issues
  * debian/patches/00svn_untranslatable_string.patch:
    - Dropped, applied upstream
 -- Michael Terry <email address hidden> Wed, 27 Apr 2011 10:32:08 -0400