deprecated DBUS interfaces are not marked as deprecated

Bug #770269 reported by Harald Sitter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Single Sign On Client
Fix Released
Medium
Natalia Bidart
ubuntu-sso-client (Ubuntu)
Fix Released
Medium
Natalia Bidart

Bug Description

Binary package hint: ubuntu-sso-client

<apachelogger> nessita: the dbus stuff in /credentials is deprecated?
<nessita> apachelogger: yes sir [...]

Test:
me@avatar:~/tmp$ qdbus com.ubuntu.sso /credentials org.freedesktop.DBus.Introspectable.Introspect | grep -i deprecated
me@avatar:~/tmp$

Expected:
org.freedesktop.DBus.Deprecated annotations

Resources:
http://dbus.freedesktop.org/doc/dbus-specification.html#introspection-format

Related branches

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

As per alecu's digging into python-dbus, we can't add annotations to our dbus APIs.

The documentation at https://wiki.ubuntu.com/SingleSignOn/UbuntuSsoClient explicitly states that the /credentials service is deprecated.
Also, the source code for the DBus constants shows this deprecations (from ubuntu_sso/__init__.py):

     20 DBUS_PATH = "/sso" # deprecated!
     21 DBUS_CRED_PATH = "/credentials" # deprecated!

I will propose a branch to add more deprecation comments/docstring to the source code, but for now there is not much else we can do at DBus level.

Changed in ubuntu-sso-client (Ubuntu):
status: New → In Progress
assignee: nobody → Naty Bidart (nataliabidart)
importance: Undecided → Medium
Changed in ubuntu-sso-client:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Naty Bidart (nataliabidart)
Changed in ubuntu-sso-client:
status: In Progress → Fix Committed
dobey (dobey)
Changed in ubuntu-sso-client:
milestone: none → 1.3.1
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-sso-client - 1.3.1-0ubuntu1

---------------
ubuntu-sso-client (1.3.1-0ubuntu1) oneiric; urgency=low

  * New upstream release.
    - Invalid signature for CreateItem call (LP: #745540)
    - Never sees NetworkManager connection (LP: #791548)
    - Support new property names in secrets API (LP: #800294)
    - Deprecated DBus interfaces not marked as such (LP: #770269)
  * Update the watch file to point at the correct place.
 -- Rodney Dawes <email address hidden> Fri, 24 Jun 2011 15:14:18 -0400

Changed in ubuntu-sso-client (Ubuntu):
status: In Progress → Fix Released
dobey (dobey)
Changed in ubuntu-sso-client:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.