Ubuntu applied patch for bug for #629996 causes Maverick->Natty regression

Bug #769554 reported by Benoit Grégoire
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libofx (Ubuntu)
Fix Released
Undecided
Unassigned
Natty
Fix Released
Undecided
Unassigned

Bug Description

=== SRU Justification ===

Impact: Latin-1 (non-ascii, non-multibyte) characters cause truncations of strings.

Fixed upstream in 0.9.1.

To reproduce:
 0. Download attached ofx-latin1.ofx
 1. $ sudo apt-get install gnucash
 2. $ gnucash
 3. Set up an account, just keep clicking Forward
 4. File->Import->OFX/QFX... and pick ofx-latin1.ofx
 5. Choose an account to add it to (like Liabilities->Credit Cards or something)
 6. The name will show as "d" but it should show as "déjà vu"

Patch:
Because Ubuntu only has 0.9.0 but upstream has released four bugfix releases (up to 0.9.4) that address this and other outstanding issues and Debian hasn't been responsive for years, it is felt that just updating to 0.9.4 is best. I've attached https://launchpadlibrarian.net/70440554/libofx.debian.diff which is just the debian/ changes for such an update.

If this is considered too intrusive, a more targeted patch could be prepared. This was just easier and seemed low-risk as there are no new features.

Full branch: https://code.launchpad.net/~mterry/ubuntu/natty/libofx/libofx.new-upstream-benoit-sru

See also bug 661809 and bug 771233, fixed by this same update.

Testing:
1:0.9.4-0ubuntu0.1 has been pushed to natty-proposed. Please test and verify the fix here. See https://wiki.ubuntu.com/QATeam/PerformingSRUVerification

=========================

The patch that closed bug #629996 causes a serious regression for latin-1 (non-utf-8) characters. Specifically, all string are truncated after the first non-ascii character.

I opening this bug because I don't have access to re-open bug #629996.

While the original patch was indeed accepted upstream months ago, it was changed hours later when the regression was found. Only the original patch was manually applied in Ubuntu.

Proposed merge above re-fixes the bug without the regression, as well as several other segfaults by upgrading to upstream.

Related branches

Changed in libofx (Ubuntu):
status: New → Confirmed
Revision history for this message
Michael Terry (mterry) wrote :

Test case

description: updated
description: updated
tags: added: verification-needed
Changed in libofx (Ubuntu Natty):
status: Confirmed → Triaged
status: Triaged → Fix Committed
Michael Terry (mterry)
description: updated
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted libofx into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Revision history for this message
Nobuto Murata (nobuto) wrote :

I couldn't verify that this bug was fixed in libofx 1:0.9.4-0ubuntu0.1/natty-proposed. It still shows only "d" string not "déjà vu" in name field. I will change the tag to verification-failed for now.

Can someone verify that natty-proposed package fixed this issue?

tags: added: verification-failed
removed: verification-needed
Revision history for this message
Benoit Grégoire (benoitg) wrote :
Revision history for this message
Benoit Grégoire (benoitg) wrote :
Revision history for this message
Benoit Grégoire (benoitg) wrote :

Original test case was incorrect (specified UTF-8 encoding but actually used iso-latin-1). I just attached two new test cases based on the first, with properly specified encodings. To verify:

apt-get install ofx (with enabled ubuntu-proposed)
Download the two test cases, and run
ofxdump ofx-test-iso-latin-1.ofx
ofxdump ofx-test-utf-8.ofx

The last line in both cases should be exactly:

Name of payee or transaction description: déjà vu

Setting tag back to verification-needed. It does work for me.

Revision history for this message
Nobuto Murata (nobuto) wrote :

libofx 1:0.9.4-0ubuntu0.1/natty-proposed works fine against new test files.
With current natty package, it shows just 'd' in name field. With natty-proposed package, it shows full string 'déjà vu'.

Benoit, thank you for providing new test files.

Martin Pitt (pitti)
tags: added: verification-done
removed: verification-failed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libofx - 1:0.9.4-0ubuntu0.1

---------------
libofx (1:0.9.4-0ubuntu0.1) natty-proposed; urgency=low

  * New upstream release. Since 0.9.4, all changes were bugfixes and
    changes requested by packagers
    - Fixes "libofx crashes on OFX import in gnucash" (LP: #661809)
    - Fixes bad regression from previous patch for 629996 that truncated
      all strings after the first non-ascii character (LP: #769554)
  * Fix various lintian reported problems
  * Remove previous patch for 629996 which causes regressions.
    A better patch was integrated upstream.
  * Install the man pages for ofxdump and ofxconnect (LP: #771233)
 -- Benoit Gregoire <email address hidden> Tue, 26 Apr 2011 09:33:38 -0400

Changed in libofx (Ubuntu Natty):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Copied to oneiric as well.

Changed in libofx (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.