places should support wrong Icon= format (with extensions)

got the same with cairo-dock and gtk-recordmydesktop

Traces are:

** (<unknown>:8082): WARNING **: Cannot find themed icon cairo-dock.svg
** (<unknown>:8082): WARNING **: Cannot find themed icon gtk-recordmydesktop.png
** (<unknown>:8082): WARNING **: Cannot find themed icon frozen-bubble-icon-48x48.png
** (<unknown>:8082): WARNING **: Cannot find themed icon cairo-dock.svg
** (<unknown>:8082): WARNING **: Cannot find themed icon hedgewars.png

Indeed, they all only are in /usr/share/pixmaps/

(apart from headgewars in /usr/share/games/hedgewars/Data/Graphics/Flags/hedgewars.png but that's rather a packaging issue as the .desktop file doesn't have full path for that one)

Hold on - doesn't this just invite bad icons in through the front door?
Don't we want SVG and PNG only?

@Mark: oh sorry, I didn't saw your answer first.
So, this doesn't change anything from the way gtk_icon_theme_lookup_by_gicon is loading the icon (it will still load the same set of icon).

That means:
a correct desktop file will use:
Icon=foo

-> this will try to load every foo.<ext> where ext is supported by gtk_icon_theme_lookup_by_gicon (foo)

some desktop file are using:
Icon=foo.png for instance, then gtk_icon_theme_lookup_by_gicon won't find a match (it doesn't support extension in the char * we give to it). We just remove the extension if we don't find a perfect match the first time in case they was an extension for gtk_icon_theme_lookup_by_gicon to pick the best available option.

So, we have
Icon=foo.png

-> gtk_icon_theme_lookup_by_gicon ("foo.png") -> doesn't work (as gtk_icon_theme_lookup_by_gicon doesn't support extension)
strip .png
gtk_icon_theme_lookup_by_gicon (icon)
let's

This bug was fixed in the package unity - 3.4.2-0ubuntu1

---------------
unity (3.4.2-0ubuntu1) natty; urgency=low

  * New upstream release:
    - add --distro switch to remove local installation of unity with default
      options (LP: #715703)
    - global search and speedups in places
    - Using fade effect to cut the window Title when it's longer than the panel
      (LP: #694924)
    - Launcher - Add ability for apps to indicate progress through Launcher icon
      (LP: #676596)
    - calling unity should kill unity-panel-service (LP: #711289)
    - unity places should return a default icon when no matching icon is found
      (LP: #711200)
    - the launcher should start hidding when an icon is clicked (LP: #709178)
    - Highlight drag-friendly Launcher tiles when dragging a file (LP: #607782)
    - Fix migrate_favorites.py crashed with OSError in get_log_file(): [Errno 2]
      No such file or directory: '/home/ubuntu/.local/share/unity' (LP: #711964)
    - places should support wrong Icon= format (with extensions) (LP: #711189)
    - unity crashed with AttributeError in reset_unity_compiz_profile():
      'NoneType' object has no attribute 'get_default_value' (LP: #711105)
    - unity crashed with GError in reset_unity_compiz_profile() (LP: #710876)
    - Middle click on application icon should open a new window (LP: #709707)
    - Launcher - Add interaction to support dragging and dropping behind the
      launcher (LP: #702482)
    - Launcher - Enable dragging and dropping of files & folders to Launcher
      icons (LP: #676549)
    - Launcher - Add number notifier to Launcher icons (LP: #676455)
    - Support dragging files to trash to delete them (LP: #619686)
    - [launcher] Indicator-only applications showing as open applications
      (LP: #703396)
    - Unity does not accept mouse clicks (LP: #683328)
    - dash is empty (LP: #710792)
  * debian/control:
    - depends on latest nux
 -- Didier Roche <email address hidden> Thu, 10 Feb 2011 20:45:47 +0100