GTK UI should provide callbacks instead of gobject signals
Bug #695798 reported by
Natalia Bidart
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Single Sign On Client |
Fix Released
|
High
|
Natalia Bidart | ||
| ubuntu-sso-client (Ubuntu) |
Fix Released
|
High
|
Natalia Bidart | ||
Bug Description
The GTK UI class should signal outcome through callbacks instead of emitting gobject signals. This way, we can ease using another graphical interfaces in the DBus service.
This way, the dependency to gobject within the credentials.py module can be removed.
Related branches
lp:~nataliabidart/ubuntu-sso-client/no-more-gobject
- Roberto Alsina (community): Approve
- Manuel de la Peña (community): Approve
-
Diff: 956 lines (+263/-234)5 files modifiedubuntu_sso/credentials.py (+21/-28)
ubuntu_sso/gtk/gui.py (+27/-32)
ubuntu_sso/gtk/tests/test_gui.py (+155/-86)
ubuntu_sso/tests/test_credentials.py (+49/-84)
ubuntu_sso/tests/test_main.py (+11/-4)
| Changed in ubuntu-sso-client: | |
| status: | New → In Progress |
| assignee: | nobody → Naty Bidart (nataliabidart) |
| importance: | Undecided → High |
| Changed in ubuntu-sso-client (Ubuntu): | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | nobody → Naty Bidart (nataliabidart) |
| description: | updated |
| Changed in ubuntu-sso-client: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-sso-client (Ubuntu): | |
| status: | Triaged → Fix Released |
| Changed in ubuntu-sso-client: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-sso-client - 1.1.8-0ubuntu1
---------------
ubuntu-sso-client (1.1.8-0ubuntu1) natty; urgency=low
* New upstream release:
[ Natalia B. Bidart <email address hidden>]
- The service should shutdown when unused
(LP: #701606),
- On error, {find,clear,
signal (LP: #696676).
- No more gobject dependency on non-GUI classes!
(LP: #695798).
- After login, if the storing of credentials fails, send LoginError
(LP: #693531).
- Use ubuntuone-dev-tools to run the tests and the lint checker
(LP: #686606).
-- Natalia Bidart (nessita) <email address hidden> Wed, 12 Jan 2011 15:59:23 -0300