pcmanfm doesn't escape spaces in filenames it executes

Bug #693990 reported by Eliah Kagan
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
PCManFM
Unknown
Unknown
pcmanfm (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Binary package hint: pcmanfm

When you double-click on a file to execute in pcmanfm, this will only succeed if there are no spaces in its absolute path. Spaces in the filename or in any directories in the file's full path are not escaped -- consequently, double-clicking on a file with its executable bit set results in pcmanfm attempting to execute the file whose path consists of all the characters in the original file's path before the first space. (Typically that file, if different from the original, would not exist.)

I have already reproduced this bug with the latest upstream git sources and reported it on the upstream tracker:
http://sourceforge.net/tracker/?func=detail&aid=3143296&group_id=156956&atid=801864

This bug is also either similar or idential to a bug previously reported last month, which was believed to be fixed in the latest git sources and marked out-of-date on the upstream tracker:
http://sourceforge.net/tracker/?func=detail&aid=3101059&group_id=156956&atid=801864

The reason I am filing a report here even though I have no reason to think the issue is specific to Ubuntu and I have reported it upstream, is that it seems to me that this bug is significant enough that, once fixed, the fix ought to be backported to pcmanfm in supported Ubuntu releases.

Note that this is not the same bug as Bug 686526, which applies to the URI created and passed via the --extract-here flag to file-roller. This is also not the same as the bug with upstream (SourceForge) ID 3096318 (referenced in Bug 686526), which applied to the opening (not executing) of files with certain associations.

Theoretically, this is a security vulnerabilty, in that it could be exploited on a multi-user system (or any system that mounts a drive shared between systems) to cause a user to execute a malicious executable inside a sticky directory. However, I am not flagging this as a security vulnerability. Should I? That is one of the reasons I think its fix, once committed to the upstream git tree, should be backported to previous versions in Ubuntu. But it seems that the insecurity produced by this bug is small, while the unusability produced by it is large and the primary reason it should be fixed.

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: pcmanfm 0.9.7-1ubuntu1
ProcVersionSignature: Ubuntu 2.6.35-24.42-generic 2.6.35.8
Uname: Linux 2.6.35-24-generic x86_64
Architecture: amd64
Date: Thu Dec 23 20:59:07 2010
ExecutablePath: /usr/bin/pcmanfm
InstallationMedia: Xubuntu 10.04 "Lucid Lynx" - Beta amd64 (20100406)
Pref_Config_System_Lubuntu:
 [Preferred Applications]
 WebBrowser=firefox.desktop
 MailClient=
ProcEnviron:
 LANGUAGE=en_US.utf8
 LANG=en_US.utf8
 LC_MESSAGES=en_US.utf8
 SHELL=/bin/bash
RelatedPackageVersions:
 libmenu-cache1 0.3.2-2
 pcmanfm 0.9.7-1ubuntu1
 udisks 1.0.1+git20100614-3
 gvfs 1.6.4-0ubuntu1.1
SourcePackage: pcmanfm

Related branches

Revision history for this message
Eliah Kagan (degeneracypressure) wrote :
description: updated
description: updated
Revision history for this message
Charlie Kravetz (cjkgeek) wrote :

Thanks for reporting this bug and any supporting documentation. Since this bug has enough information provided for a developer to begin work, I'm going to mark it as confirmed and let them handle it from here.

Thanks for reporting this bug to the developers of the software. You can track it and make comments at: http://sourceforge.net/support/tracker.php?aid=3143296

Thanks for taking the time to make Ubuntu better!

Changed in pcmanfm (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pcmanfm - 0.9.8+git-6240436419-0ubuntu1

---------------
pcmanfm (0.9.8+git-6240436419-0ubuntu1) natty; urgency=low

  * New upstream snapshot (2011-02-15)
   - Correctly handle spaces in path and filenames (LP: #686526, #693990).
  * debian/patches/
   - 90-enable-fake-transparency.patch: Remove, merged upstream.
   - 01-libfm-0.1.14-API-changes.patch: Refresh.
  * debian/control
   - Build-depends on libfm-dev (>= 0.1.15).
 -- Julien Lavergne <email address hidden> Mon, 21 Feb 2011 23:18:32 +0100

Changed in pcmanfm (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.