catch more cases for 'Keep in Launcher' by recognizing StatupWMClass from .desktop file

Bug #693231 reported by Alexander Sack
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
BAMF
Fix Released
Undecided
Marco Trevisan (Treviño)
Unity
Fix Released
Undecided
Unassigned
bamf (Ubuntu)
Fix Released
Undecided
Unassigned
unity (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

For a while I didn't understand why Firefox daily packages didn't work. Buf finally I found some time to look into this.

Finding is that for things like firefox daily etc. we have a window class name called "Minefield", but the desktop file is still called "firefox-4.0.desktop". In turn bamf, doesn't map those.

Adding support to recognize StartupWMClass= field (if available in .desktop files) would allow bamf to support more .desktop file variants, including firefox daily builds.

I have a branch that has this feature here: lp:~asac/bamf/match-apps-by-startup-wm-class

A preview package for maverick that includes an update to the .postinst to generate the new index format is available in ppa:asac/ppa
 + DSC: https://launchpad.net/~asac/+archive/ppa/+files/bamf_0.2.58-0ubuntu2.asac1.dsc
 + debdiff: http://launchpadlibrarian.net/60349193/bamf_0.2.58-0ubuntu2_0.2.58-0ubuntu2.asac1.diff.gz

... with those changes i can keep firefox daily builds in my launcher,yay ;).

Related branches

Revision history for this message
Alexander Sack (asac) wrote :
Alex Launi (alexlauni)
Changed in bamf:
status: New → Confirmed
Revision history for this message
Alexander Sack (asac) wrote :

confirmed that this also helps for gajim (great jabber client) for me ...

Revision history for this message
Robert Dyer (psybers) wrote :

This is the strategy Docky uses for matching these types of applications. It also works for matching (some) Java applications.

Changed in unity:
status: New → Confirmed
Changed in bamf (Ubuntu):
status: New → Confirmed
Changed in bamf:
status: Confirmed → In Progress
assignee: nobody → Treviño (Marco Trevisan) (3v1n0)
Changed in bamf:
status: In Progress → Fix Committed
Changed in unity:
status: Confirmed → Fix Committed
Changed in bamf (Ubuntu):
status: Confirmed → Fix Committed
Neil J. Patel (njpatel)
Changed in unity:
milestone: none → 3.8.2
Changed in bamf:
status: Fix Committed → Fix Released
Changed in unity:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bamf - 0.2.82-0ubuntu1

---------------
bamf (0.2.82-0ubuntu1) natty; urgency=low

  * New upstream release.
    - bamfdaemon crashed with SIGSEGV in XInternAtom() (LP: #743407)
    - catch more cases for 'Keep in Launcher' by recognizing StatupWMClass
      from .desktop file (LP: #693231)
 -- Didier Roche <email address hidden> Fri, 01 Apr 2011 11:17:17 +0200

Changed in bamf (Ubuntu):
status: Fix Committed → Fix Released
no longer affects: bamf (Ubuntu Quantal)
Changed in unity (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.