Async uploader sends recipe mail as if it were source package uploads

Fixed in stable r12275 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12275>.

The success emails are now correct, but it's still sending a "rejected" message on failure.

It appears that the problem is that PackageUpload.getSourceBuild only returns non-None if the upload succeeded. The tests of build failure emails must therefore have inaccurate test fixtures.

It's not clear to me whether there's another way to get the source build that would work in this context. bigjools suggests that build-based uploads can be detected because they will always have None for PackageUpload.signing_key, but using this check causes test failures.

We need to examine the rationale behind these emails and how they fit into the bigger picture of the existing source upload notifications.

Making source uploads from recipes look like "builds" seems very wrong to me, and when we start using them for Ubuntu they will most certainly want to continue using the existing notification logic and email style in PackageUpload.notify().

I think we should be doing this:

Build OK and Upload OK -> send no build notification email, let PU.notify() do the notifications (with changes to show it was from a recipe)
Build OK and Upload FAIL -> send no build notification email, let PU.notify() do the notifications (with changes to show it was from a recipe)
Build FAIL and no Upload -> send build failure notification only

The existing PU.notify() knows all about who to email and when, including multiple emails where necessary to the user and the changes list, for example. We have to use it.

I think this has been deployed?

The linked branch has been deployed, but the fix is incomplete, so I reset the status to "Triaged."