Comment 4 for bug 681125

Revision history for this message
Julian Edwards (julian-edwards) wrote :

We need to examine the rationale behind these emails and how they fit into the bigger picture of the existing source upload notifications.

Making source uploads from recipes look like "builds" seems very wrong to me, and when we start using them for Ubuntu they will most certainly want to continue using the existing notification logic and email style in PackageUpload.notify().

I think we should be doing this:

Build OK and Upload OK -> send no build notification email, let PU.notify() do the notifications (with changes to show it was from a recipe)
Build OK and Upload FAIL -> send no build notification email, let PU.notify() do the notifications (with changes to show it was from a recipe)
Build FAIL and no Upload -> send build failure notification only

The existing PU.notify() knows all about who to email and when, including multiple emails where necessary to the user and the changes list, for example. We have to use it.