Psi version string presents as "Debian testing/unstable" on Dapper

Bug #66940 reported by davee
14
Affects Status Importance Assigned to Milestone
psi (Ubuntu)
Fix Released
Low
Luke Yelavich

Bug Description

Binary package hint: psi

Psi under Dapper presents a version string of "0.10: Debian GNU/Linux testing/unstable". This should probably be something Ubuntu-specific.

Looking at the source, in src/common.cpp Psi determines its OS and flavour by looking for various pertinent 'version' files on the system, i.e. /etc/debian_version, /etc/redhat-release and /etc/gentoo-release and so on. It finds that /etc/debian_version exists on the system and assumes it's running on Debian.

To present the correct version string under Ubuntu, I guess it would need to look at /etc/lsb-release.

I'm unclear whether this is really an Ubuntu bug, or whether it should be fixed upstream. I could supply a patch for this if required, although it really would be extremely trivial.

Revision history for this message
davee (davee-sungate) wrote :

http://flyspray.psi-im.org/task/420 - just spotted this (not-yet-implemented) upstream enhancement to Psi which uses lsb_release to determine the OS/flavour. Given that it returns sensible values under Ubuntu:

$ lsb_release --id --codename --release --short
Ubuntu
6.06
dapper

if this change is incorporated into Psi, Ubuntu will be present in the version string issued by Psi.

Revision history for this message
davee (davee-sungate) wrote :

Further comment, just to clarify/update: Psi in Edgy (version 0.10-2ubuntu2) has the above symptoms: the version string presents as "Debian GNU/Linux (testing/unstable)".

William Grant (wgrant)
Changed in psi:
importance: Undecided → Low
status: Unconfirmed → Confirmed
Changed in psi:
assignee: nobody → xxxxx1
status: Confirmed → In Progress
Revision history for this message
deadwill (deadwill-deactivatedaccount) wrote :

Thanks for your bug report Dave. Btw, the task as you'd mentioned is not useful since it's just an script and cannot be adopted in Psi. I'm working on a implementation on latest Psi development version in svn repos.

Revision history for this message
deadwill (deadwill-deactivatedaccount) wrote :

For the love of Ubuntu :)
... I've added some code to Psi 0.10 to support lsb versioning. check the shot!

I'm doing the work on package now.

Revision history for this message
deadwill (deadwill-deactivatedaccount) wrote :

done! \o/ debdiff as attachment.

Changed in psi:
assignee: xxxxx1 → nobody
status: In Progress → Confirmed
Luke Yelavich (themuso)
Changed in psi:
assignee: nobody → themuso
status: Confirmed → In Progress
Revision history for this message
deadwill (deadwill-deactivatedaccount) wrote :

psi (0.10-2ubuntu3) gutsy; urgency=low

  * Add dpatch support in debian/control and debian/rules.
  * Add patches/01_lsb_version.dpatch (LP: #66940).
  * Change Maintainer/XSBC-Original-Maintainer field.

 -- William Lima <email address hidden> Thu, 9 Aug 2007 16:01:48 -0300

Changed in psi:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.