Synthetic emboldening settings in zh_{CN,HK,SG,TW}

Bug #64294 reported by Haifeng Chen
6
Affects Status Importance Assigned to Milestone
language-selector (Ubuntu)
Fix Released
Medium
Michael Vogt

Bug Description

Binary package hint: language-selector-common

Following lines are the current settings in language-selector-common package.
(zh_CN, zh_HK, zh_SG, zh_TW)

        <match target="font" >
                <test name="family" compare="contains" >
                        <string>Song</string>
                        <string>Sun</string>
                        <string>Kai</string>
                        <string>Ming</string>
                </test>
                <test compare="more_eq" target="pattern" name="weight" >
                        <int>180</int>
                </test>
                <edit mode="assign" name="embolden" >
                        <bool>true</bool>
                </edit>
        </match>

Obviously , we forget to check whether the matched fonts are regular or bold.
And only fonts do not have bold face available need synthetic emboldening.
So the settings should be changed to :

       <match target="font" >
                <test name="family" compare="contains" >
                        <string>Song</string>
                        <string>Sun</string>
                        <string>Kai</string>
                        <string>Ming</string>
                </test>
                <!-- check to see if the font is just regular -->
                <test name="weight" compare="less_eq">
                        <int>100</int>
                <test compare="more_eq" target="pattern" name="weight" >
                        <int>180</int>
                </test>
                <edit mode="assign" name="embolden" >
                        <bool>true</bool>
                </edit>
        </match>

Changed in language-selector:
importance: Undecided → Medium
status: Unconfirmed → Confirmed
Changed in language-selector:
assignee: nobody → mvo
Revision history for this message
Jiahua Huang (huangjiahua) wrote :

yes, it's correct.

Revision history for this message
Michael Vogt (mvo) wrote :
Revision history for this message
Michael Vogt (mvo) wrote :

Fixed with the latest language-selector upload.

Changed in language-selector:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.