Launchpad itself

Offiical_* booleans must be deprecated in favor of usage enums

Bug #623408 reported by j.c.sackett
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
j.c.sackett
Launchpad itself 10.10

Bug Description

Projects in Launchpad use a set of boolean fields to indicate how they use Launchpad services. Recently, better enum fields have been added that allow more information than just Yes/No to answer the question of how a project uses Launchpad.

The codebase needs to be updated to use these enums.

Related branches

lp:~jcsackett/launchpad/deprecate-official_malone
Edwin Grubbs (community): Approve (code)
Diff: 979 lines (+148/-116)
25 files modified
lib/canonical/launchpad/doc/vocabularies.txt (+3/-3)
lib/canonical/launchpad/vocabularies/dbobjects.py (+8/-6)
lib/lp/bugs/browser/bugalsoaffects.py (+6/-4)
lib/lp/bugs/browser/bugtarget.py (+12/-7)
lib/lp/bugs/browser/bugtask.py (+24/-22)
lib/lp/bugs/browser/distribution_upstream_bug_report.py (+13/-8)
lib/lp/bugs/browser/tests/bugtask-adding-views.txt (+6/-6)
lib/lp/bugs/browser/tests/test_bugtarget_configure.py (+4/-1)
lib/lp/bugs/model/bug.py (+2/-1)
lib/lp/bugs/model/bugtask.py (+10/-7)
lib/lp/bugs/templates/bug-create-question.pt (+1/-1)
lib/lp/bugs/templates/bugtarget-macros-filebug.pt (+1/-1)
lib/lp/bugs/templates/bugtask-requestfix-upstream.pt (+3/-3)
lib/lp/bugs/templates/distribution-upstream-bug-report.pt (+6/-4)
lib/lp/bugs/tests/bugtarget-questiontarget.txt (+4/-4)
lib/lp/bugs/tests/test_bugs_webservice.py (+20/-12)
lib/lp/bugs/tests/test_bugtask_1.py (+8/-9)
lib/lp/registry/browser/sourcepackage.py (+5/-5)
lib/lp/registry/browser/tests/distribution-views.txt (+4/-4)
lib/lp/registry/browser/tests/sourcepackage-views.txt (+2/-2)
lib/lp/registry/doc/product.txt (+2/-2)
lib/lp/registry/templates/distribution-index.pt (+1/-1)
lib/lp/registry/templates/distribution-search.pt (+1/-1)
lib/lp/registry/templates/product-index.pt (+1/-1)
lib/lp/testing/factory.py (+1/-1)
lp:~jcsackett/launchpad/deprecate-official_codehosting
Brad Crittenden (community): Approve (code)
Diff: 330 lines (+72/-30)
8 files modified
lib/lp/registry/adapters.py (+18/-2)
lib/lp/registry/browser/distribution.py (+2/-1)
lib/lp/registry/browser/pillar.py (+16/-7)
lib/lp/registry/browser/productseries.py (+11/-3)
lib/lp/registry/browser/tests/pillar-views.txt (+8/-8)
lib/lp/registry/browser/tests/productseries-views.txt (+4/-4)
lib/lp/registry/configure.zcml (+7/-0)
lib/lp/registry/stories/product/xx-product-launchpad-usage.txt (+6/-5)
lp:~jcsackett/launchpad/deprecate-official_rosetta
Leonard Richardson (community): Approve
Diff: 3172 lines (+649/-426)
51 files modified
lib/lp/app/enums.py (+6/-1)
lib/lp/registry/browser/distribution.py (+2/-1)
lib/lp/registry/browser/pillar.py (+11/-8)
lib/lp/registry/browser/tests/pillar-views.txt (+4/-3)
lib/lp/registry/browser/tests/productseries-views.txt (+6/-4)
lib/lp/registry/doc/distribution.txt (+125/-114)
lib/lp/registry/doc/product.txt (+62/-44)
lib/lp/registry/doc/project.txt (+24/-15)
lib/lp/registry/model/projectgroup.py (+4/-1)
lib/lp/testing/factory.py (+7/-4)
lib/lp/translations/browser/potemplate.py (+4/-2)
lib/lp/translations/browser/product.py (+11/-8)
lib/lp/translations/browser/tests/language-views.txt (+4/-1)
lib/lp/translations/browser/tests/test_breadcrumbs.py (+3/-2)
lib/lp/translations/doc/potmsgset.txt (+59/-33)
lib/lp/translations/doc/translationimportqueue.txt (+54/-25)
lib/lp/translations/doc/translationmessage-destroy.txt (+10/-5)
lib/lp/translations/doc/translations-export-to-branch.txt (+10/-6)
lib/lp/translations/doc/translationsoverview.txt (+14/-6)
lib/lp/translations/model/potemplate.py (+11/-10)
lib/lp/translations/model/potmsgset.py (+8/-7)
lib/lp/translations/model/translationsoverview.py (+6/-3)
lib/lp/translations/model/translationsperson.py (+4/-0)
lib/lp/translations/scripts/translations_to_branch.py (+3/-0)
lib/lp/translations/stories/buildfarm/xx-build-summary.txt (+8/-4)
lib/lp/translations/stories/importqueue/xx-entry-details.txt (+9/-5)
lib/lp/translations/stories/productseries/xx-productseries-export-to-branch.txt (+9/-6)
lib/lp/translations/stories/productseries/xx-productseries-translations.txt (+5/-3)
lib/lp/translations/stories/standalone/custom-language-codes.txt (+5/-3)
lib/lp/translations/stories/standalone/xx-potemplate-index.txt (+28/-12)
lib/lp/translations/stories/standalone/xx-product-export.txt (+9/-5)
lib/lp/translations/stories/standalone/xx-product-translations.txt (+0/-1)
lib/lp/translations/stories/standalone/xx-template-description-escaping.txt (+3/-1)
lib/lp/translations/stories/translationfocus/xx-product-translationfocus.txt (+5/-3)
lib/lp/translations/stories/translationgroups/xx-change-translation-policy.txt (+5/-1)
lib/lp/translations/templates/product-portlet-not-using-launchpad.pt (+1/-1)
lib/lp/translations/templates/productseries-translations.pt (+1/-1)
lib/lp/translations/tests/test_autoapproval.py (+9/-8)
lib/lp/translations/tests/test_empty_messages.py (+13/-11)
lib/lp/translations/tests/test_hastranslationtemplates.py (+5/-4)
lib/lp/translations/tests/test_pofile.py (+17/-14)
lib/lp/translations/tests/test_potemplate.py (+3/-2)
lib/lp/translations/tests/test_potmsgset.py (+11/-8)
lib/lp/translations/tests/test_productserieslanguage.py (+9/-4)
lib/lp/translations/tests/test_shared_potemplate.py (+3/-2)
lib/lp/translations/tests/test_suggestions.py (+10/-4)
lib/lp/translations/tests/test_translatablemessage.py (+9/-7)
lib/lp/translations/tests/test_translatedlanguage.py (+5/-2)
lib/lp/translations/tests/test_translations_to_review.py (+6/-3)
lib/lp/translations/windmill/tests/test_documentation_links.py (+2/-1)
lib/lp/translations/windmill/tests/test_import_queue.py (+7/-7)
lp:~jcsackett/launchpad/deprecate-remaining-official-bools
Paul Hummer (community): Approve
Diff: 632 lines (+121/-109)
19 files modified
lib/lp/answers/browser/questiontarget.py (+2/-1)
lib/lp/answers/doc/question.txt (+5/-5)
lib/lp/answers/doc/questionsets.txt (+8/-8)
lib/lp/registry/browser/distribution.py (+2/-2)
lib/lp/registry/browser/pillar.py (+21/-16)
lib/lp/registry/browser/productseries.py (+1/-1)
lib/lp/registry/browser/tests/distribution-views.txt (+3/-2)
lib/lp/registry/browser/tests/pillar-views.txt (+20/-20)
lib/lp/registry/browser/tests/product-views.txt (+3/-2)
lib/lp/registry/browser/tests/productseries-views.txt (+7/-7)
lib/lp/registry/browser/tests/projectgroup-views.txt (+4/-2)
lib/lp/registry/doc/distribution.txt (+15/-14)
lib/lp/registry/doc/product.txt (+14/-14)
lib/lp/registry/templates/distribution-index.pt (+3/-3)
lib/lp/registry/templates/distribution-search.pt (+2/-2)
lib/lp/registry/templates/distroseries-index.pt (+2/-1)
lib/lp/registry/templates/product-index.pt (+3/-3)
lib/lp/registry/templates/productseries-index.pt (+1/-1)
lib/lp/registry/templates/project-index.pt (+5/-5)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Incremental fix

r11484 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11484) is part of this bug's fix.

Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
j.c.sackett (jcsackett) wrote :

Changing back to in-progress; not sure why it auto changed, given it registered the incremental fix.

Changed in launchpad-registry:
status: Fix Committed → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r11493 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11493) is part of this bug's fix.

Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
j.c.sackett (jcsackett) wrote :

Switching status back to In Progress again. Should I file a bug about incremental fixes not preventing the auto-mark of fix-committed, or am I doing something wrong?

Changed in launchpad-registry:
status: Fix Committed → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

You need to land your branch with the incremental switch so that the bot does not assume a the bug is fixed.

Revision history for this message
j.c.sackett (jcsackett) wrote : Re: [Bug 623408] Re: Offiical_* booleans must be deprecated in favor of usage enums

I did, on both branches landed; reading through the messages on this shows they were landed as partial fixes, via --incremental.

Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: 10.09 → 10.10
Revision history for this message
Ursula Junque (ursinha) wrote :

@Jonathan: I'm sorry about that, when you warned me about this problem I filed a bug (bug 631815), which already has a branch reviewed and is going live now. Sorry for the inconvenience!

Revision history for this message
j.c.sackett (jcsackett) wrote :

@Ursula: Thanks for the info on the branch! It's no real problem, just curious if I needed to file a bug, and clearly I don't.

Thanks for the quick handling of this.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Incremental fix

r11520 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11520) is part of this bug's fix.

Revision history for this message
Ursula Junque (ursinha) wrote :

As this is a partial fix, the branch cannot be QAed, therefore qa-untestable.

tags: added: qa-untestable
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r11528 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11528) is part of this bug's fix.

j.c.sackett (jcsackett)
tags: added: qa-ok
removed: qa-untestable
Changed in launchpad-registry:
status: In Progress → Fix Committed
Robert Collins (lifeless)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.