Merge lp:~jcsackett/launchpad/deprecate-remaining-official-bools into lp:launchpad

[j.c.sackett]

Replaces use of official_answers and official_blueprints with their usage enum equivalents.

= Summary =

Replaces, where possible, usage of official_blueprints and official_answers with their usage enum equivalents.

== Proposed fix ==

Where code uses one of the above mentioned bools, use the enum instead so that we can take advantage of richer data.

== Pre-implementation notes ==

Spoke with Curtis Hovey (sinzui) and Brad Crittenden (bac).

== Implementation details ==

As in Proposed fix.

SQL queries using the official_<app> booleans have been left alone until data migration occurs.

== Tests ==

No new tests written.

To fully test the refactor:

bin/test -m lp.registry
bin/test -m lp.answers
bin/test -m lp.blueprints

== Demo and Q/A ==

In Launchpad.dev, there should be no apparent changes to any views related to answers or blueprints.

== Launchpad lint ==

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/answers/browser/questiontarget.py
  lib/lp/answers/doc/question.txt
  lib/lp/answers/doc/questionsets.txt
  lib/lp/app/enums.py
  lib/lp/registry/adapters.py
  lib/lp/registry/configure.zcml
  lib/lp/registry/browser/distribution.py
  lib/lp/registry/browser/pillar.py
  lib/lp/registry/browser/productseries.py
  lib/lp/registry/browser/tests/distribution-views.txt
  lib/lp/registry/browser/tests/pillar-views.txt
  lib/lp/registry/browser/tests/product-views.txt
  lib/lp/registry/browser/tests/productseries-views.txt
  lib/lp/registry/browser/tests/projectgroup-views.txt
  lib/lp/registry/doc/distribution.txt
  lib/lp/registry/doc/product.txt
  lib/lp/registry/templates/distribution-index.pt
  lib/lp/registry/templates/distribution-search.pt
  lib/lp/registry/templates/distroseries-index.pt
  lib/lp/registry/templates/product-index.pt
  lib/lp/registry/templates/productseries-index.pt
  lib/lp/registry/templates/project-index.pt

[Paul Hummer (rockstar)]

25 @@ -72,13 +72,13 @@
26 ==============
27
28 A product or distribution may be officially supported by the community using
29 -the Answer Tracker. This status is set by the official_answers attribute on
30 +the Answer Tracker. This status is set by the answers_usage attribute on
31 the IProduct and IDistribution.
32
33 - >>> ubuntu.official_answers
34 - True
35 - >>> firefox.official_answers
36 - True
37 + >>> ubuntu.answers_usage.name
38 + 'LAUNCHPAD'
39 + >>> firefox.answers_usage.name
40 + 'LAUNCHPAD'

I'd rather you print these than just getting the value.

342 === modified file 'lib/lp/registry/browser/tests/productseries-views.txt'
343 --- lib/lp/registry/browser/tests/productseries-views.txt 2010-08-27 19:19:27 +0000
344 +++ lib/lp/registry/browser/tests/productseries-views.txt 2010-09-02 16:47:49 +0000
345 @@ -23,18 +23,19 @@
346 The ProductSeries involvement view uses the ProductSeriesInvolvedMenu when
347 rendering links:
348
349 + >>> from lp.app.enums import ServiceUsage
350 >>> login_person(product.owner)
351 - >>> product.official_answers = True
352 - >>> product.official_blueprints = True
353 + >>> product.answers_usage = ServiceUsage.LAUNCHPAD
354 + >>> product.blueprints_usage = ServiceUsage.LAUNCHPAD
355 >>> product.official_malone = True
356 >>> product.official_rosetta = True
357 >>> view = create_view(series, '+get-involved')
358
359 - # official_answers is always false for product series.
360 - >>> print view.official_answers
361 - False
362 - >>> print view.official_blueprints
363 - True
364 + # answers_usage is never LAUNCHPAD for product series.
365 + >>> print view.answers_usage.name
366 + UNKNOWN
367 + >>> print view.blueprints_usage.name
368 + 'LAUNCHPAD'

Hm, how does this work? If you're printing the value here, why are you still getting quotes?

So I think I'd rather you print all the values instead of getting them as strings, and I think you might need to run these tests to make sure you're getting the right values. I suspect in some case you're printing something and expecting the quoted value instead of the string.

Thanks for updating the doctests. One more doctest up to date.

review: Needs Information

[j.c.sackett (jcsackett)]

> 37 + >>> ubuntu.answers_usage.name
> 38 + 'LAUNCHPAD'
> 39 + >>> firefox.answers_usage.name
> 40 + 'LAUNCHPAD'
>
> I'd rather you print these than just getting the value.

I was debating this myself prior to the review. This (and other instances) are fixed.

> 367 + >>> print view.blueprints_usage.name
> 368 + 'LAUNCHPAD'
>
> Hm, how does this work? If you're printing the value here, why are you still getting quotes?

It doesn't work. I believe that was a casualty of my wavering on how to go about setting up those tests. It too has been resolved.

> Thanks for updating the doctests. One more doctest up to date.

Happy to do it.

//j.c.sackett

[Paul Hummer (rockstar)]

review: Approve

=== modified file 'lib/lp/answers/browser/questiontarget.py'
--- lib/lp/answers/browser/questiontarget.py	2010-08-31 11:31:04 +0000
+++ lib/lp/answers/browser/questiontarget.py	2010-09-10 13:32:47 +0000
@@ -78,6 +78,7 @@
     IQuestionTarget,
     ISearchQuestionsForm,
     )
+from lp.app.enums import service_uses_launchpad
 from lp.app.errors import NotFoundError
 from lp.registry.interfaces.distribution import IDistribution
 from lp.registry.interfaces.product import IProduct
@@ -204,7 +205,7 @@
             return self.default_template
         involvement = getMultiAdapter(
             (self.context, self.request), name='+get-involved')
-        if involvement.official_answers:
+        if service_uses_launchpad(involvement.answers_usage):
             # Primary contexts that officially use answers have a
             # search and listing presentation.
             return self.default_template

=== modified file 'lib/lp/answers/doc/question.txt'
--- lib/lp/answers/doc/question.txt	2010-07-28 16:56:05 +0000
+++ lib/lp/answers/doc/question.txt	2010-09-10 13:32:47 +0000
@@ -72,13 +72,13 @@
 ==============
 
 A product or distribution may be officially supported by the community using
-the Answer Tracker.  This status is set by the official_answers attribute on
+the Answer Tracker.  This status is set by the answers_usage attribute on
 the IProduct and IDistribution.
 
-    >>> ubuntu.official_answers
-    True
-    >>> firefox.official_answers
-    True
+    >>> print ubuntu.answers_usage.name
+    LAUNCHPAD
+    >>> print firefox.answers_usage.name
+    LAUNCHPAD
 
 
 IQuestion interface

=== modified file 'lib/lp/answers/doc/questionsets.txt'
--- lib/lp/answers/doc/questionsets.txt	2010-07-27 17:18:24 +0000
+++ lib/lp/answers/doc/questionsets.txt	2010-09-10 13:32:47 +0000
@@ -208,14 +208,14 @@
 order of the returned projects is based on the number of questions asked
 during the period.
 
-    >>> ubuntu.official_answers
-    True
-    >>> firefox.official_answers
-    True
-    >>> landscape.official_answers
-    False
-    >>> launchpad.official_answers
-    True
+    >>> print ubuntu.answers_usage.name
+    LAUNCHPAD
+    >>> print firefox.answers_usage.name
+    LAUNCHPAD
+    >>> print landscape.answers_usage.name
+    UNKNOWN
+    >>> print launchpad.answers_usage.name
+    LAUNCHPAD
 
     # Launchpad is not returned because the question was not asked in
     # the last 60 days.

=== modified file 'lib/lp/registry/browser/distribution.py'
--- lib/lp/registry/browser/distribution.py	2010-09-03 13:29:58 +0000
+++ lib/lp/registry/browser/distribution.py	2010-09-10 13:32:47 +0000
@@ -123,10 +123,10 @@
         """Return a string of LP apps (comma-separated) this distro uses."""
         uses = []
         href_template = """<a href="%s">%s</a>"""
-        if self.context.official_answers:
+        if service_uses_launchpad(self.context.answers_usage):
             url = canonical_url(self.context, rootsite='answers')
             uses.append(href_template % (url, 'Answers'))
-        if self.context.official_blueprints:
+        if service_uses_launchpad(self.context.blueprints_usage):
             url = canonical_url(self.context, rootsite='blueprints')
             uses.append(href_template % (url, 'Blueprints'))
         if self.context.official_malone:

=== modified file 'lib/lp/registry/browser/pillar.py'
--- lib/lp/registry/browser/pillar.py	2010-09-03 13:29:58 +0000
+++ lib/lp/registry/browser/pillar.py	2010-09-10 13:32:47 +0000
@@ -70,7 +70,7 @@
     def ask_question(self):
         return Link(
             '+addquestion', 'Ask a question', site='answers', icon='answers',
-            enabled=self.pillar.official_answers)
+            enabled=service_uses_launchpad(self.pillar.answers_usage))
 
     def help_translate(self):
         return Link(
@@ -91,8 +91,11 @@
 
     def register_blueprint(self):
         return Link(
-            '+addspec', 'Register a blueprint', site='blueprints',
-            icon='blueprints', enabled=self.pillar.official_blueprints)
+            '+addspec',
+            'Register a blueprint',
+            site='blueprints',
+            icon='blueprints',
+            enabled=service_uses_launchpad(self.pillar.blueprints_usage))
 
 
 class PillarView(LaunchpadView):
@@ -105,8 +108,8 @@
     def __init__(self, context, request):
         super(PillarView, self).__init__(context, request)
         self.official_malone = False
-        self.official_answers = False
-        self.official_blueprints = False
+        self.answers_usage = ServiceUsage.UNKNOWN
+        self.blueprints_usage = ServiceUsage.UNKNOWN
         self.translations_usage = ServiceUsage.UNKNOWN
         self.codehosting_usage = ServiceUsage.UNKNOWN
         pillar = nearest(self.context, IPillar)
@@ -119,11 +122,11 @@
         else:
             self._set_official_launchpad(pillar)
             if IDistroSeries.providedBy(self.context):
-                self.official_answers = False
                 distribution = self.context.distribution
                 self.codehosting_usage = distribution.codehosting_usage
+                self.answers_usage = ServiceUsage.NOT_APPLICABLE
             elif IDistributionSourcePackage.providedBy(self.context):
-                self.official_blueprints = False
+                self.blueprints_usage = ServiceUsage.UNKNOWN
                 self.translations_usage = ServiceUsage.UNKNOWN
             else:
                 # The context is used by all apps.
@@ -135,19 +138,21 @@
         # times to build the complete set of official applications.
         if pillar.official_malone:
             self.official_malone = True
-        if pillar.official_answers:
-            self.official_answers = True
-        if pillar.official_blueprints:
-            self.official_blueprints = True
-        self.translations_usage = IServiceUsage(pillar).translations_usage
-        self.codehosting_usage = IServiceUsage(pillar).codehosting_usage
+        if service_uses_launchpad(IServiceUsage(pillar).answers_usage):
+            self.answers_usage = ServiceUsage.LAUNCHPAD
+        if service_uses_launchpad(IServiceUsage(pillar).blueprints_usage):
+            self.blueprints_usage = ServiceUsage.LAUNCHPAD
+        if service_uses_launchpad(pillar.translations_usage):
+            self.translations_usage = ServiceUsage.LAUNCHPAD
+        if service_uses_launchpad(IServiceUsage(pillar).codehosting_usage):
+            self.codehosting_usage = ServiceUsage.LAUNCHPAD
 
     @property
     def has_involvement(self):
         """This `IPillar` uses Launchpad."""
-        return (
-            self.official_malone or self.official_answers
-            or self.official_blueprints
+        return (self.official_malone
+            or service_uses_launchpad(self.answers_usage)
+            or service_uses_launchpad(self.blueprints_usage)
             or service_uses_launchpad(self.translations_usage)
             or service_uses_launchpad(self.codehosting_usage))
 

=== modified file 'lib/lp/registry/browser/productseries.py'
--- lib/lp/registry/browser/productseries.py	2010-09-03 15:02:39 +0000
+++ lib/lp/registry/browser/productseries.py	2010-09-10 13:32:47 +0000
@@ -254,11 +254,11 @@
 
     def __init__(self, context, request):
         super(ProductSeriesInvolvementView, self).__init__(context, request)
+        self.answers_usage = ServiceUsage.NOT_APPLICABLE
         if self.context.branch is not None:
             self.codehosting_usage = ServiceUsage.LAUNCHPAD
         else:
             self.codehosting_usage = ServiceUsage.UNKNOWN
-        self.official_answers = False
 
     @property
     def configuration_links(self):

=== modified file 'lib/lp/registry/browser/tests/distribution-views.txt'
--- lib/lp/registry/browser/tests/distribution-views.txt	2010-08-30 18:26:19 +0000
+++ lib/lp/registry/browser/tests/distribution-views.txt	2010-09-10 13:32:47 +0000
@@ -274,11 +274,12 @@
 If the distribution officially uses the application, its portlet does appear.
 
     >>> from canonical.testing.layers import MemcachedLayer
+    >>> from lp.app.enums import ServiceUsage
 
     # When the cache regenerated, all users will see the change.
     >>> MemcachedLayer.purge()
-    >>> distribution.official_answers = True
-    >>> distribution.official_blueprints = True
+    >>> distribution.answers_usage = ServiceUsage.LAUNCHPAD
+    >>> distribution.blueprints_usage = ServiceUsage.LAUNCHPAD
     >>> distribution.official_malone = True
 
     >>> view = create_view(distribution, name='+index', principal=owner)

=== modified file 'lib/lp/registry/browser/tests/pillar-views.txt'
--- lib/lp/registry/browser/tests/pillar-views.txt	2010-09-01 22:59:30 +0000
+++ lib/lp/registry/browser/tests/pillar-views.txt	2010-09-10 13:32:47 +0000
@@ -24,7 +24,8 @@
 
 Pillars that do use launchpad applications have an involvement menu.
 
-    >>> distribution.official_answers = True
+    >>> from lp.app.enums import ServiceUsage
+    >>> distribution.answers_usage = ServiceUsage.LAUNCHPAD
     >>> distribution.official_malone = True
     >>> view = create_view(
     ...     distribution, '+get-involved', principal=distribution.owner)
@@ -33,14 +34,14 @@
 
     >>> view.official_malone
     True
-    >>> view.official_answers
-    True
+    >>> print view.answers_usage.name
+    LAUNCHPAD
     >>> view.translations_usage.name
     'UNKNOWN'
-    >>> view.official_blueprints
-    False
-    >>> view.codehosting_usage.name
-    'NOT_APPLICABLE'
+    >>> print view.blueprints_usage.name
+    UNKNOWN
+    >>> print view.codehosting_usage.name
+    UNKNOWN
 
 The view provides a list of enabled links that is rendered by the template.
 
@@ -65,10 +66,10 @@
 
     >>> product = factory.makeProduct(name='bread')
     >>> login_person(product.owner)
-    >>> product.official_blueprints = True
+    >>> product.blueprints_usage = ServiceUsage.LAUNCHPAD
     >>> view = create_view(product, '+get-involved')
-    >>> view.official_blueprints
-    True
+    >>> print view.blueprints_usage.name
+    LAUNCHPAD
     >>> for link in view.enabled_links:
     ...     print link.name
     register_blueprint
@@ -114,7 +115,6 @@
 
 Changing the product's usage is reflected in the view properties.
 
-    >>> from lp.app.enums import ServiceUsage
     >>> product.translations_usage = ServiceUsage.LAUNCHPAD
     >>> view = create_view(product, '+get-involved')
     >>> for key in sorted(view.configuration_states.keys()):
@@ -189,8 +189,8 @@
     >>> product.project = project_group
 
     >>> view = create_view(project_group, '+get-involved')
-    >>> view.official_blueprints
-    True
+    >>> print view.blueprints_usage.name
+    LAUNCHPAD
 
 The offical_codehosting for a project is based on whether the project's
 development focus series has a branch.
@@ -200,23 +200,23 @@
     >>> product.official_codehosting
     False
     >>> view = create_view(product, '+get-involved')
-    >>> view.codehosting_usage.name
-    'UNKNOWN'
+    >>> print view.codehosting_usage.name
+    UNKNOWN
 
     >>> product.development_focus.branch = factory.makeBranch(
     ...     product=product)
     >>> product.official_codehosting
     True
     >>> view = create_view(product, '+get-involved')
-    >>> view.codehosting_usage.name
-    'LAUNCHPAD' 
+    >>> print view.codehosting_usage.name
+    LAUNCHPAD
 
 Project groups cannot make links to register a branch, so
 official_codehosting is always false.
 
     >>> view = create_view(project_group, '+get-involved')
-    >>> view.codehosting_usage.name
-    'NOT_APPLICABLE'
+    >>> print view.codehosting_usage.name
+    NOT_APPLICABLE
 
 DistroSeries can use this view. The distribution is used to set the links.
 
@@ -232,7 +232,7 @@
 
     >>> from lp.app.enums import ServiceUsage
     >>> login_person(distribution.owner)
-    >>> distribution.official_blueprints = True
+    >>> distribution.blueprints_usage = ServiceUsage.LAUNCHPAD
     >>> distribution.translations_usage = ServiceUsage.LAUNCHPAD
     >>> package = factory.makeDistributionSourcePackage(
     ...     sourcepackagename="box",

=== modified file 'lib/lp/registry/browser/tests/product-views.txt'
--- lib/lp/registry/browser/tests/product-views.txt	2010-08-16 19:28:37 +0000
+++ lib/lp/registry/browser/tests/product-views.txt	2010-09-10 13:32:47 +0000
@@ -482,8 +482,9 @@
 The portlet are rendered when a product officially uses the Launchpad
 Answers, Blueprints, and Bugs applications.
 
-    >>> product.official_answers = True
-    >>> product.official_blueprints = True
+    >>> from lp.app.enums import ServiceUsage
+    >>> product.answers_usage = ServiceUsage.LAUNCHPAD
+    >>> product.blueprints_usage = ServiceUsage.LAUNCHPAD
     >>> product.official_malone = True
 
     >>> view = create_initialized_view(

=== modified file 'lib/lp/registry/browser/tests/productseries-views.txt'
--- lib/lp/registry/browser/tests/productseries-views.txt	2010-09-09 15:26:11 +0000
+++ lib/lp/registry/browser/tests/productseries-views.txt	2010-09-10 13:32:47 +0000
@@ -25,17 +25,17 @@
 
     >>> from lp.app.enums import ServiceUsage
     >>> login_person(product.owner)
-    >>> product.official_answers = True
-    >>> product.official_blueprints = True
+    >>> product.answers_usage = ServiceUsage.LAUNCHPAD
+    >>> product.blueprints_usage = ServiceUsage.LAUNCHPAD
     >>> product.official_malone = True
     >>> product.translations_usage = ServiceUsage.LAUNCHPAD
     >>> view = create_view(series, '+get-involved')
 
-    # official_answers is always false for product series.
-    >>> print view.official_answers
-    False
-    >>> print view.official_blueprints
-    True
+    # answers_usage is never LAUNCHPAD for product series.
+    >>> print view.answers_usage.name
+    NOT_APPLICABLE
+    >>> print view.blueprints_usage.name
+    LAUNCHPAD
     >>> print view.official_malone
     True
     >>> print view.translations_usage.name

=== modified file 'lib/lp/registry/browser/tests/projectgroup-views.txt'
--- lib/lp/registry/browser/tests/projectgroup-views.txt	2009-08-31 20:46:06 +0000
+++ lib/lp/registry/browser/tests/projectgroup-views.txt	2010-09-10 13:32:47 +0000
@@ -71,12 +71,14 @@
 The portlet are rendered when a child product officially uses the Launchpad
 Answers, Blueprints, and Bugs applications.
 
-    >>> product.official_answers = True
-    >>> product.official_blueprints = True
+    >>> from lp.app.enums import ServiceUsage
+    >>> product.answers_usage = ServiceUsage.LAUNCHPAD
+    >>> product.blueprints_usage = ServiceUsage.LAUNCHPAD
     >>> product.official_malone = True
 
     >>> view = create_view(projectgroup, name='+index', principal=owner)
     >>> content = find_tag_by_id(view.render(), 'maincontent')
+
     >>> print find_tag_by_id(content, 'portlet-latest-faqs')['id']
     portlet-latest-faqs
     >>> print find_tag_by_id(content, 'portlet-latest-questions')['id']

=== modified file 'lib/lp/registry/doc/distribution.txt'
--- lib/lp/registry/doc/distribution.txt	2010-08-31 23:03:45 +0000
+++ lib/lp/registry/doc/distribution.txt	2010-09-10 13:32:47 +0000
@@ -392,12 +392,12 @@
     >>> ubuntu = getUtility(ILaunchpadCelebrities).ubuntu
     >>> ubuntu.official_malone
     True
-    >>> ubuntu.translations_usage.name
-    'LAUNCHPAD'
-    >>> ubuntu.official_answers
-    True
-    >>> ubuntu.official_blueprints
-    True
+    >>> print ubuntu.answers_usage.name
+    LAUNCHPAD
+    >>> print ubuntu.blueprints_usage.name
+    LAUNCHPAD
+    >>> print ubuntu.translations_usage.name
+    LAUNCHPAD
 
 The bug_tracking_usage property currently only tracks official_malone.
 
@@ -462,11 +462,12 @@
 
 Launchpad admins and the distro owner can set these fields.
 
+    >>> from lp.app.enums import ServiceUsage
     >>> login('[e-mail]')
     >>> debian = getUtility(ILaunchpadCelebrities).debian
-    >>> debian.official_blueprints = True
-    >>> debian.official_blueprints
-    True
+    >>> debian.blueprints_usage = ServiceUsage.LAUNCHPAD
+    >>> print debian.blueprints_usage.name
+    LAUNCHPAD
     >>> debian.official_malone = True
     >>> debian.official_malone
     True
@@ -477,16 +478,16 @@
     >>> debian_owner = factory.makePerson()
     >>> debian.owner = debian_owner
     >>> login_person(debian_owner)
-    >>> debian.official_blueprints = False
-    >>> debian.official_blueprints
-    False
+    >>> debian.blueprints_usage = ServiceUsage.NOT_APPLICABLE
+    >>> print debian.blueprints_usage.name
+    NOT_APPLICABLE
 
 But others can't.
 
     >>> login('[e-mail]')
-    >>> debian.official_blueprints = True
+    >>> debian.blueprints_usage = ServiceUsage.LAUNCHPAD
     Traceback (most recent call last):
-    Unauthorized: (..., 'official_blueprints', 'launchpad.Edit')
+    Unauthorized: (..., 'blueprints_usage', 'launchpad.Edit')
     >>> debian.official_malone = True
     Traceback (most recent call last):
     Unauthorized: (..., 'official_malone', 'launchpad.Edit')

=== modified file 'lib/lp/registry/doc/product.txt'
--- lib/lp/registry/doc/product.txt	2010-09-03 13:29:58 +0000
+++ lib/lp/registry/doc/product.txt	2010-09-10 13:32:47 +0000
@@ -316,14 +316,13 @@
 Firefox uses the Answer Tracker as the official application to provide
 answers to questions.
 
-    >>> firefox.official_answers
-    True
+    >>> print firefox.answers_usage.name
+    LAUNCHPAD
 
 Alsa does not use Launchpad to track answers.
 
-    >>> alsa.official_answers
-    False
-
+    >>> print alsa.answers_usage.name
+    UNKNOWN
 
 Product Creation
 ----------------
@@ -383,17 +382,18 @@
 ----------------------
 
 We should be able to set whether or not a Product uses specifications
-officially.  It defaults to False.
+officially.  It defaults to UNKNOWN.
 
     >>> firefox = productset.getByName('firefox')
-    >>> firefox.official_blueprints
-    False
-
-We can change it to True.
-
-    >>> firefox.official_blueprints = True
-    >>> firefox.official_blueprints
-    True
+    >>> print firefox.blueprints_usage.name
+    UNKNOWN
+
+We can change it to use LAUNCHPAD.
+
+    >>> from lp.app.enums import ServiceUsage
+    >>> firefox.blueprints_usage = ServiceUsage.LAUNCHPAD
+    >>> print firefox.blueprints_usage.name
+    LAUNCHPAD
 
 We should be able to get lists of specifications in different states
 related to a product.

=== modified file 'lib/lp/registry/templates/distribution-index.pt'
--- lib/lp/registry/templates/distribution-index.pt	2010-08-24 20:11:37 +0000
+++ lib/lp/registry/templates/distribution-index.pt	2010-09-10 13:32:47 +0000
@@ -52,7 +52,7 @@
       <div class="yui-g">
         <div class="yui-u first">
           <div tal:replace="structure context/@@+portlet-listfaqs"
-            tal:condition="context/official_answers" />
+            tal:condition="context/answers_usage/enumvalue:LAUNCHPAD" />
 
           <div tal:replace="structure context/@@+portlet-latestbugs"
             tal:condition="context/bug_tracking_usage/enumvalue:LAUNCHPAD" />
@@ -62,10 +62,10 @@
 
         <div class="yui-u">
           <div tal:replace="structure context/@@+portlet-latestquestions"
-            tal:condition="context/official_answers" />
+            tal:condition="context/answers_usage/enumvalue:LAUNCHPAD" />
 
           <div tal:replace="structure context/@@+portlet-latestspecs"
-            tal:condition="context/official_blueprints" />
+            tal:condition="context/blueprints_usage/enumvalue:LAUNCHPAD" />
 
           <div tal:replace="structure context/@@+portlet-coming-sprints" />
         </div>

=== modified file 'lib/lp/registry/templates/distribution-search.pt'
--- lib/lp/registry/templates/distribution-search.pt	2010-08-24 20:11:37 +0000
+++ lib/lp/registry/templates/distribution-search.pt	2010-09-10 13:32:47 +0000
@@ -77,7 +77,7 @@
                     </a>
                     <a
                       tal:define="link package/menu:answers/new"
-                      tal:condition="distribution/official_answers"
+                      tal:condition="distribution/answers_usage/enumvalue:LAUNCHPAD"
                       tal:attributes="href link/url">
                     <img
                       tal:attributes="alt link/text"
@@ -137,7 +137,7 @@
                       condition="binary_names"
                       content="string:(Matching binaries: ${binary_names}.)">
                       (Matching binaries: bin-one, bin-two.)
-                    </tal:matching-binaries> 
+                    </tal:matching-binaries>
                   </tal:binary-search-only>
                   </p>
                 </div>

=== modified file 'lib/lp/registry/templates/distroseries-index.pt'
--- lib/lp/registry/templates/distroseries-index.pt	2010-08-25 16:18:24 +0000
+++ lib/lp/registry/templates/distroseries-index.pt	2010-09-10 13:32:47 +0000
@@ -83,7 +83,8 @@
 
           <div
             tal:content="structure context/@@+portlet-latestspecs"
-            tal:condition="context/@@+get-involved/official_blueprints" />
+            tal:define="blueprints_usage context/@@+get-involved/blueprints_usage"
+            condition="blueprints_usage/enumvalue:LAUNCHPAD" />
 
           <div
            tal:replace="structure context/distribution/@@+portlet-coming-sprints" />

=== modified file 'lib/lp/registry/templates/product-index.pt'
--- lib/lp/registry/templates/product-index.pt	2010-08-26 17:25:46 +0000
+++ lib/lp/registry/templates/product-index.pt	2010-09-10 13:32:47 +0000
@@ -215,7 +215,7 @@
       <div class="yui-g">
         <div class="yui-u first">
           <div tal:content="structure context/@@+portlet-listfaqs"
-            tal:condition="context/official_answers" />
+            tal:condition="context/answers_usage/enumvalue:LAUNCHPAD" />
 
           <div tal:content="structure context/@@+portlet-latestbugs"
             tal:condition="context/bug_tracking_usage/enumvalue:LAUNCHPAD" />
@@ -227,10 +227,10 @@
 
         <div class="yui-u">
           <div tal:content="structure context/@@+portlet-latestquestions"
-            tal:condition="context/official_answers" />
+            tal:condition="context/answers_usage/enumvalue:LAUNCHPAD" />
 
           <div tal:content="structure context/@@+portlet-latestspecs"
-            tal:condition="context/official_blueprints" />
+            tal:condition="context/blueprints_usage/enumvalue:LAUNCHPAD" />
 
           <div tal:content="structure context/@@+portlet-coming-sprints" />
         </div>

=== modified file 'lib/lp/registry/templates/productseries-index.pt'
--- lib/lp/registry/templates/productseries-index.pt	2010-08-25 15:24:48 +0000
+++ lib/lp/registry/templates/productseries-index.pt	2010-09-10 13:32:47 +0000
@@ -145,7 +145,7 @@
         <div class="yui-u">
           <div
             tal:content="structure context/@@+portlet-latestspecs"
-            tal:condition="context/@@+get-involved/official_blueprints" />
+            tal:condition="context/@@+get-involved/blueprints_usage/enumvalue:LAUNCHPAD" />
 
           <div tal:replace="structure context/product/@@+portlet-coming-sprints" />
 

=== modified file 'lib/lp/registry/templates/project-index.pt'
--- lib/lp/registry/templates/project-index.pt	2010-08-25 15:37:37 +0000
+++ lib/lp/registry/templates/project-index.pt	2010-09-10 13:32:47 +0000
@@ -72,11 +72,11 @@
         <tal:details replace="structure context/@@+details" />
 
         <tal:faqs content="structure context/@@+portlet-listfaqs"
-          condition="context/@@+get-involved/official_answers" />
+          condition="context/@@+get-involved/answers_usage/enumvalue:LAUNCHPAD" />
 
         <tal:has-many-project condition="view/has_many_projects">
           <tal:questions content="structure context/@@+portlet-latestquestions"
-            condition="context/@@+get-involved/official_answers" />
+            condition="context/@@+get-involved/answers_usage/enumvalue:LAUNCHPAD" />
         </tal:has-many-project>
 
         <tal:bugs content="structure context/@@+portlet-latestbugs"
@@ -84,7 +84,7 @@
 
         <tal:has-many-project condition="view/has_many_projects">
           <tal:specs content="structure context/@@+portlet-latestspecs"
-            condition="context/@@+get-involved/official_blueprints" />
+            condition="context/@@+get-involved/blueprints_usage/enumvalue:LAUNCHPAD" />
         </tal:has-many-project>
 
         <tal:contributors content="structure context/@@+portlet-top-contributors"/>
@@ -119,10 +119,10 @@
 
         <tal:has-few-project condition="not: view/has_many_projects">
           <tal:questions content="structure context/@@+portlet-latestquestions"
-            condition="context/@@+get-involved/official_answers" />
+            condition="context/@@+get-involved/answers_usage/enumvalue:LAUNCHPAD" />
 
           <tal:specs content="structure context/@@+portlet-latestspecs"
-            condition="context/@@+get-involved/official_blueprints" />
+            condition="context/@@+get-involved/blueprints_usage/enumvalue:LAUNCHPAD" />
 
           <tal:sprints content="structure context/@@+portlet-coming-sprints" />
         </tal:has-few-project>