add FLASH_KERNEL_SKIP=yes hook - flash-kernel breaks update-initramfs in chroot on archs that dont need flash-kernel.conf

Bug #623276 reported by Alexander Sack
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
flash-kernel (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Binary package hint: flash-kernel

on omap:

debootstrap
mount proc
apt-get install flash-kernel
apt-get install linux-image-omap

dies because flash-kernel tries to flash the kernel when there is no flash-kernel.conf and there is no way to prevent this.

one idea would be to make flash-kernel exit 0 when FLASH_KERNEL_SKIP=yes is set in env.

Alexander Sack (asac)
tags: added: armel linaro
Changed in flash-kernel (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Alexander Sack (asac) wrote :

quick patch for this

Alexander Sack (asac)
Changed in flash-kernel (Ubuntu):
status: New → Confirmed
Revision history for this message
Alexander Sack (asac) wrote :

don't touch the semantics of --supported ... do the SKIP check after that block.

Revision history for this message
Alexander Sack (asac) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package flash-kernel - 2.28ubuntu6

---------------
flash-kernel (2.28ubuntu6) maverick; urgency=low

  * skip flash-kernel with exit 0 if FLASH_KERNEL_SKIP env is set; in turn
    make --supported fail with exit 1 if FLASH_KERNEL_SKIP is set (LP: #623276)
 -- Alexander Sack <email address hidden> Tue, 24 Aug 2010 12:58:10 +0200

Changed in flash-kernel (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Loïc Minier (lool) wrote :

To me it sounds like the wrong place to have this knob; it should be in the kernel packages. We could have a config file and tweak it, or we could indeed have an env var.

Would you consider another way: diverting flash-kernel with a noop script (or /bin/true) while installing kernels? That seems less ugly for flash-kernel to me.

Revision history for this message
Tom Gall (tom-gall) wrote :

brass knobs aside, as currently implemented in flash-kernel it's an error when /proc isn't available for whatever reason. As Loïc Minier suggests I agree it seems like users of flash-kernel shouldn't be calling it if the system isn't ready.

Revision history for this message
Oliver Grawert (ogra) wrote :

if you dont have /proc mounted during package install in a chroot you will also have plenty of other problems :)

Revision history for this message
Loïc Minier (lool) wrote :
tags: added: patch
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.