SSOCredentials signals must always pass the app_name
Bug #621377 reported by
Natalia Bidart
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Single Sign On Client |
Fix Released
|
High
|
Alejandro J. Cura | ||
| ubuntu-sso-client (Ubuntu) |
Fix Released
|
High
|
Ubuntu One Client Engineering team | ||
Bug Description
Signals
AuthorizationDe
CredentialsFoun
CredentialsErro
must pass the app_name to the caller, so it can check if the signal corresponds to its dbus call.
The app_name must be provided in the GTK signals as well, and so the error if any.
Related branches
lp:~alecu/ubuntu-sso-client/properly-return-errors
- Natalia Bidart (community): Approve
- Rodrigo Moya (community): Approve
-
Diff: 549 lines (+171/-69)4 files modifiedubuntu_sso/gui.py (+7/-7)
ubuntu_sso/main.py (+46/-33)
ubuntu_sso/tests/test_gui.py (+5/-5)
ubuntu_sso/tests/test_main.py (+113/-24)
lp:~nataliabidart/ubuntu-sso-client/ping-server
- Rodrigo Moya (community): Approve
- John Lenton (community): Approve
-
Diff: 1406 lines (+311/-224)4 files modifiedubuntu_sso/gui.py (+57/-46)
ubuntu_sso/main.py (+80/-69)
ubuntu_sso/tests/test_gui.py (+46/-44)
ubuntu_sso/tests/test_main.py (+128/-65)
| Changed in ubuntu-sso-client: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| assignee: | nobody → Naty Bidart (nataliabidart) |
| Changed in ubuntu-sso-client (Ubuntu): | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| importance: | Medium → High |
| assignee: | nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+) |
| milestone: | none → ubuntu-10.10-beta |
| tags: | added: desktop+ u1-maverick |
| Changed in ubuntu-sso-client: | |
| assignee: | Naty Bidart (nataliabidart) → Alejandro J. Cura (alecu) |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Alejandro J. Cura (alecu) wrote | #1 |
| Changed in ubuntu-sso-client: | |
| status: | Fix Committed → In Progress |
| Changed in ubuntu-sso-client: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in ubuntu-sso-client (Ubuntu): | |
| status: | Triaged → Fix Released |
| Changed in ubuntu-sso-client: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This problem means that two programs that use this service at the same time won't be able to tell who the signal was sent for.
In order to avoid this we need to add the app_name as an argument to all these signals so the users of this service can tell the signals apart.
Right now this service is used by Ubuntu One and the Software Center, so it may make sense to do this change before more programs start using it.