Please update the package to 2.1.1

Bug #592538 reported by Bhavani Shankar
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
rhythmbox-radio-browser (Ubuntu)
Fix Released
Undecided
Evan Broder

Bug Description

Binary package hint: rhythmbox-radio-browser

There is a new upstream version available and the package needs to be updated

Revision history for this message
segler (segler-alex) wrote :

i packaged the current version 2.1.3

Revision history for this message
segler (segler-alex) wrote :

Please ignore these lintian warnings, the image files are needed exactly at this place:

W: rhythmbox-radio-browser: image-file-in-usr-lib usr/lib/rhythmbox/plugins/radio-browser/local-logo.png
W: rhythmbox-radio-browser: image-file-in-usr-lib usr/lib/rhythmbox/plugins/radio-browser/note.png
W: rhythmbox-radio-browser: image-file-in-usr-lib usr/lib/rhythmbox/plugins/radio-browser/radio-browser.png
W: rhythmbox-radio-browser: image-file-in-usr-lib usr/lib/rhythmbox/plugins/radio-browser/shoutcast-logo.png
W: rhythmbox-radio-browser: image-file-in-usr-lib usr/lib/rhythmbox/plugins/radio-browser/xiph-logo.png

rhythmbox cannot load them if they are elsewhere. if you do not believe me look at the package: "rhythmbox-ubuntuone-music-store". they do the same. its rhythmbox's fault not mine ;)

Revision history for this message
segler (segler-alex) wrote :

sorry, i meant "i packaged the version 2.3.1 not 2.1.3" these numbers ;)

Revision history for this message
segler (segler-alex) wrote :

hmmm, yes this is a patch

Revision history for this message
segler (segler-alex) wrote :

would it be possible to upgrade the package in maverick too?
my uploaded package is for natty but it would be nicer to have it in maverick too.

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Thanks for the package...but...why did you clear out the changelog, and why did you change from debhelper to cdbs?

Changed in rhythmbox-radio-browser (Ubuntu):
assignee: nobody → Marc Deslauriers (mdeslaur)
status: New → Confirmed
Revision history for this message
segler (segler-alex) wrote :

i did it the same way i do it for the ppa, i copied the things from there. i think i changed to cdbs because some tutorial told me to, so i can use stuff like this file: "rhythmbox-radio-browser.gconf-defaults"

Revision history for this message
Michael Casadevall (mcasadevall) wrote :

Hi segler,

First off, thank you for your work on this patch but it is unacceptable for sponsorship into the archive. It has large invasive changes that are not justified (changing the build system and deleting most of the changelog). As such, I'm removing this patch from the sponsorship queue.

As a guide, the Ubuntu Packaging Guide is available here: https://wiki.ubuntu.com/PackagingGuide/Complete, and it contains good information on how to create and update new packages.

As for some handy tips, typing 'dch -i' in the base of the source directory will create a new changelog entry. It shouldn't be necessary to fiddle too much with debian/rules if the package has not changed much.
Michael

Revision history for this message
segler (segler-alex) wrote :

another attempt :)
i did nothing invasive only followed this "https://wiki.ubuntu.com/PackagingGuide/Complete#Updating%20an%20Ubuntu%20Package" now:

apt-get source rhythmbox-radio-browser
cd rhythmbox-radio-browser-2.0
uscan
uupdate ../rhythmbox-radio-browser_2.3.1.orig.tar.gz
cd ../rhythmbox-radio-browser-2.3.1
dch -e
debuild -S -sa

and i changed "segler_alex" to my real name in control and copyright file
hope that is all ok
please have another look at it
but i did not find anything on installing the gconf.defaults file

Revision history for this message
segler (segler-alex) wrote :

oh yes, i forgot to mention that i removed the old patches, because they are not needed anymore

Revision history for this message
Micah Gersten (micahg) wrote :

Bug #676620 should probably be addressed at the same time as this bug

Revision history for this message
segler (segler-alex) wrote :

this version (2.3.1) i uploaded, already uses the new server

Revision history for this message
segler (segler-alex) wrote :

if it is possible to get this package into lucid too, the other bug can be discarded. but i don't know if this would be possible

Revision history for this message
Michael Terry (mterry) wrote :

segler, thanks for the work! A few things though before it can be pushed in:

 * I think maybe you uploaded the wrong debian.tar.gz? Looks like you uploaded the 2.0 one, not the 2.3.1 one.

 * Make sure you have the Maintainer field in debian/control be "Ubuntu Developers <email address hidden>". That's the Maintainer in Ubuntu/Debian, not the upstream maintainer, and we all share responsibility. The update-maintainer script should be abler to do this for you.

 * It's a tad easier if you upload a debdiff instead of the tarball. After your last step there, where you ran debuild -S, also run 'debdiff > /tmp/debdiff' and upload /tmp/debdiff to this bug.

I'm removing sponsors right now, since there's nothing to do (seems the wrong patch was uploaded). Upload the right one and subscribe ubuntu-sponsors again to have it reviewed. Thank you!

Revision history for this message
Michael Terry (mterry) wrote :

Oh, and about the radio server and Lucid. A whole new upstream version is likely too intrusive for an SRU (stable release update). Bug 676620 should remain open and once this new version is pushed into natty, the other bug can be used for the process of getting an SRU to previous versions. See https://wiki.ubuntu.com/StableReleaseUpdates for details.

Revision history for this message
segler (segler-alex) wrote :

thank you for your help.
here is my next attempt :)

Evan Broder (broder)
Changed in rhythmbox-radio-browser (Ubuntu):
status: Confirmed → In Progress
assignee: Marc Deslauriers (mdeslaur) → Evan Broder (broder)
Revision history for this message
Evan Broder (broder) wrote :

I've reworked this patch and uploaded it to Natty. I'll follow up on bug #676620 about an SRU for changing Lucid and Maverick to use the new server.

segler, a few tips for future reference:

 * debdiffs should generally be made against the current development release (i.e. natty, right now), with the exception of SRUs (which should happen after you get fixes into the development release anyway). Your debdiff was against the version of rhythmbox-radio-browser in Lucid, and was also targeted to Lucid (based on the changelog)

 * It looks like you had a version of rhythmbox-radio-browser unpacked in your source tree or something when you ran debuild -S:

mingo:~ evan$ curl -s http://launchpadlibrarian.net/59560558/rhythmbox-radio-browser_2.3.1-0ubuntu1.debdiff | diffstat
[...]
 debian/patches/debian-changes-2.3.1-0ubuntu1 | 2893 +++++++++++++++++++++++++++

 * I also expanded your changelog entry to clarify the changes that were made. In general, if you're dropping patches that are carried in the package, it's good to indicate why you're doing so.

I've attached the debdiff as I uploaded it for reference. Thanks again for working with us up to this point.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package rhythmbox-radio-browser - 2.3.1-0ubuntu1

---------------
rhythmbox-radio-browser (2.3.1-0ubuntu1) natty; urgency=low

  [ Alexander Murauer ]
  * New upstream release (LP: #592538).
    - Switches to new server (LP: #676620).
  * Dropped patches which have been incorporated upstream:
    - debian/patches/rhythmdbentrytype.diff
    - debian/patches/recording_streams_segfault.diff
    - debian/patches/actiongroup_segfault.diff
    - debian/patches/invalid_play.diff
 -- Evan Broder <email address hidden> Fri, 26 Nov 2010 00:03:05 -0800

Changed in rhythmbox-radio-browser (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.