Feeds applet should use ngettext

Bug #592315 reported by Gabor Karsay
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Awn Extras
Fix Released
Undecided
Matt

Bug Description

If preparing plural strings for translation, it's best to use ngettext because other solutions are mostly not translatable.

In Feeds applet, feeds.py, line 492 (trunk, revision 1318) is not translatable in almost any language.

The 2 messages beginning at line 1157 are not translatable into languages with more than 2 plural forms. I think here is also a mistake with the counting. I think it should start with 1 and not with 0. If there's nothing to be imported, there should be a message to the user about that.

Unfortunately I'm not that good at Python, I would probably mess things up. But there is an example of how to use ngettext in the Mail applet, in line 37 of mail.py.

Tags: applet feeds

Related branches

Matt (mjz)
Changed in awn-extras:
status: New → Confirmed
assignee: nobody → Matt (mjz)
onox (onox)
tags: added: applet feeds
Revision history for this message
Matt (mjz) wrote :

This has been fixed in r1330. Thank you for your bug report.

Changed in awn-extras:
status: Confirmed → Fix Committed
Matt (mjz)
Changed in awn-extras:
milestone: none → 0.4.2
Revision history for this message
Gabor Karsay (gabor-karsay) wrote :

Thank you very much! Please update the translation template, too, so that translators can benefit from the changes. We like updated translation templates with every added, removed or changed string.

I guess you want also to include the indicator applet's strings, so please add its files to po/POTFILES.in before doing intltool-update --pot. Thanks again for this and the other fixes!

Povilas Kanapickas (p12)
Changed in awn-extras:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.