Inkscape

decimal point issues ?

Bug #586104 reported by v1nce
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
jazzynico
Inkscape 0.91 "0.91"

Bug Description

After bug 586063

I looked for %f into the sources and find there could be some other files with decimal problem.

Fixed:
extension/internal/grid.cpp
extension/internal/filter/drop-shadow.h (now in shadows.h)
extension/internal/filter/snow.h (now in protrusions.h)
2geom/chebyshev.cpp (file removed from 2geom)

Not affected:
live_effects/lpe-path_length.cpp:58 (the value is written on the canvas)
libavoid/router.cpp:1164 (warning text)
extension/internal/pdfinput/pdf-parser.cpp:298 (message text)
extension/internal/odf.cpp:1371 (generated ODG file not affected)

TODO (line number from revision 11535):
ui/dialog/input.cpp:1413,1432 (will test later)
dom/xpathparser.h:311 (don't know how to test it?)

See original description
Tags: precision
Revision history for this message
v1nce (vincent-pennec) wrote :

xpathparser.h :
printf("#%f\n", dval);

snow.h, drop-shadow.h :
g_strdup_printf(...%f

Revision history for this message
jazzynico (jazzynico) wrote :

drop-shadow.h, grid.cpp and snow.h fixed in bzr revision 9456 (see Bug #586063).

Changed in inkscape:
assignee: nobody → JazzyNico (jazzynico)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
ScislaC (scislac) wrote :

JazzyNico: Are you still working on this?

Revision history for this message
jazzynico (jazzynico) wrote :

@ScislaC: I'm going to take a look at the other pointed files to see if it's still relevant (I don't remember why I didn't fix it before, but I guess it's because it's not as obvious as it seems).

jazzynico (jazzynico)
description: updated
Revision history for this message
jazzynico (jazzynico) wrote :

Most files are not affected.
The input dialog and xpathparser still need to be tested, but I have no idea where the latter is used in inkscape. Any clue?

description: updated
John Smith (john-smithi)
tags: added: precision
Martin Owens (doctormo)
Changed in inkscape:
status: In Progress → Confirmed
Revision history for this message
jazzynico (jazzynico) wrote :

The input dialog no longer uses that part of the code, and the dom directory was removed revision 13107.
Nothing left to test apparently.

Changed in inkscape:
milestone: none → 0.91
status: Confirmed → Fix Committed
jazzynico (jazzynico)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.