PANIC save/autosave Lua API

I've encountered the same or similar crashes when running under Ubuntu 9.10, most notably when hosting a multi-player game with 3-4 AI players.

This is a heisebug I am very eager to kill. I've seen it a few times before and I found one way to trigger it and fixes it in r5288. Please try with this revision.

Also, I would be most graceful to know a way to reproduce this; maybe a savegame shortly before it happens could also help.

I found the problem with this. The pairs() and ipairs() functions return a c closure that continues the iteration. As there is a sleep() inside the for iteration, the save will always occur while we are inside the iteration. short code to reproduce the crash:

function blah()
  for i,v in ipairs{1} do sleep(300) end
end

this will crash at any save. I currently do not see a way around this besides reimplementing pairs() and ipairs() in pure lua (which I am not sure if this works) and overriding the default c functions or adding a warning to the documentations (very risky) or completely disabling ipairs and pairs (which suckz, because iterating an array becomes difficult, iterating a dictionary practically impossible).

Fixed this sucker in a portable and clear way. I had to special case ipairs() and pairs() in the persistence process, but as we only support lua 5.1 at the moment this is not tragic.

I very much enjoyed this debug over two languages. I also vaded through the lua library source code which is very pleasant and straightforward to read.

However, please try again with latest revision.

Ok I will pull code tonight again compile and post results.. glad you had
fun tracking it down

On May 3, 2010 2:16 PM, "SirVer" <email address hidden> wrote:

Fixed this sucker in a portable and clear way. I had to special case
ipairs() and pairs() in the persistence process, but as we only support
lua 5.1 at the moment this is not tragic.

I very much enjoyed this debug over two languages. I also vaded through
the lua library source code which is very pleasant and straightforward
to read.

However, please try again with latest revision.

** Changed in: widelands
      Status: Confirmed => Fix Committed

--
PANIC save/autosave Lua API
https://bugs.launchpad.net/bugs/573178
You received this bug notifi...
Status in Widelands: Fix Committed

Bug description:
bzr5285 ./build_and_run.sh
ubuntu 64 lucid
single player
Map : Comet Island
Game ...

Build r5296 (never could get 5288 to pull) build and ran fine on ubuntu 64 lucid ./build_and_run.sh

single player game
map: Comet Island
Game Type: Tribes together
manual save worked and auto-save worked
for me issue resolved thank you very much... [will work on your 500,000 in small unmarked paypal transactions ;)]
great game...

Released in build16-rc1