Wrong language-selector package blacklisted

Bug #570240 reported by Gabor Kelemen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pkgbinarymangler (Ubuntu)
Fix Released
Low
Martin Pitt

Bug Description

Binary package hint: pkgbinarymangler

The blacklist file:
http://bazaar.launchpad.net/~ubuntu-core-dev/pkgbinarymangler/ubuntu/annotate/head%3A/striptranslations.blacklist
contains an entry to language-selector. When building the package however, translations are put into the language-selector-common package, and then removed: http://packages.ubuntu.com/lucid/all/language-selector-common/filelist
This makes language-selector appear untranslated on the live CD. I don't know if this is desirable or not - after all, this must be broken at least since Dapper, and no one is complaining - but if not, I suggest changing this line to language-selector-common, otherwise it can be dropped.

Revision history for this message
David Planella (dpm) wrote :

Just a quick note after having talked to Gabor on IRC: it seems that at least gnome-language-selector is indeed translated on the LiveCD. Tested it with Spanish on the 10.04 LTS RC LiveCD

Revision history for this message
Gabor Kelemen (kelemeng) wrote :

Also:
(17.48.43) dpm: ahhh, now I understand the question... It seems I'm a bit slow today
(17.48.49) dpm: ok, here's my take
(17.49.42) dpm: in short, if you want to change language on the LiveCD, you can't, so I don't think g-l-s should be translated in the Live CD until there is a way to change language. With that I mean:
(17.50.41) dpm: if you try to switch between languages included in the LiveCD you can't, because you have to log out and back in, with the corresponding loss of settings
(17.51.13) dpm: if you try to install a new language, you can't, since you get a "insufficient space on device" error
(17.51.37) dpm: That said, I haven't checked it with USB creator and a permanent home dir
(17.51.45) danilos: dpm, maybe you can remove Spanish first and then install another language? :)
(17.51.48) dpm: but in that case, you can just install the language pack
(17.52.04) dpm: danilos, tried that already, I removed them all, no luck :)
(17.52.16) danilos: dpm, heh, ok, just guessing here

 IIRC, I made an USB key that worked well in Hungarian, so in this specific case may make sense to install language support. However, thinking about it a bit more, it does not seem to have much benefit from shipping translations in this package: those brave few who use USB-based systems other than installation, should be experienced enough - and for those not, the installer is already localized.

Revision history for this message
Martin Pitt (pitti) wrote :

Right, seems we can just drop it from the blacklist then. Thank you!

Changed in pkgbinarymangler (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
importance: Undecided → Low
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pkgbinarymangler - 70

---------------
pkgbinarymangler (70) maverick; urgency=low

  * Move "PPA" check from dpkg-deb to pkgmaintainermangler and
    pkgstriptranslations. We want to call pkgsanitychecks for PPA builds as
    well, and also control behaviour for PPAs individually for each mangler.
  * pkgstriptranslations: Run if we are building in an OEM PPA. If the built
    package is in Ubuntu main, strip translations from it. However, introduce
    a blacklist of OEM projects (oem_blacklist in striptranslations.conf)
    which are close or past release, to not inflict this rather intrusive
    change on them.
  * debian/control: Update Maintainer field from myself to Ubuntu Developers.
  * Add debian/source/format: 3.0 (native).
  * debian/control: Bump Standards-Version to 3.9.0.
  * Apply a consistent indentation to all source files (4 spaces, expand
    tabs).
  * dpkg-deb: Replace hardcoded paths with "which", to allow local testing.
  * Replace hardcoded "/CurrentlyBuilding" path with a $BUILDINFO variable set
    in "common", to allow local testing.
  * Add test/icecream: Test source package building two binary packages
    "vanilla" and "chocolate" with two po/mo files each.
  * Allow changing the path of "common" with $PKGBINARYMANGLER_COMMON_PATH.
  * Allow changing the configuration file directory path with
    $PKGBINARYMANGLER_CONF_DIR.
  * pkgmaintainermangler: Allow changing the path to the override file with
    $PKMAINTAINERGMANGLER_OVERRIDES.
  * Add test/run: Test suite for checking the scripts/config files in the
    local build tree in a sandbox on the "icecream" test package. Cover all
    current scenarios: main/universe/PPA/OEM/NO_PKG_MANGLE/partner/local/no
    mangler.
  * debian/rules: Run tests during build, and have a failed test suite fail
    the build. Add python and fakeroot build dependencies for this.
  * Add debian/pkgbinarymangler.lintian-overrides: We divert "dpkg-deb", no
    need to ship a manpage for it.
  * striptranslations.blacklist: Drop language-selector. (LP: #570240)
  * test/run: Add test case for updating of Installed-Size. This reproduces
    LP #451764.
  * pkgstriptranslations: Adapt Installed-Size: header in control file if we
    stripped any files. (LP: #451764)
 -- Martin Pitt <email address hidden> Fri, 09 Jul 2010 09:19:44 +0200

Changed in pkgbinarymangler (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.