the volume changed sound effects don't work on Ubuntu

Bug #538761 reported by Dylan McCall
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-settings-daemon (Ubuntu)
Fix Released
Low
Chris Coulson
Lucid
Fix Released
Low
Chris Coulson

Bug Description

Binary package hint: gnome-settings-daemon

First of all, a quick introduction to the (unfortunately not very well-known) component we have had for a few releases now, called libCanberra, which is used for sound events in the same style as icons.

In upstream's gnome-settings-daemon, the system tries to play the audio-volume-change sound effect when the user adjusts the volume with media control keys.

Granted, the sound is unimplemented in Ubuntu's default sound theme, but it absolutely exists in others. With the Freedesktop theme, the sound effect is an extremely helpful "pop" noise that indicates what the new volume is.
Although it only affects users with different sound themes, losing this feature is a regression. It also limits what can be done with Ubuntu's own sound theme, if that gets updated at some point.

Here is how the sound is played in gnome-settings-daemon ./plugins/media-keys/gsd-media-keys-manager.c in the update_dialog function:

ca_gtk_play_for_widget (manager->priv->dialog, 0,
    CA_PROP_EVENT_ID, "audio-volume-change",
    CA_PROP_EVENT_DESCRIPTION, "volume changed through key press",
    CA_PROP_APPLICATION_ID, "org.gnome.VolumeControl",
    NULL);

With our patch to gnome-settings-daemon to use libnotify for this event, the sound is not played, causing this rather unfortunate regression.
Please implement this feature for when a volume change is triggered in the libnotify-using version of gnome-settings-daemon.

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

update_dialog is still called with our patch, else the notification wouldn't work (the hooks for the libnotify notification are in update_dialog, so I'm not sure why you think it's never called)

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

The real issue is that we don't pass a widget to ca_gtk_play_for_widget

Changed in gnome-settings-daemon (Ubuntu):
assignee: nobody → Chris Coulson (chrisccoulson)
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Dylan McCall (dylanmccall) wrote :

Thanks for the help, Chris. Lack of cleverness on my part :)

Just updated the bug description to get rid of that error.

description: updated
description: updated
summary: - please play volume change sound effect (audio-volume-change) when volume
- is changed, like upstream
+ the volume changed sound effects don't work on Ubuntu
Revision history for this message
Dylan McCall (dylanmccall) wrote :

Working on sound support for notify-osd in bug #549900. Should lead in to a nice resolution for this bug :)
(Although it'll need some additional trickery beyond what is there; right now the sound would only play once, when the bubble first appears).

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Hmmm, I'm not sure what benefit that would bring really, we already have an abstraction library for handling event sounds (libcanberra). Shoehorning it in to libnotify to have it handled by notify-osd (which would just use libcanberra anyway) doesn't really seem like much win to me, or am i missing something?

Anyway, I will fix this in g-s-d before Lucid is released

Revision history for this message
Dylan McCall (dylanmccall) wrote :

The reason I'm doing that is it's already specified as something libnotify should support, so my patch is to implement that support.

Although, indeed, not trouble to use Canberra from the source. Come to think of it, now you've paused me for a moment, it would make more sense to not use the libnotify hint in this case. (Given the extra hacking that would be necessary and the thought that positional sounds would be darn cool for notifications except in this one case).
I'm just blindly obeying the all-knowing wiki :)

So, err, thanks and carry on!

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

I've pushed a fix for this to bzr now

Changed in gnome-settings-daemon (Ubuntu Lucid):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-settings-daemon - 2.29.92-0ubuntu4

---------------
gnome-settings-daemon (2.29.92-0ubuntu4) lucid; urgency=low

  * debian/patches/16_use_synchronous_notifications.patch:
    - Update so that volume change event sounds work correctly (LP: #538761)
 -- Chris Coulson <email address hidden> Sun, 28 Mar 2010 02:07:56 +0100

Changed in gnome-settings-daemon (Ubuntu Lucid):
status: Fix Committed → Fix Released
Revision history for this message
Dylan McCall (dylanmccall) wrote :

Just received the update here. I can confirm it's working well it's consistent with upstream. Thank you, Chris! :)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.