widelands

Dropdown button

Bug #536489 reported by Sigra
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Wishlist
Unassigned
widelands build20-rc1

Bug Description

There should be a dropdown button (like the back button in browsers, where the user gets a dropdown menu of previously visited pages).

Use cases are in LaunchSPG for selecting:
- Tribe
- Win condition
- Type of AI / Human Player
- Team number

See original description
Tags: ui

Related branches

lp:~widelands-dev/widelands/bug-536489-dropdown
SirVer: Approve
GunChleoc: Needs Resubmitting
kaputtnik (community): Approve (testing)
Klaus Halfmann: Approve (compile, test)
Diff: 1660 lines (+726/-199)
23 files modified
src/editor/ui_menus/main_menu_map_options.cc (+1/-1)
src/ui_basic/CMakeLists.txt (+2/-0)
src/ui_basic/button.cc (+9/-3)
src/ui_basic/button.h (+1/-2)
src/ui_basic/checkbox.cc (+3/-1)
src/ui_basic/dropdown.cc (+215/-0)
src/ui_basic/dropdown.h (+166/-0)
src/ui_basic/listselect.cc (+85/-34)
src/ui_basic/listselect.h (+45/-8)
src/ui_basic/panel.cc (+1/-1)
src/ui_basic/panel.h (+1/-1)
src/ui_basic/progressbar.cc (+2/-2)
src/ui_basic/scrollbar.cc (+2/-1)
src/ui_basic/slider.cc (+4/-0)
src/ui_basic/tabpanel.cc (+10/-12)
src/ui_basic/window.cc (+17/-13)
src/ui_fsmenu/launch_mpg.cc (+1/-1)
src/ui_fsmenu/launch_spg.cc (+101/-63)
src/ui_fsmenu/launch_spg.h (+20/-6)
src/ui_fsmenu/mapselect.cc (+2/-1)
src/ui_fsmenu/options.cc (+34/-40)
src/ui_fsmenu/options.h (+3/-8)
src/wui/game_objectives_menu.cc (+1/-1)
lp:~widelands-dev/widelands/bug-536489-pictorial-dropdown
kaputtnik (community): Approve (testing)
Diff: 1279 lines (+505/-200)
12 files modified
src/network/network_player_settings_backend.cc (+49/-52)
src/network/network_player_settings_backend.h (+10/-1)
src/ui_basic/button.cc (+20/-6)
src/ui_basic/button.h (+18/-0)
src/ui_basic/dropdown.cc (+149/-67)
src/ui_basic/dropdown.h (+73/-14)
src/ui_basic/listselect.cc (+23/-0)
src/ui_basic/listselect.h (+1/-0)
src/ui_fsmenu/launch_spg.cc (+1/-0)
src/ui_fsmenu/options.cc (+2/-0)
src/wui/building_statistics_menu.cc (+1/-0)
src/wui/multiplayersetupgroup.cc (+158/-60)
lp:~widelands-dev/widelands/multiplayer_dropdowns_2_init_team
SirVer: Needs Fixing
Diff: 2254 lines (+767/-580)
25 files modified
src/ai/computer_player.cc (+7/-6)
src/ai/computer_player.h (+17/-0)
src/ai/defaultai.h (+21/-18)
src/base/macros.h (+4/-0)
src/graphic/playercolor.h (+13/-0)
src/logic/CMakeLists.txt (+1/-0)
src/logic/game.cc (+3/-3)
src/logic/game_settings.h (+19/-2)
src/logic/single_player_game_settings_provider.cc (+8/-7)
src/network/gameclient.cc (+6/-4)
src/network/gameclient.h (+1/-1)
src/network/gamehost.cc (+30/-101)
src/network/network_player_settings_backend.cc (+118/-79)
src/network/network_player_settings_backend.h (+10/-12)
src/network/network_protocol.h (+3/-2)
src/notifications/note_ids.h (+3/-1)
src/ui_basic/dropdown.cc (+67/-12)
src/ui_basic/dropdown.h (+31/-2)
src/ui_basic/listselect.cc (+2/-2)
src/ui_fsmenu/launch_game.cc (+5/-6)
src/ui_fsmenu/launch_mpg.cc (+12/-10)
src/ui_fsmenu/launch_spg.cc (+5/-5)
src/wui/multiplayersetupgroup.cc (+372/-298)
src/wui/multiplayersetupgroup.h (+2/-2)
src/wui/playerdescrgroup.cc (+7/-7)
lp:~widelands-dev/widelands/multiplayer_dropdowns
SirVer: Approve (testing,compile,code-review)
kaputtnik (community): Approve (testing)
Diff: 2785 lines (+1002/-778)
29 files modified
src/ai/computer_player.cc (+7/-6)
src/ai/computer_player.h (+17/-0)
src/ai/defaultai.h (+21/-18)
src/graphic/playercolor.h (+13/-0)
src/logic/CMakeLists.txt (+1/-0)
src/logic/game.cc (+3/-3)
src/logic/game_settings.cc (+38/-1)
src/logic/game_settings.h (+47/-3)
src/logic/single_player_game_settings_provider.cc (+9/-8)
src/logic/single_player_game_settings_provider.h (+1/-1)
src/network/CMakeLists.txt (+0/-1)
src/network/gameclient.cc (+11/-6)
src/network/gameclient.h (+2/-2)
src/network/gamehost.cc (+76/-113)
src/network/gamehost.h (+1/-1)
src/network/network_player_settings_backend.cc (+58/-123)
src/network/network_player_settings_backend.h (+9/-20)
src/network/network_protocol.h (+3/-2)
src/notifications/note_ids.h (+3/-1)
src/ui_basic/dropdown.cc (+67/-12)
src/ui_basic/dropdown.h (+31/-2)
src/ui_basic/listselect.cc (+2/-2)
src/ui_fsmenu/launch_game.cc (+5/-6)
src/ui_fsmenu/launch_mpg.cc (+30/-20)
src/ui_fsmenu/launch_mpg.h (+1/-0)
src/ui_fsmenu/launch_spg.cc (+5/-5)
src/wui/multiplayersetupgroup.cc (+528/-409)
src/wui/multiplayersetupgroup.h (+6/-6)
src/wui/playerdescrgroup.cc (+7/-7)
Revision history for this message
Raul Ferriz (raul.ferriz) wrote :

This is not the same as listselect from ui_basic?

Revision history for this message
Timowi (timo-wingender) wrote :

There's a difference. A listselect is a area with some lines where you can select from. A dropdown button is a button which pops up a list if you click on it.

Changed in widelands:
status: New → Confirmed
importance: Undecided → Low
Hans Joachim Desserud (hjd)
tags: added: ui
Revision history for this message
SirVer (sirver) wrote :

Setting to incomplete for bug sweeping.

Changed in widelands:
status: Confirmed → Incomplete
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

I don't know if the use case listed in the original bug report is realistic, however having a dropdown controller would be neat. I guess the prime example is tribe selection which is currenlty implemented as a single button you click multiple times. While it works, many users will not be familiar with or expect buttons to change values like this. A dropdown on the other hand is much clearer at communicating that there is a selected value but other options are available too.

Hans Joachim Desserud (hjd)
Changed in widelands:
status: Incomplete → Confirmed
importance: Low → Wishlist
Revision history for this message
SirVer (sirver) wrote :

Setting to incomplete for bug sweeping.

Changed in widelands:
status: Confirmed → Incomplete
Revision history for this message
wl-zocker (wl-zocker) wrote :

I agree with #4. The tribe selection is a bit strange.

Was this bug marked for sweeping for the second time intentionally?

Revision history for this message
GunChleoc (gunchleoc) wrote :

Sweeping comes around whenever the bug has not had any changes for X days.

The use case with multiple enhancements for the buildings as stated by OP is no longer there. Another use case would be selecting the win conditions or the AI type.

Changed in widelands:
status: Incomplete → Confirmed
description: updated
GunChleoc (gunchleoc)
Changed in widelands:
assignee: nobody → GunChleoc (gunchleoc)
status: Confirmed → In Progress
milestone: none → build20-rc1
Revision history for this message
kaputtnik (franku) wrote :
GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.