attempt to get canonical_url of a review diff
Bug #525857 reported by
Aaron Bentley
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Aaron Bentley | ||
Bug Description
The fix for bug 328271 introduced a new bug for old code reviews that have only a review diff (not a preview diff). It tries to retrieve the review diff's canonical_url, but this is not defined, resulting in oopses like:
OOPS-1514EC664
Related branches
lp:~abentley/launchpad/restricted-diffs
- Tim Penhey (community): Approve
-
Diff: 109 lines (+36/-6)4 files modifiedlib/lp/code/browser/configure.zcml (+6/-0)
lib/lp/code/browser/diff.py (+12/-4)
lib/lp/code/browser/tests/test_tales.py (+12/-1)
lib/lp/testing/factory.py (+6/-1)
| tags: | added: oops |
| Changed in launchpad-code: | |
| assignee: | nobody → Aaron Bentley (abentley) |
| status: | Triaged → Fix Committed |
| status: | Fix Committed → In Progress |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-code: | |
| milestone: | none → 10.02 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
