Use the restricted librarian for diffs for private branches

Setting to High since this *is* a security bug.

Perhaps we should use the private librarian for all diffs, since public branches may become private after the diff is generated.

2009/7/3 Aaron Bentley <email address hidden>:
> Perhaps we should use the private librarian for all diffs, since public
> branches may become private after the diff is generated.

It's nice that one can drag the diff url from a mp page into eg a
shell window or irc client, and then use it from an http client that
may not have a Launchpad login. It seems like your proposal may break
that.

I think if we've previously published a diff it's reasonable that it
should stay public, as long as in emergencies a LOSA can intervene to
delete it.

--
Martin <http://launchpad.net/~mbp/>

On Fri, Jul 3, 2009 at 6:09 AM, Martin Pool<email address hidden> wrote:
> 2009/7/3 Aaron Bentley <email address hidden>:
>> Perhaps we should use the private librarian for all diffs, since public
>> branches may become private after the diff is generated.
>
> It's nice that one can drag the diff url from a mp page into eg a
> shell window or irc client, and then use it from an http client that
> may not have a Launchpad login.  It seems like your proposal may break
> that.

The proposal doesn't have to break that. Launchpad proxies files from
the private Librarian. If the branches are public, it can serve the
diffs to unauthenticated users if it wants.

--
Stuart Bishop <email address hidden>
http://www.stuartbishop.net/