Don't let offscreen widgets do grab adds

Bug #512427 reported by Cody Russell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gtk+2.0 (Ubuntu)
Fix Released
Low
Sebastien Bacher

Bug Description

Widgets inside GtkOffscreenWindow seem like they should not be allowed to do grab the mouse or whatever, as this can deactivate open menus and stuff.

Revision history for this message
Cody Russell (bratsche) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work there

Changed in gtk+2.0 (Ubuntu):
assignee: nobody → Sebastien Bacher (seb128)
importance: Undecided → Low
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtk+2.0 - 2.19.3-1ubuntu4

---------------
gtk+2.0 (2.19.3-1ubuntu4) lucid; urgency=low

  * debian/patches/071_no_offscreen_widgets_grabbing.patch:
    - change by Cody Russell to not let offscreen widgets do grabbing
      (Lp: #512427)
 -- Sebastien Bacher <email address hidden> Mon, 25 Jan 2010 23:13:51 +0100

Changed in gtk+2.0 (Ubuntu):
status: New → Fix Released
Revision history for this message
Alistair Buxton (a-j-buxton) wrote :

This patch causes an annoying g_critical if you add a grab on a widget before it is realized. In this case toplevel->window will be null.

This also make me wonder what happens if you add a grab to an offscreen widget before realizing it.

Revision history for this message
djb (djb0) wrote :

This patch has propagated to Debian too, where it causes this

every time a GtkComboBox with wrap-width not set is opened.

This seems bad. Can this patch be removed? I'm not sure it's applicable in 2016. It's weird also that a patch with such a weak synopsis was accepted:

"seem like they should not be allowed to do grab the mouse or whatever"

What was that supposed to mean?

Revision history for this message
djb (djb0) wrote :

The bug this causes is

(GameConqueror.py:19834): Gdk-CRITICAL **: gdk_window_get_window_type: assertion 'GDK_IS_WINDOW (window)' failed

as documented here

https://bugzilla.gnome.org/show_bug.cgi?id=771242

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.